[GitHub] [incubator-nuttx] patacongo commented on issue #495: SPI: Change spi_send() interface to support of 32-bit word transfer

[GitBox <gi...@apache.org>]

patacongo commented on issue #495: SPI: Change spi_send() interface to support of 32-bit word transfer
URL: https://github.com/apache/incubator-nuttx/pull/495#issuecomment-596219405
 
 
   Two comments:
   
   1) We need to get past all of the automated checks before we do anything.  In this case, it is not getting far because most of the modified files do not conform completely to the coding standard.  We need to decide what to do there because that blocks the other build tests.
   
   2) I would like to get a broader community input.  This does not have any effect on me personally, so I do not really have an opinion.  The only rather small issue that I see is that for the majority of SPI drivers that only support short SPI transfers, this does add some overhead.
   
   I think that the people who are really affected are all of the NuttX uses who have private SPI drivers.   This will cause some code breakage for users of NuttX.  We need to make sure that we consider the concerns of those other users who have SPI drivers that are not in the source tree.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services