You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "bobhan1 (via GitHub)" <gi...@apache.org> on 2025/04/30 05:57:57 UTC
[PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
bobhan1 opened a new pull request, #50564:
URL: https://github.com/apache/doris/pull/50564
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2851397578
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2849090491
<details>
<summary>TPC-DS: <b>Total hot run time: 192335 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4, data reload: false
query1 1407 1093 1035 1035
query2 6317 1771 1785 1771
query3 11023 4597 4600 4597
query4 52969 25449 22950 22950
query5 5051 529 456 456
query6 342 216 199 199
query7 4886 506 287 287
query8 330 259 245 245
query9 5740 2554 2565 2554
query10 432 318 264 264
query11 15055 14964 14856 14856
query12 157 112 108 108
query13 1051 514 404 404
query14 10107 6246 6285 6246
query15 200 213 178 178
query16 7083 655 492 492
query17 1076 751 598 598
query18 1555 420 333 333
query19 212 200 170 170
query20 131 122 117 117
query21 205 139 109 109
query22 4276 4476 4284 4284
query23 34176 33496 33550 33496
query24 6587 2392 2405 2392
query25 481 465 405 405
query26 706 278 156 156
query27 2306 516 339 339
query28 2964 2150 2119 2119
query29 575 562 435 435
query30 278 222 195 195
query31 866 855 779 779
query32 75 64 66 64
query33 456 361 328 328
query34 782 864 535 535
query35 811 844 752 752
query36 923 995 924 924
query37 113 108 77 77
query38 4155 4191 4310 4191
query39 1501 1444 1441 1441
query40 220 124 108 108
query41 56 53 52 52
query42 123 107 107 107
query43 498 495 490 490
query44 1320 811 808 808
query45 205 179 168 168
query46 848 1041 645 645
query47 1849 1883 1816 1816
query48 387 429 308 308
query49 696 519 424 424
query50 664 706 403 403
query51 4263 4213 4160 4160
query52 115 110 99 99
query53 222 257 191 191
query54 589 597 549 549
query55 83 84 81 81
query56 327 318 288 288
query57 1135 1165 1173 1165
query58 269 262 257 257
query59 2690 2681 2706 2681
query60 327 321 328 321
query61 135 123 132 123
query62 742 759 687 687
query63 244 192 197 192
query64 1820 1057 776 776
query65 4389 4263 4196 4196
query66 776 411 334 334
query67 15690 15641 15320 15320
query68 7177 863 507 507
query69 540 290 265 265
query70 1218 1074 1040 1040
query71 508 328 294 294
query72 5596 4703 4728 4703
query73 1406 600 338 338
query74 8843 8956 8959 8956
query75 3940 3205 2727 2727
query76 4259 1196 744 744
query77 655 384 275 275
query78 9962 10125 9324 9324
query79 2688 795 576 576
query80 628 507 444 444
query81 495 256 218 218
query82 454 123 99 99
query83 349 259 231 231
query84 289 106 88 88
query85 772 348 314 314
query86 346 305 294 294
query87 4511 4494 4387 4387
query88 3197 2198 2216 2198
query89 424 318 276 276
query90 1967 204 206 204
query91 144 142 112 112
query92 76 61 55 55
query93 1155 936 574 574
query94 680 411 308 308
query95 369 316 290 290
query96 485 554 268 268
query97 3153 3200 3097 3097
query98 294 209 208 208
query99 1441 1373 1291 1291
Total cold run time: 296063 ms
Total hot run time: 192335 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #50564:
URL: https://github.com/apache/doris/pull/50564#discussion_r2070563618
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -532,8 +532,9 @@ Status CloudMetaMgr::sync_tablet_rowsets_unlocked(CloudTablet* tablet,
? GetRowsetRequest::NO_DICT
: GetRowsetRequest::RETURN_DICT);
VLOG_DEBUG << "send GetRowsetRequest: " << req.ShortDebugString();
-
+ auto start = std::chrono::high_resolution_clock::now();
Review Comment:
use steady_clock instead?
also check other occurences.
![Uploading image.png…]()
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -532,8 +532,9 @@ Status CloudMetaMgr::sync_tablet_rowsets_unlocked(CloudTablet* tablet,
? GetRowsetRequest::NO_DICT
: GetRowsetRequest::RETURN_DICT);
VLOG_DEBUG << "send GetRowsetRequest: " << req.ShortDebugString();
-
+ auto start = std::chrono::high_resolution_clock::now();
Review Comment:
use steady_clock instead?
also check other occurences.
<img width="1023" alt="image" src="https://github.com/user-attachments/assets/2ca934b6-c4eb-43a0-a25d-d7caadd142b8" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #50564:
URL: https://github.com/apache/doris/pull/50564#discussion_r2070563618
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -532,8 +532,9 @@ Status CloudMetaMgr::sync_tablet_rowsets_unlocked(CloudTablet* tablet,
? GetRowsetRequest::NO_DICT
: GetRowsetRequest::RETURN_DICT);
VLOG_DEBUG << "send GetRowsetRequest: " << req.ShortDebugString();
-
+ auto start = std::chrono::high_resolution_clock::now();
Review Comment:
use steady_clock instead?
also check other occurences.
<img width="1023" alt="image" src="https://github.com/user-attachments/assets/2ca934b6-c4eb-43a0-a25d-d7caadd142b8" />
<img width="1013" alt="image" src="https://github.com/user-attachments/assets/f0c58199-d895-44e2-82eb-912998189018" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2849146987
# BE Regression && UT Coverage Report
Increment line coverage `0.00% (0/47)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50564_b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50564_b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 80.36% (21350/26569) |
| Line Coverage | 74.36% (220121/296018) |
| Region Coverage | 72.66% (132405/182217) |
| Branch Coverage | 65.96% (67659/102574) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2840888035
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2844759930
<details>
<summary>TPC-DS: <b>Total hot run time: 189883 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3d2cf259c0ce7816b880d29b9dcdee586e9b76dd, data reload: false
query1 1402 1088 1043 1043
query2 6194 1791 1832 1791
query3 11016 4600 4397 4397
query4 55072 25977 23399 23399
query5 5057 498 461 461
query6 373 221 222 221
query7 4927 508 287 287
query8 316 277 240 240
query9 6023 2592 2594 2592
query10 447 313 258 258
query11 15074 15074 14951 14951
query12 161 107 102 102
query13 1066 503 387 387
query14 10193 6344 6317 6317
query15 209 205 173 173
query16 7087 663 470 470
query17 1094 747 623 623
query18 1543 410 347 347
query19 195 182 160 160
query20 128 128 128 128
query21 208 121 104 104
query22 4368 4475 4194 4194
query23 34273 33446 33453 33446
query24 6712 2425 2398 2398
query25 475 479 406 406
query26 726 276 145 145
query27 2465 497 353 353
query28 3117 2147 2117 2117
query29 594 584 422 422
query30 274 219 189 189
query31 874 845 811 811
query32 75 66 67 66
query33 448 375 317 317
query34 781 868 507 507
query35 802 838 753 753
query36 952 1007 930 930
query37 113 102 80 80
query38 4318 4201 4187 4187
query39 1486 1417 1430 1417
query40 207 126 105 105
query41 55 51 52 51
query42 119 107 106 106
query43 490 494 482 482
query44 1329 823 845 823
query45 184 178 164 164
query46 834 1078 634 634
query47 1815 1886 1768 1768
query48 388 419 327 327
query49 699 500 430 430
query50 674 687 405 405
query51 4266 4226 4109 4109
query52 111 106 99 99
query53 218 257 200 200
query54 606 572 514 514
query55 92 80 86 80
query56 296 298 290 290
query57 1216 1230 1127 1127
query58 281 258 264 258
query59 2613 2833 2574 2574
query60 322 334 301 301
query61 128 130 125 125
query62 744 751 672 672
query63 227 192 186 186
query64 1886 1037 691 691
query65 4467 4160 4254 4160
query66 712 392 303 303
query67 15843 15742 15325 15325
query68 7470 886 506 506
query69 541 324 254 254
query70 1225 1126 1119 1119
query71 561 310 298 298
query72 5517 4702 2359 2359
query73 1310 592 346 346
query74 8975 9124 8903 8903
query75 3697 3191 2763 2763
query76 4264 1174 768 768
query77 611 369 331 331
query78 10140 10106 9273 9273
query79 2307 810 571 571
query80 632 502 433 433
query81 485 255 233 233
query82 422 125 94 94
query83 370 240 232 232
query84 294 95 88 88
query85 797 353 306 306
query86 389 279 282 279
query87 4374 4420 4312 4312
query88 3147 2234 2207 2207
query89 407 306 285 285
query90 1907 207 205 205
query91 147 137 109 109
query92 80 55 59 55
query93 1206 952 577 577
query94 682 393 299 299
query95 369 299 289 289
query96 479 561 275 275
query97 3158 3248 3141 3141
query98 230 210 207 207
query99 1471 1428 1268 1268
Total cold run time: 299124 ms
Total hot run time: 189883 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2844880765
# BE UT Coverage Report
Increment line coverage `0.00% (0/45)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/3d2cf259c0ce7816b880d29b9dcdee586e9b76dd_3d2cf259c0ce7816b880d29b9dcdee586e9b76dd/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/3d2cf259c0ce7816b880d29b9dcdee586e9b76dd_3d2cf259c0ce7816b880d29b9dcdee586e9b76dd/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 54.91% (14799/26953) |
| Line Coverage | 44.02% (129951/295217) |
| Region Coverage | 42.73% (66336/155258) |
| Branch Coverage | 37.25% (33417/89708) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2851902914
# BE Regression && UT Coverage Report
Increment line coverage `0.00% (0/47)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50564_b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50564_b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 80.20% (21308/26569) |
| Line Coverage | 74.38% (220174/296018) |
| Region Coverage | 72.69% (132454/182217) |
| Branch Coverage | 66.03% (67726/102574) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #50564:
URL: https://github.com/apache/doris/pull/50564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2841312532
<details>
<summary>TPC-DS: <b>Total hot run time: 184960 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c799d3bcfe82a17bfa8f8a67b03836f3e7903ff0, data reload: false
query1 1005 497 473 473
query2 6583 1817 1815 1815
query3 6751 223 232 223
query4 26027 23900 22961 22961
query5 4370 626 448 448
query6 309 206 205 205
query7 4626 499 305 305
query8 299 252 240 240
query9 8651 2540 2539 2539
query10 485 311 263 263
query11 15630 15062 14780 14780
query12 162 109 109 109
query13 1659 530 415 415
query14 8927 6067 6197 6067
query15 198 179 169 169
query16 7259 627 473 473
query17 1199 701 567 567
query18 1966 394 308 308
query19 185 177 153 153
query20 115 115 115 115
query21 215 121 104 104
query22 4222 4120 4171 4120
query23 33834 32919 33040 32919
query24 8409 2369 2366 2366
query25 516 454 376 376
query26 1234 261 164 164
query27 2745 487 332 332
query28 4381 2094 2080 2080
query29 787 548 424 424
query30 278 210 188 188
query31 918 853 729 729
query32 69 65 63 63
query33 555 384 325 325
query34 809 855 531 531
query35 789 813 754 754
query36 943 957 887 887
query37 110 97 76 76
query38 4231 4182 4109 4109
query39 1457 1393 1389 1389
query40 217 122 107 107
query41 62 62 64 62
query42 122 112 107 107
query43 484 510 488 488
query44 1273 794 838 794
query45 180 180 168 168
query46 825 1009 636 636
query47 1714 1801 1724 1724
query48 373 449 294 294
query49 779 498 398 398
query50 680 667 405 405
query51 4112 4149 4161 4149
query52 105 111 97 97
query53 226 250 184 184
query54 558 570 504 504
query55 85 78 81 78
query56 288 293 286 286
query57 1120 1156 1059 1059
query58 257 252 252 252
query59 2592 2720 2553 2553
query60 319 333 293 293
query61 124 123 125 123
query62 781 759 647 647
query63 226 180 190 180
query64 4365 1009 674 674
query65 4331 4250 4277 4250
query66 1139 413 306 306
query67 15648 15653 15331 15331
query68 8658 880 554 554
query69 473 300 254 254
query70 1174 1121 1107 1107
query71 470 314 280 280
query72 5560 4750 4834 4750
query73 730 670 345 345
query74 9002 8783 8904 8783
query75 4054 3192 2683 2683
query76 3688 1177 752 752
query77 771 373 282 282
query78 10055 10247 9216 9216
query79 2092 816 573 573
query80 576 509 445 445
query81 482 252 213 213
query82 514 130 98 98
query83 251 260 236 236
query84 252 105 78 78
query85 861 407 310 310
query86 391 297 262 262
query87 4297 4429 4199 4199
query88 3522 2174 2211 2174
query89 385 307 289 289
query90 1830 206 216 206
query91 164 140 112 112
query92 79 60 56 56
query93 1632 960 584 584
query94 646 422 300 300
query95 372 283 350 283
query96 473 557 267 267
query97 3154 3173 3117 3117
query98 225 209 197 197
query99 1337 1424 1242 1242
Total cold run time: 274063 ms
Total hot run time: 184960 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2841099568
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2844740777
<details>
<summary>TPC-H: <b>Total hot run time: 33902 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3d2cf259c0ce7816b880d29b9dcdee586e9b76dd, data reload: false
------ Round 1 ----------------------------------
q1 25887 5162 5022 5022
q2 2057 274 177 177
q3 10416 1241 685 685
q4 10225 1010 535 535
q5 7528 2414 2309 2309
q6 180 160 130 130
q7 910 749 596 596
q8 9291 1299 1128 1128
q9 7019 5232 5218 5218
q10 6866 2286 1889 1889
q11 480 281 275 275
q12 350 351 209 209
q13 17771 3609 3043 3043
q14 227 219 207 207
q15 535 480 476 476
q16 410 428 370 370
q17 631 860 387 387
q18 7481 7130 7074 7074
q19 1232 958 593 593
q20 354 327 230 230
q21 4346 3351 2416 2416
q22 1014 1032 933 933
Total cold run time: 115210 ms
Total hot run time: 33902 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5092 5026 5135 5026
q2 233 317 225 225
q3 2129 2620 2282 2282
q4 1333 1757 1376 1376
q5 4436 4406 4414 4406
q6 207 164 127 127
q7 1972 1934 1790 1790
q8 2558 2522 2511 2511
q9 7203 7298 7034 7034
q10 2949 3146 2707 2707
q11 580 489 491 489
q12 704 773 614 614
q13 3505 3867 3300 3300
q14 298 299 261 261
q15 511 473 467 467
q16 432 480 439 439
q17 1179 1560 1384 1384
q18 7657 7577 7353 7353
q19 800 825 835 825
q20 1964 1980 1834 1834
q21 5163 4652 4755 4652
q22 1097 1025 1011 1011
Total cold run time: 52002 ms
Total hot run time: 50113 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2853042474
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2841325192
<details>
<summary>ClickBench: <b>Total hot run time: 29.46 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c799d3bcfe82a17bfa8f8a67b03836f3e7903ff0, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.11 0.10
query3 0.26 0.20 0.20
query4 1.59 0.19 0.20
query5 0.60 0.58 0.60
query6 1.20 0.71 0.71
query7 0.02 0.02 0.01
query8 0.05 0.04 0.03
query9 0.57 0.53 0.51
query10 0.57 0.56 0.58
query11 0.16 0.11 0.11
query12 0.15 0.11 0.11
query13 0.61 0.59 0.60
query14 0.78 0.81 0.81
query15 0.87 0.84 0.86
query16 0.41 0.39 0.39
query17 1.05 1.00 1.03
query18 0.21 0.19 0.20
query19 1.91 1.85 1.77
query20 0.01 0.01 0.01
query21 15.40 0.91 0.56
query22 0.76 1.18 0.77
query23 14.85 1.35 0.60
query24 7.29 1.33 1.03
query25 0.48 0.15 0.18
query26 0.52 0.17 0.14
query27 0.05 0.05 0.05
query28 9.79 0.79 0.43
query29 12.53 3.95 3.23
query30 0.26 0.09 0.07
query31 2.82 0.58 0.38
query32 3.24 0.55 0.47
query33 3.08 3.07 3.04
query34 15.87 5.20 4.49
query35 4.55 4.61 4.51
query36 0.66 0.49 0.48
query37 0.09 0.07 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.03
query40 0.16 0.14 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.04
Total cold run time: 103.81 s
Total hot run time: 29.46 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2841536295
# BE UT Coverage Report
Increment line coverage `0.00% (0/47)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/c799d3bcfe82a17bfa8f8a67b03836f3e7903ff0_c799d3bcfe82a17bfa8f8a67b03836f3e7903ff0/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/c799d3bcfe82a17bfa8f8a67b03836f3e7903ff0_c799d3bcfe82a17bfa8f8a67b03836f3e7903ff0/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 54.89% (14793/26952) |
| Line Coverage | 43.99% (129870/295195) |
| Region Coverage | 42.70% (66290/155249) |
| Branch Coverage | 37.22% (33387/89702) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2849085352
<details>
<summary>TPC-H: <b>Total hot run time: 33734 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4, data reload: false
------ Round 1 ----------------------------------
q1 25987 5184 4962 4962
q2 2073 292 174 174
q3 10390 1269 681 681
q4 10229 1004 515 515
q5 7523 2322 2757 2322
q6 184 163 132 132
q7 917 737 627 627
q8 9305 1285 1072 1072
q9 6817 5070 5104 5070
q10 6843 2309 1877 1877
q11 488 282 263 263
q12 350 352 214 214
q13 17776 3677 3034 3034
q14 219 221 208 208
q15 531 488 507 488
q16 416 431 385 385
q17 597 855 369 369
q18 7512 7238 7157 7157
q19 1709 941 558 558
q20 337 319 218 218
q21 3901 3349 2427 2427
q22 1040 984 981 981
Total cold run time: 115144 ms
Total hot run time: 33734 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5141 5097 5026 5026
q2 227 327 229 229
q3 2150 2652 2242 2242
q4 1314 1728 1348 1348
q5 4449 4364 4402 4364
q6 221 166 124 124
q7 1954 1932 1732 1732
q8 2620 2521 2515 2515
q9 7232 7234 6887 6887
q10 3033 3164 2750 2750
q11 576 530 487 487
q12 657 751 618 618
q13 3500 3870 3267 3267
q14 280 291 282 282
q15 520 499 498 498
q16 450 476 421 421
q17 1146 1556 1358 1358
q18 7820 7617 7385 7385
q19 821 806 787 787
q20 1957 2035 1892 1892
q21 4886 4702 4704 4702
q22 1101 1075 990 990
Total cold run time: 52055 ms
Total hot run time: 49904 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2856862613
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2851397945
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2841283788
<details>
<summary>TPC-H: <b>Total hot run time: 34257 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c799d3bcfe82a17bfa8f8a67b03836f3e7903ff0, data reload: false
------ Round 1 ----------------------------------
q1 26017 5092 5042 5042
q2 2094 305 190 190
q3 10445 1262 749 749
q4 10239 1051 533 533
q5 7650 2331 2413 2331
q6 182 164 138 138
q7 914 745 631 631
q8 9326 1322 1120 1120
q9 6838 5073 5099 5073
q10 6814 2306 1870 1870
q11 477 291 267 267
q12 372 352 215 215
q13 17794 3711 3162 3162
q14 230 228 211 211
q15 536 483 490 483
q16 416 430 369 369
q17 619 862 401 401
q18 7573 7317 7166 7166
q19 1814 966 598 598
q20 348 348 233 233
q21 4567 3506 2499 2499
q22 1073 1005 976 976
Total cold run time: 116338 ms
Total hot run time: 34257 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5228 5098 5058 5058
q2 251 330 233 233
q3 2157 2662 2293 2293
q4 1417 1828 1477 1477
q5 4570 4480 4395 4395
q6 211 169 129 129
q7 1985 1920 1702 1702
q8 2589 2467 2511 2467
q9 7264 7057 7122 7057
q10 3004 3206 2771 2771
q11 554 533 486 486
q12 677 771 609 609
q13 3543 3918 3337 3337
q14 293 297 287 287
q15 525 481 483 481
q16 425 506 425 425
q17 1199 1508 1395 1395
q18 7640 7463 7356 7356
q19 861 901 1013 901
q20 2008 2015 1853 1853
q21 5169 4685 4642 4642
q22 1078 1030 991 991
Total cold run time: 52648 ms
Total hot run time: 50345 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2844695170
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2844771555
<details>
<summary>ClickBench: <b>Total hot run time: 28.71 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3d2cf259c0ce7816b880d29b9dcdee586e9b76dd, data reload: false
query1 0.04 0.03 0.04
query2 0.12 0.10 0.12
query3 0.26 0.19 0.19
query4 1.59 0.20 0.20
query5 0.58 0.58 0.60
query6 1.18 0.71 0.72
query7 0.02 0.01 0.02
query8 0.04 0.04 0.04
query9 0.58 0.52 0.52
query10 0.57 0.58 0.56
query11 0.16 0.11 0.10
query12 0.14 0.11 0.11
query13 0.61 0.60 0.60
query14 0.78 0.80 0.81
query15 0.87 0.84 0.84
query16 0.39 0.38 0.39
query17 1.03 1.00 1.02
query18 0.21 0.20 0.20
query19 1.92 1.77 1.84
query20 0.02 0.01 0.01
query21 15.41 0.88 0.55
query22 0.75 1.29 0.75
query23 14.74 1.40 0.60
query24 7.44 1.12 0.36
query25 0.45 0.18 0.12
query26 0.65 0.15 0.13
query27 0.05 0.05 0.05
query28 9.28 0.94 0.45
query29 12.55 3.94 3.29
query30 0.25 0.10 0.06
query31 2.82 0.60 0.39
query32 3.23 0.55 0.46
query33 3.00 3.13 3.03
query34 15.86 5.09 4.44
query35 4.53 4.51 4.49
query36 0.68 0.48 0.48
query37 0.08 0.06 0.06
query38 0.05 0.04 0.04
query39 0.02 0.02 0.02
query40 0.17 0.13 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.03 0.02
Total cold run time: 103.26 s
Total hot run time: 28.71 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #50564:
URL: https://github.com/apache/doris/pull/50564#discussion_r2070563618
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -532,8 +532,9 @@ Status CloudMetaMgr::sync_tablet_rowsets_unlocked(CloudTablet* tablet,
? GetRowsetRequest::NO_DICT
: GetRowsetRequest::RETURN_DICT);
VLOG_DEBUG << "send GetRowsetRequest: " << req.ShortDebugString();
-
+ auto start = std::chrono::high_resolution_clock::now();
Review Comment:
use steady_clock instead
also check other occurences.
<img width="1023" alt="image" src="https://github.com/user-attachments/assets/2ca934b6-c4eb-43a0-a25d-d7caadd142b8" />
<img width="1013" alt="image" src="https://github.com/user-attachments/assets/f0c58199-d895-44e2-82eb-912998189018" />
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -532,8 +532,9 @@ Status CloudMetaMgr::sync_tablet_rowsets_unlocked(CloudTablet* tablet,
? GetRowsetRequest::NO_DICT
: GetRowsetRequest::RETURN_DICT);
VLOG_DEBUG << "send GetRowsetRequest: " << req.ShortDebugString();
-
+ auto start = std::chrono::high_resolution_clock::now();
Review Comment:
use steady_clock instead
also check other occurrences.
<img width="1023" alt="image" src="https://github.com/user-attachments/assets/2ca934b6-c4eb-43a0-a25d-d7caadd142b8" />
<img width="1013" alt="image" src="https://github.com/user-attachments/assets/f0c58199-d895-44e2-82eb-912998189018" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2844979117
# BE Regression && UT Coverage Report
Increment line coverage `0.00% (0/45)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50564_3d2cf259c0ce7816b880d29b9dcdee586e9b76dd_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50564_3d2cf259c0ce7816b880d29b9dcdee586e9b76dd_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 80.14% (21196/26450) |
| Line Coverage | 74.20% (218648/294687) |
| Region Coverage | 72.60% (131848/181621) |
| Branch Coverage | 65.87% (67358/102254) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2842438178
# BE Regression && UT Coverage Report
Increment line coverage `0.00% (0/47)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50564_c799d3bcfe82a17bfa8f8a67b03836f3e7903ff0_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50564_c799d3bcfe82a17bfa8f8a67b03836f3e7903ff0_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 80.16% (21202/26449) |
| Line Coverage | 74.21% (218678/294665) |
| Region Coverage | 72.58% (131820/181615) |
| Branch Coverage | 65.88% (67362/102250) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2849113241
# BE UT Coverage Report
Increment line coverage `0.00% (0/47)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4_b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4_b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.03% (14896/27070) |
| Line Coverage | 44.16% (130943/296530) |
| Region Coverage | 42.84% (66726/155774) |
| Branch Coverage | 37.37% (33634/89996) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2849066546
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2849092472
<details>
<summary>ClickBench: <b>Total hot run time: 29.14 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b4e3b8b01f8d0c28c7cce33501f99cd3219fc0c4, data reload: false
query1 0.04 0.04 0.02
query2 0.14 0.11 0.12
query3 0.26 0.19 0.20
query4 1.58 0.20 0.19
query5 0.59 0.58 0.60
query6 1.18 0.71 0.71
query7 0.02 0.02 0.02
query8 0.05 0.03 0.04
query9 0.58 0.53 0.51
query10 0.56 0.58 0.56
query11 0.15 0.10 0.10
query12 0.15 0.12 0.11
query13 0.61 0.59 0.60
query14 0.78 0.81 0.81
query15 0.87 0.85 0.84
query16 0.38 0.38 0.39
query17 1.00 1.02 1.00
query18 0.21 0.19 0.20
query19 1.97 1.81 1.82
query20 0.01 0.01 0.02
query21 15.41 0.94 0.56
query22 0.75 1.14 0.66
query23 14.99 1.36 0.61
query24 7.30 0.93 0.89
query25 0.47 0.16 0.09
query26 0.64 0.16 0.14
query27 0.05 0.05 0.05
query28 9.36 0.88 0.43
query29 12.58 3.98 3.32
query30 0.26 0.09 0.07
query31 2.82 0.59 0.37
query32 3.22 0.53 0.46
query33 3.05 3.02 3.00
query34 15.78 5.07 4.46
query35 4.52 4.53 4.48
query36 0.67 0.49 0.48
query37 0.09 0.07 0.06
query38 0.06 0.04 0.03
query39 0.03 0.02 0.02
query40 0.17 0.14 0.14
query41 0.08 0.03 0.02
query42 0.04 0.02 0.03
query43 0.04 0.03 0.02
Total cold run time: 103.51 s
Total hot run time: 29.14 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](profile) More profile for `OlapScanLocalState::hold_tablets` [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50564:
URL: https://github.com/apache/doris/pull/50564#issuecomment-2856862574
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org