You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Christian Köberl (JIRA)" <de...@tapestry.apache.org> on 2008/08/19 16:51:44 UTC
[jira] Updated: (TAPESTRY-2605) Built-in ValidationMessages cannot
be overridden with contribution
[ https://issues.apache.org/jira/browse/TAPESTRY-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Köberl updated TAPESTRY-2605:
---------------------------------------
Priority: Minor (was: Major)
Description:
If you contribute validation messages with "contributeValidationMessagesSource" for a language without built-in texts provided the texts are overridden by the English built-in versions.
The reason for this seems to be in MessagesSourceImpl#findBundleProperties. Here, the bundle values are cached in a simple Map. The code calls MessagesSourceImpl#extend which overrides all contributed messages with the default ones (even in another language).
There is no really simple way to fix this - that's why I did not provide a patch. One solution could be to use an OrderedConfiguration for MessageSources or to have something like factory-defaults vs. application-defaults.
I provided a patch for the ValidationMessagesSourceImplTest - this makes the test fail because of this issue (just to make it more understandable).
was:
If you contribute validation messages with "contributeValidationMessagesSource" for a language without built-in texts provided the texts are overriden by the English built-in versions.
The reason for this seems to be in MessagesSourceImpl#findBundleProperties. Here, the bundle values are cached in a simple Map. The code calls MessagesSourceImpl#extend which overrides all contributed messages with the default ones (even in another language).
There is no really simple way to fix this - that's why I did not provide a patch. One solution could be to use an OrderedConfiguration for MessageSources or to have something like factory-defaults vs. application-defaults.
I provided a patch for the ValidationMessagesSourceImplTest - this makes the test fail because of this issue (just to make it more understandable).
Summary: Built-in ValidationMessages cannot be overridden with contribution (was: Built-in ValidationMessages cannot be overriden with contribution)
> Built-in ValidationMessages cannot be overridden with contribution
> ------------------------------------------------------------------
>
> Key: TAPESTRY-2605
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2605
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.13, 5.0.14
> Reporter: Christian Köberl
> Priority: Minor
> Attachments: ValidationMessagesSourceImplTest.patch
>
>
> If you contribute validation messages with "contributeValidationMessagesSource" for a language without built-in texts provided the texts are overridden by the English built-in versions.
> The reason for this seems to be in MessagesSourceImpl#findBundleProperties. Here, the bundle values are cached in a simple Map. The code calls MessagesSourceImpl#extend which overrides all contributed messages with the default ones (even in another language).
> There is no really simple way to fix this - that's why I did not provide a patch. One solution could be to use an OrderedConfiguration for MessageSources or to have something like factory-defaults vs. application-defaults.
> I provided a patch for the ValidationMessagesSourceImplTest - this makes the test fail because of this issue (just to make it more understandable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org