[jira] [Commented] (GEODE-3340) Refactor ConfigCommandsDUnitTest to use test rules

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111459#comment-16111459 ] 

ASF GitHub Bot commented on GEODE-3340:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/679

    GEODE-3340: Refactor ConfigCommandsDUnitTest to use test rules

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3340)
    
    `ConfigCommandsDUnitTest` extended `CliCommandsTestBase`, a deprecated class. It has been updated to use current test rules, and it also runs independently over HTTP (no longer is run through `CommandOverHttpDUnitTest`).
    
    - [x] JIRA ticket referenced
    
    - [x] PR rebased
    
    - [x] Commit is single and squashed
    
    - [ ] `gradlew build` runs cleanly
    
    - [x] Tests updated
    
    **Precheckin Status: In progress**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3340

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #679
    
----

----


> Refactor ConfigCommandsDUnitTest to use test rules
> --------------------------------------------------
>
>                 Key: GEODE-3340
>                 URL: https://issues.apache.org/jira/browse/GEODE-3340
>             Project: Geode
>          Issue Type: Sub-task
>          Components: tests
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> {{ConfigCommandsDUnitTest}} is using {{CliCommandTestBase}}, which is a deprecated class. It should be refactored to use more current test rules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)