You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/08/26 04:33:14 UTC
Change in asterixdb[master]: Introduce MessagingNetworkManager for NC2NC AppMessaging
Till Westmann has posted comments on this change.
Change subject: Introduce MessagingNetworkManager for NC2NC AppMessaging
......................................................................
Patch Set 7: Code-Review+2
Before you rebase and submit, could you
1) add a sanitized version (e.g. no links to example merge proposals) of your comments in patch set 4 on stopping the MessageDeliveryService in the the NCMessageBroker to the class and
2) fix the long lines that SonarQube is complaining about?
--
To view, visit https://asterix-gerrit.ics.uci.edu/897
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c0bd7c11c1e78954ebceff49cb274d8073a64bd
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No