You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by GitBox <gi...@apache.org> on 2022/12/25 22:16:28 UTC
[GitHub] [jena-site] kinow opened a new pull request, #136: Upgrade to Bootstrap 5
kinow opened a new pull request, #136:
URL: https://github.com/apache/jena-site/pull/136
This will take a while, but I think I can slowly add more commits and changes here until our site is upgraded to the latest version of Bootstrap.
I already liked how the text looked with the new fonts. Luckily we don't rely a lot on the Bootstrap styles, and our docs are quite simple. So it shouldn't be too hard.
Once this is done, I will combine with another change I have stashed to add an automatic table of contents with Hugo, fixed on the sidebar (as right now I have to scroll up and down to navigate the contents :grimacing: ) - https://github.com/apache/jena-site/compare/main...kinow:sidebar-toc?expand=1
Cheers
Bruno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #136: Upgrade to Bootstrap 5
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #136:
URL: https://github.com/apache/jena-site/pull/136#issuecomment-1402110150
> Could you let dev@ know the site appearance has changed when you've merged this? Thanks.
Done!
https://markmail.org/thread/dcfebajupxs2vmao
Thanks!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #136: Upgrade to Bootstrap 5
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #136:
URL: https://github.com/apache/jena-site/pull/136#issuecomment-1383146708
Rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow merged pull request #136: Upgrade to Bootstrap 5
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow merged PR #136:
URL: https://github.com/apache/jena-site/pull/136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #136: Upgrade to Bootstrap 5
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #136:
URL: https://github.com/apache/jena-site/pull/136#issuecomment-1381067100
@afs, others, I think this is ready for review :+1: It should create a better experience for readers, and also make it look a little closer to Fuseki UI (fonts, elements, etc.). I will prepare another PR after this one is merged to propose a change to table of contents.
Some screenshots of before/after for posterity.
Cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #136: Upgrade to Bootstrap 5
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #136:
URL: https://github.com/apache/jena-site/pull/136#issuecomment-1381069405
To review: simply run `hugo server watch` to render it locally. I modified the RDF API to use backticks and chose a programming language for the editor to have different code highlight. Also tested a few other pages with the breadcrumb, icons (getting started), code, tables, etc.
But it would still be good for others to take a look if the rest of the content is rendering correctly.
Icons were not a drop-in replacement. So anywhere we had icons before, will need to be manually adjusted to the new Bootstrap icons.
I also tested mobile/responsive, including the navigation menu. The only breaking changes, I think, were:
- Moved three top menu items to the right as I think we could separate all into two categories
- The Jena logo at the top menu is slightly bigger
- The getting started used Jena's logo for each entry, but I used icons as in the top level menu
Glad to adjust it based on any feedback :+1:
-Bruno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org