[GitHub] [flink] lirui-apache commented on a change in pull request #11116: [FLINK-15349] add 'create catalog' DDL to blink planner

[GitBox <gi...@apache.org>]

lirui-apache commented on a change in pull request #11116: [FLINK-15349] add 'create catalog' DDL to blink planner
URL: https://github.com/apache/flink/pull/11116#discussion_r381654413
 
 

 ##########
 File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
 ##########
 @@ -55,6 +55,30 @@ SqlUseCatalog SqlUseCatalog() :
     }
 }
 
+/**
+* Parses a create catalog statement.
+* CREATE CATALOG catalog_name [WITH (property_name=property_value, ...)];
+*/
+SqlCreate SqlCreateCatalog(Span s, boolean replace) :
+{
+    SqlParserPos startPos;
+    SqlIdentifier catalogName;
+    SqlNodeList propertyList = SqlNodeList.EMPTY;
+}
+{
+    <CATALOG> { startPos = getPos(); }
+    catalogName = CompoundIdentifier()
 
 Review comment:
   Why do we support CompoundIdentifier for catalog names?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services