[GitHub] [netbeans] mbien commented on a diff in pull request #4999: upgrade to maven-indexer 7.0.1

["mbien (via GitHub)" <gi...@apache.org>]

mbien commented on code in PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#discussion_r1179972882


##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:
##########
@@ -534,12 +532,22 @@ private void indexLoadedRepo(final RepositoryInfo repo, boolean updateLocal) thr
                         httpwagon.setHttpHeaders(p);
                     }
 
-                    Path tmpStorage = Files.createTempDirectory("index-extraction");
+                    Path tmpStorage = Files.createTempDirectory(getIndexDirectory(), "extractor-");

Review Comment:
   note to self: this is extracting directly into cache right now. I am not convinced that this is a good idea since this requires the cleanup on failure/cancel/system.exit to work reliably.
   
   The advantage of this approach is that only the compressed archive will land in tmp - which should fit even into small tmp folders.



##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:
##########
@@ -637,6 +644,10 @@ private void indexLoadedRepo(final RepositoryInfo repo, boolean updateLocal) thr
         }
     }
 
+    private static void pauseRemoteRepoIndexing() {
+        RepositoryPreferences.pauseIndexDownloadsFor(2, ChronoUnit.MINUTES); // pause a while  // TODO use reasonable duration

Review Comment:
   TODO: forgot to change this number



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists