You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/01/03 10:26:56 UTC
Re: Review Request 41848: Do not enable task and executor run on
different resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/
-----------------------------------------------------------
(Updated 一月 3, 2016, 9:26 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
Summary (updated)
-----------------
Do not enable task and executor run on different resources.
Bugs: MESOS-3931
https://issues.apache.org/jira/browse/MESOS-3931
Repository: mesos
Description (updated)
-------
Do not enable task and its executor run on different resources. They
must run on same kind of resources, either non-revocable resources, usage
slack resources or allocation slack resources.
Diffs
-----
src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
Diff: https://reviews.apache.org/r/41848/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 41848: Do not enable task and executor run on
different resources.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/#review113212
-----------------------------------------------------------
src/master/validation.cpp (line 486)
<https://reviews.apache.org/r/41848/#comment173709>
Update error message to report `USAGE_SLACK` and `ALLOCATION_SLACK` mix usage.
- Klaus Ma
On Jan. 3, 2016, 5:26 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41848/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 5:26 p.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
>
>
> Bugs: MESOS-3931
> https://issues.apache.org/jira/browse/MESOS-3931
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not enable task and its executor run on different resources. They
> must run on same kind of resources, either non-revocable resources, usage
> slack resources or allocation slack resources.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
>
> Diff: https://reviews.apache.org/r/41848/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 41848: Do not enable task and executor run on
different resources.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 8, 2016, 2:02 a.m., Jian Qiu wrote:
> > maybe should also add a test case with mix of usage slack and allocation slack?
Yes.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/#review113389
-----------------------------------------------------------
On 一月 7, 2016, 11:26 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41848/
> -----------------------------------------------------------
>
> (Updated 一月 7, 2016, 11:26 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
>
>
> Bugs: MESOS-3931
> https://issues.apache.org/jira/browse/MESOS-3931
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not enable task and its executor run on different resources. They
> must run on same kind of resources, either non-revocable resources, usage
> slack resources or allocation slack resources.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
>
> Diff: https://reviews.apache.org/r/41848/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 41848: Do not enable task and executor run on
different resources.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/#review113389
-----------------------------------------------------------
maybe should also add a test case with mix of usage slack and allocation slack?
- Jian Qiu
On 一月 7, 2016, 11:26 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41848/
> -----------------------------------------------------------
>
> (Updated 一月 7, 2016, 11:26 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
>
>
> Bugs: MESOS-3931
> https://issues.apache.org/jira/browse/MESOS-3931
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not enable task and its executor run on different resources. They
> must run on same kind of resources, either non-revocable resources, usage
> slack resources or allocation slack resources.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
>
> Diff: https://reviews.apache.org/r/41848/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 41848: Do not enable task and executor run on
different resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/
-----------------------------------------------------------
(Updated 三月 11, 2016, 9:12 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
Bugs: MESOS-3931
https://issues.apache.org/jira/browse/MESOS-3931
Repository: mesos
Description
-------
Do not enable task and executor run on different resources.
Diffs (updated)
-----
src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca
src/tests/master_validation_tests.cpp c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25
Diff: https://reviews.apache.org/r/41848/diff/
Testing
-------
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="TaskValidationTest.*" --verbose
Thanks,
Guangya Liu
Re: Review Request 41848: Do not enable task and executor run on
different resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/
-----------------------------------------------------------
(Updated 一月 23, 2016, 6:05 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
Bugs: MESOS-3931
https://issues.apache.org/jira/browse/MESOS-3931
Repository: mesos
Description (updated)
-------
Do not enable task and executor run on different resources.
Diffs (updated)
-----
src/master/validation.cpp 222bb3451c133844c42caad0567c1e98de6ba778
src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
Diff: https://reviews.apache.org/r/41848/diff/
Testing
-------
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="TaskValidationTest.*" --verbose
Thanks,
Guangya Liu
Re: Review Request 41848: Do not enable task and executor run on
different resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/
-----------------------------------------------------------
(Updated 一月 13, 2016, 2:28 p.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
Bugs: MESOS-3931
https://issues.apache.org/jira/browse/MESOS-3931
Repository: mesos
Description
-------
Do not enable task and its executor run on different resources. They
must run on same kind of resources, either non-revocable resources, usage
slack resources or allocation slack resources.
Diffs (updated)
-----
src/master/validation.cpp c7cf56815fc743ff52ef423b23d78398ad1b35a3
src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
Diff: https://reviews.apache.org/r/41848/diff/
Testing (updated)
-------
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="TaskValidationTest.*" --verbose
Thanks,
Guangya Liu
Re: Review Request 41848: Do not enable task and executor run on
different resources.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 7, 2016, 11:38 p.m., Joseph Wu wrote:
> > src/master/validation.cpp, line 487
> > <https://reviews.apache.org/r/41848/diff/2/?file=1186200#file1186200line487>
> >
> > This is probably not necessary.
> >
> > Before you'd see:
> > "Task (and its executor, if exists) uses both revocable and non-revocable cpus".
> >
> > With your change, it becomes:
> > "Task (and its executor, if exists) uses both revocable and non-revocable cpus(*){USAGE_SLACK}:1".
> >
> > I prefer the first one.
I want to handle the case if there are both usage slack and allocation slack, such as:
"Task (and its executor, if exists) uses both revocable and non-revocable cpus(*){USAGE_SLACK}:1;cpus(*){ALLOCATION_SLACK}:2".
But the above message may not accurate, as the error can also promoted if no non-revocable resources but only allocation slack and usage slack. Seems the error message needs to be udated.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/#review113354
-----------------------------------------------------------
On 一月 7, 2016, 11:26 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41848/
> -----------------------------------------------------------
>
> (Updated 一月 7, 2016, 11:26 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
>
>
> Bugs: MESOS-3931
> https://issues.apache.org/jira/browse/MESOS-3931
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not enable task and its executor run on different resources. They
> must run on same kind of resources, either non-revocable resources, usage
> slack resources or allocation slack resources.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
>
> Diff: https://reviews.apache.org/r/41848/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 41848: Do not enable task and executor run on
different resources.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/#review113354
-----------------------------------------------------------
Overall, the changes and tests LGTM.
src/master/validation.cpp (line 487)
<https://reviews.apache.org/r/41848/#comment173901>
This is probably not necessary.
Before you'd see:
"Task (and its executor, if exists) uses both revocable and non-revocable cpus".
With your change, it becomes:
"Task (and its executor, if exists) uses both revocable and non-revocable cpus(*){USAGE_SLACK}:1".
I prefer the first one.
- Joseph Wu
On Jan. 7, 2016, 3:26 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41848/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 3:26 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
>
>
> Bugs: MESOS-3931
> https://issues.apache.org/jira/browse/MESOS-3931
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not enable task and its executor run on different resources. They
> must run on same kind of resources, either non-revocable resources, usage
> slack resources or allocation slack resources.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
>
> Diff: https://reviews.apache.org/r/41848/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 41848: Do not enable task and executor run on
different resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/
-----------------------------------------------------------
(Updated 一月 7, 2016, 11:26 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
Bugs: MESOS-3931
https://issues.apache.org/jira/browse/MESOS-3931
Repository: mesos
Description
-------
Do not enable task and its executor run on different resources. They
must run on same kind of resources, either non-revocable resources, usage
slack resources or allocation slack resources.
Diffs (updated)
-----
src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
Diff: https://reviews.apache.org/r/41848/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu