You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/04/26 16:25:44 UTC

svn commit: r1877031 - /pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java

Author: tilman
Date: Sun Apr 26 16:25:44 2020
New Revision: 1877031

URL: http://svn.apache.org/viewvc?rev=1877031&view=rev
Log:
PDFBOX-3017: close files in case of exception (not doing it broke upcoming TSA test)

Modified:
    pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java

Modified: pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java?rev=1877031&r1=1877030&r2=1877031&view=diff
==============================================================================
--- pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java (original)
+++ pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java Sun Apr 26 16:25:44 2020
@@ -29,6 +29,7 @@ import java.security.NoSuchAlgorithmExce
 import java.security.UnrecoverableKeyException;
 import java.security.cert.CertificateException;
 import java.util.Calendar;
+import org.apache.pdfbox.io.IOUtils;
 
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.pdmodel.interactive.digitalsignature.ExternalSigningSupport;
@@ -106,9 +107,17 @@ public class CreateSignature extends Cre
         FileOutputStream fos = new FileOutputStream(outFile);
 
         // sign
-        PDDocument doc = PDDocument.load(inFile);
-        signDetached(doc, fos);
-        doc.close();
+        PDDocument doc = null;
+        try
+        {
+            doc = PDDocument.load(inFile);
+            signDetached(doc, fos);
+        }
+        finally
+        {
+            IOUtils.closeQuietly(doc);
+            IOUtils.closeQuietly(fos);
+        }
     }
 
     public void signDetached(PDDocument document, OutputStream output)