You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Icemist (via GitHub)" <gi...@apache.org> on 2023/01/27 02:10:49 UTC

[GitHub] [tvm] Icemist opened a new pull request, #13852: [TIR] Handle nullptr returned by FindEntryFunc

Icemist opened a new pull request, #13852:
URL: https://github.com/apache/tvm/pull/13852

   The FindEntryFunc function can return a null pointer. In development I got this situation, which appears as a segfault.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #13852: [TIR] Handle nullptr returned by FindEntryFunc

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #13852:
URL: https://github.com/apache/tvm/pull/13852#issuecomment-1405931276

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao merged pull request #13852: [TIR] Handle nullptr returned by FindEntryFunc

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #13852:
URL: https://github.com/apache/tvm/pull/13852


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Icemist commented on pull request #13852: [TIR] Handle nullptr returned by FindEntryFunc

Posted by "Icemist (via GitHub)" <gi...@apache.org>.
Icemist commented on PR #13852:
URL: https://github.com/apache/tvm/pull/13852#issuecomment-1405931458

   cc @masahi @echuraev 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #13852: [TIR] Handle nullptr returned by FindEntryFunc

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #13852:
URL: https://github.com/apache/tvm/pull/13852#issuecomment-1406005191

   Quick question: do you think it’s necessary to add a unittest?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org