[GitHub] [iceberg] rdblue commented on a diff in pull request #5156: Spark 3.3: [FOLLOW UP] Support AS OF SPARK SQL syntax for TimeTravel E2E

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5156:
URL: https://github.com/apache/iceberg/pull/5156#discussion_r909699203


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java:
##########
@@ -164,6 +166,16 @@ public String extractCatalog(CaseInsensitiveStringMap options) {
     return catalogAndIdentifier(options).catalog().name();
   }
 
+  @Override
+  public Optional<String> extractTimeTravelVersion(CaseInsensitiveStringMap options) {
+    return Optional.ofNullable(PropertyUtil.propertyAsString(options, "versionAsOf", null));

Review Comment:
   Where did these strings come from? Are they standard in Spark?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org