[GitHub] [spark] rdblue commented on a change in pull request #31083: [SPARK-34026][SQL] Inject repartition and sort nodes to satisfy required distribution and ordering

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #31083:
URL: https://github.com/apache/spark/pull/31083#discussion_r553579178



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
##########
@@ -627,21 +627,22 @@ abstract class StreamExecution(
       inputPlan.schema,
       new CaseInsensitiveStringMap(options.asJava))
     val writeBuilder = table.newWriteBuilder(info)
-    outputMode match {
+    val write = outputMode match {

Review comment:
       I definitely prefer separate PRs for batch and streaming, since streaming tends to touch a lot more classes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org