You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by eymorale <gi...@git.apache.org> on 2015/10/07 15:49:00 UTC
[GitHub] cordova-ios pull request: CB-9719 set allow_non_modular_includes t...
GitHub user eymorale opened a pull request:
https://github.com/apache/cordova-ios/pull/171
CB-9719 set allow_non_modular_includes to yes
Ran into some issues with git so did a new pull request. @shazron @csantanapr I added that setting change in build.xcconfig and confirmed that it picks up the setting both in xcode and in the cli
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eymorale/cordova-ios CB-9719
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #171
----
commit 721e82e757cd80cffeae55e0bdb296cd16c6eaee
Author: Edna Morales <ed...@gmail.com>
Date: 2015-10-07T13:46:56Z
CB-9719 set allow_non_modular_includes to yes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9719 set allow_non_modular_includes t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/171#issuecomment-147561614
I fixed the test failure above and ran the tests myself, they pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9719 set allow_non_modular_includes t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org