You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/28 13:24:39 UTC
[GitHub] [beam] TobKed opened a new pull request #12716: [BEAM-10831] Fix broken Beam Dependency Check Report
TobKed opened a new pull request #12716:
URL: https://github.com/apache/beam/pull/12716
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace
--- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on a change in pull request #12716: [BEAM-10831] Fix broken Beam Dependency Check Report
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #12716:
URL: https://github.com/apache/beam/pull/12716#discussion_r479450128
##########
File path: .test-infra/jenkins/CommonJobProperties.groovy
##########
@@ -34,7 +34,10 @@ class CommonJobProperties {
String defaultBranch = 'master',
int defaultTimeout = 100,
boolean allowRemotePoll = true,
- String jenkinsExecutorLabel = 'beam') {
+ String jenkinsExecutorLabel = 'beam',
+ boolean cleanWorkspace = true) {
+
+ context.disabled()
Review comment:
🙀 good point @tvalentyn . It is unwanted leftover from testing it on another Jenkins with some additional changes in CommonJobProperties. I deleted in recent fixup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on pull request #12716: [BEAM-10831] Fix broken Beam Dependency Check Report
Posted by GitBox <gi...@apache.org>.
TobKed commented on pull request #12716:
URL: https://github.com/apache/beam/pull/12716#issuecomment-682726013
R: @aaltay @tvalentyn @kamilwu @mwalenia @pawelpasterz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #12716: [BEAM-10831] Fix broken Beam Dependency Check Report
Posted by GitBox <gi...@apache.org>.
tvalentyn merged pull request #12716:
URL: https://github.com/apache/beam/pull/12716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on a change in pull request #12716: [BEAM-10831] Fix broken Beam Dependency Check Report
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #12716:
URL: https://github.com/apache/beam/pull/12716#discussion_r479452898
##########
File path: .test-infra/jenkins/CommonJobProperties.groovy
##########
@@ -34,7 +34,10 @@ class CommonJobProperties {
String defaultBranch = 'master',
int defaultTimeout = 100,
boolean allowRemotePoll = true,
- String jenkinsExecutorLabel = 'beam') {
+ String jenkinsExecutorLabel = 'beam',
+ boolean cleanWorkspace = true) {
+
+ context.disabled()
Review comment:
For testing purposes on testing Jenkins jobs were disabled.
It refers to this method:
https://jenkinsci.github.io/job-dsl-plugin/#method/javaposse.jobdsl.dsl.jobs.WorkflowJob.disabled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on pull request #12716: [BEAM-10831] Fix broken Beam Dependency Check Report
Posted by GitBox <gi...@apache.org>.
TobKed commented on pull request #12716:
URL: https://github.com/apache/beam/pull/12716#issuecomment-682868712
I updated `excludePattern` after ensuring it works properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a change in pull request #12716: [BEAM-10831] Fix broken Beam Dependency Check Report
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #12716:
URL: https://github.com/apache/beam/pull/12716#discussion_r479439721
##########
File path: .test-infra/jenkins/CommonJobProperties.groovy
##########
@@ -34,7 +34,10 @@ class CommonJobProperties {
String defaultBranch = 'master',
int defaultTimeout = 100,
boolean allowRemotePoll = true,
- String jenkinsExecutorLabel = 'beam') {
+ String jenkinsExecutorLabel = 'beam',
+ boolean cleanWorkspace = true) {
+
+ context.disabled()
Review comment:
For my education, what does this do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on a change in pull request #12716: [BEAM-10831] Fix broken Beam Dependency Check Report
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #12716:
URL: https://github.com/apache/beam/pull/12716#discussion_r479450128
##########
File path: .test-infra/jenkins/CommonJobProperties.groovy
##########
@@ -34,7 +34,10 @@ class CommonJobProperties {
String defaultBranch = 'master',
int defaultTimeout = 100,
boolean allowRemotePoll = true,
- String jenkinsExecutorLabel = 'beam') {
+ String jenkinsExecutorLabel = 'beam',
+ boolean cleanWorkspace = true) {
+
+ context.disabled()
Review comment:
🙀 good point @tvalentyn . It is unwanted leftover from testing it on another Jenkins with some additional changes in CommonJobProperties. I deleted it in recent fixup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org