You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Rogan Carr <ro...@gmail.com> on 2017/04/11 16:36:26 UTC

Implementations of PipelineDataConverters in C#

Hi All,

I've recently started to develop using REEF, and I'm excited to join in on
the Apache REEF effort!

I noticed that for pipelining messages, the C# codebase only has the
DefaultPipelineDataConverter [1]. I have a need to pipeline arrays of data,
so I've implemented a set of ArrayPipelineDataConverters, as well as
associated unit tests.
  - FloatArrayPipelineDataConverter
  - DoubleArrayPipelineDataConverter
  - IntArrayPipelineDataConverter
  - LongArrayPipelineDataConverter

I'd prefer to check these into REEF itself because I think they could be
valuable to others, and I would rather share such base implementations with
other projects than hold my own version.

I haven't found an open issue on REEF associated with this work. Would the
community be interested in these? If so, I can start an issue in REEF's
JIRA.

Best,
Rogan

[1]
https://github.com/apache/reef/blob/master/lang/cs/Org.Apache.REEF.Network/Group/Pipelining/Impl/DefaultPipelineDataConverter.cs

Re: Implementations of PipelineDataConverters in C#

Posted by Rogan Carr <ro...@gmail.com>.
Hi All,

I've opened up issue REEF-1772 [1] to track these issue.

I'll send a PR against this JIRA issue, following the contributor
guidelines.

Best,
Rogan

[1] https://issues.apache.org/jira/browse/REEF-1772

On Tue, Apr 11, 2017 at 10:33 AM, Markus Weimer <ma...@weimo.de> wrote:

>
> On 2017-04-11 10:21 AM, Rogan Carr wrote:
>
>> Awesome! Can you post your JIRA user ID here such that we can give
>>> you the right access rights?
>>>
>>>
>> My JIRA user ID is rogan.
>>
>
> Thanks! I have added you to the JIRA `Contributor` group. You should now
> be able to create and self-assign issues on REEF's JIRA project [0].
>
> Also, now might be a good time to have a look at our contributor's guide
> [1]. Please don't hesitate to ask questions on this list if anything in
> that guide is unclear or doesn't make sense to you. We are striving to
> make the guide as good as it can be, but rarely have an opportunity to
> get feedback from a newcomer to the process.
>
> Thanks!
>
> Markus
>
> [0]: https://issues.apache.org/jira/browse/REEF
> [1]: https://cwiki.apache.org/confluence/display/REEF/Contributing
>

Re: Implementations of PipelineDataConverters in C#

Posted by Markus Weimer <ma...@weimo.de>.
On 2017-04-11 10:21 AM, Rogan Carr wrote:
>> Awesome! Can you post your JIRA user ID here such that we can give
>> you the right access rights?
>>
>
> My JIRA user ID is rogan.

Thanks! I have added you to the JIRA `Contributor` group. You should now
be able to create and self-assign issues on REEF's JIRA project [0].

Also, now might be a good time to have a look at our contributor's guide
[1]. Please don't hesitate to ask questions on this list if anything in
that guide is unclear or doesn't make sense to you. We are striving to
make the guide as good as it can be, but rarely have an opportunity to
get feedback from a newcomer to the process.

Thanks!

Markus

[0]: https://issues.apache.org/jira/browse/REEF
[1]: https://cwiki.apache.org/confluence/display/REEF/Contributing

Re: Implementations of PipelineDataConverters in C#

Posted by Rogan Carr <ro...@gmail.com>.
On Tue, Apr 11, 2017 at 10:16 AM, Markus Weimer <ma...@weimo.de> wrote:

> I haven't found an open issue on REEF associated with this work.
>
>> Would the community be interested in these?
>>
>
> +1 on having them in the code base!
>

Excellent!

If so, I can start an issue in REEF's JIRA.
>>
>
> Awesome! Can you post your JIRA user ID here such that we can give you
> the right access rights?
>

My JIRA user ID is rogan.

Thanks for your help!

Best,
Rogan

Re: Implementations of PipelineDataConverters in C#

Posted by Markus Weimer <ma...@weimo.de>.
On 2017-04-11 9:36 AM, Rogan Carr wrote:
> I've recently started to develop using REEF, and I'm excited to join
> in on the Apache REEF effort!

Welcome, Rogan!

> I haven't found an open issue on REEF associated with this work.
> Would the community be interested in these?

+1 on having them in the code base!

> If so, I can start an issue in REEF's JIRA.

Awesome! Can you post your JIRA user ID here such that we can give you
the right access rights?

Thanks!

Markus