You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/20 02:03:15 UTC
[GitHub] [arrow-ballista] andygrove opened a new pull request, #251: WIP: Attempt to fix scheduler UI in docker
andygrove opened a new pull request, #251:
URL: https://github.com/apache/arrow-ballista/pull/251
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-ballista/issues/250
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I would the UI to work
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Try and proxy API requests to the scheduler process
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
nginx config
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on a diff in pull request #251: Fix Scheduler UI in Docker image
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #251:
URL: https://github.com/apache/arrow-ballista/pull/251#discussion_r975627080
##########
ballista/rust/scheduler/src/api/mod.rs:
##########
@@ -85,7 +85,7 @@ fn with_data_server<T: AsLogicalPlan + Clone, U: 'static + AsExecutionPlan>(
pub fn get_routes<T: AsLogicalPlan + Clone, U: 'static + AsExecutionPlan>(
scheduler_server: SchedulerServer<T, U>,
) -> BoxedFilter<(impl Reply,)> {
- let routes = warp::path("state")
+ let routes = warp::path!("api" / "state")
Review Comment:
Agreed. I am just beginning to learn about the warp framework, so will see if this can be avoided as I learn more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove merged pull request #251: Fix Scheduler UI in Docker image
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #251:
URL: https://github.com/apache/arrow-ballista/pull/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #251: Fix Scheduler UI in Docker image
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #251:
URL: https://github.com/apache/arrow-ballista/pull/251#issuecomment-1252658854
Thanks for the reviews @yahoNanJing and @avantgardnerio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] avantgardnerio commented on a diff in pull request #251: Fix Scheduler UI in Docker image
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on code in PR #251:
URL: https://github.com/apache/arrow-ballista/pull/251#discussion_r975497077
##########
ballista/rust/scheduler/src/api/mod.rs:
##########
@@ -85,7 +85,7 @@ fn with_data_server<T: AsLogicalPlan + Clone, U: 'static + AsExecutionPlan>(
pub fn get_routes<T: AsLogicalPlan + Clone, U: 'static + AsExecutionPlan>(
scheduler_server: SchedulerServer<T, U>,
) -> BoxedFilter<(impl Reply,)> {
- let routes = warp::path("state")
+ let routes = warp::path!("api" / "state")
Review Comment:
overloading the `/` operator? Nothing to do with this PR, but not a fan after seeing abuse in C++ & C#.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #251: Fix Scheduler UI in Docker image
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #251:
URL: https://github.com/apache/arrow-ballista/pull/251#issuecomment-1252293681
@yahoNanJing @thinkharderdev @avantgardnerio This is ready for review. Once this is merged, I will create a PR to add a list of jobs and the ability to view job status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing commented on pull request #251: Fix Scheduler UI in Docker image
Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on PR #251:
URL: https://github.com/apache/arrow-ballista/pull/251#issuecomment-1252556639
Thanks @andygrove. LGTM. Verified at my env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org