You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/13 18:25:10 UTC
[GitHub] [fineract] thesmallstar opened a new pull request #763: Added Empty
Statement Check and enforced checkstyle
thesmallstar opened a new pull request #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763
## Description
No functional changes, Code formatting , indent fix and empty statement checktyle enforce :)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] thesmallstar commented on issue #763: Added Empty
Statement Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on issue #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763#issuecomment-613112143
Not sure why integration tests failed, probably due to other PR? If not, I will give a detailed look tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #763: Added Empty Statement
Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763#issuecomment-615511259
@thesmallstar @awasum see https://issues.apache.org/jira/browse/FINERACT-898 for another test failure - and this one is very very weird...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #763: Added Empty Statement
Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763#issuecomment-613039617
@thesmallstar this seems to include an (arbitrary?) number of "break lines up" changes - was that intentional? It would perhaps be clearer both for me to review and for you to do if in each PR you only include the changes strictly required to make the respective module (here `EmptyStatement`) pass? Just a thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] thesmallstar opened a new pull request #763: Added Empty
Statement Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar opened a new pull request #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763
## Description
No functional changes, Code formatting , indent fix and empty statement checktyle enforce :)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger closed pull request #763: Added Empty
Statement Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #763: Added Empty Statement
Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763#issuecomment-613890443
> Not sure why integration tests failed, probably due to other PR? If not, I will give a detailed look tomorrow.
@thesmallstar re. build failure, please subscribe to and watch (or help fix??) #764 and #761 for [FINERACT-852](https://issues.apache.org/jira/browse/FINERACT-852)...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] thesmallstar commented on issue #763: Added Empty
Statement Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on issue #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763#issuecomment-613043458
@vorburger, agreed on your point,making changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #763: Added Empty Statement
Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763#issuecomment-615480339
@thesmallstar @awasum see https://issues.apache.org/jira/browse/FINERACT-886 for another test failure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger closed pull request #763: Added Empty
Statement Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #763: Added Empty Statement
Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763#issuecomment-615402789
@thesmallstar Following #764 and #761 this will pass the build (or not at least not fail because of integration tests) if you rebase this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] thesmallstar opened a new pull request #763: Added Empty
Statement Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar opened a new pull request #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763
## Description
No functional changes, Code formatting , indent fix and empty statement checktyle enforce :)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] thesmallstar commented on issue #763: Added Empty
Statement Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on issue #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763#issuecomment-615473676
@vorburger the build failed even after rebase, did I miss something? The build passes locally though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] thesmallstar commented on issue #763: Added Empty
Statement Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on issue #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763#issuecomment-615459042
@vorburger , thank you for the update. Sorry, I could not reply to the previous comment, I had been busy in online college exams.
-thanks :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #763: Added Empty Statement
Check and enforced checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #763: Added Empty Statement Check and enforced checkstyle
URL: https://github.com/apache/fineract/pull/763#issuecomment-615534614
@thesmallstar please rebase and fix merge conflict from #767.
The build error due to FINERACT-898 hopefully will disappear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services