You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2023/03/01 09:51:06 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request, #24406: Adapt `SKIP_ENCRYPT_REWRITE` to `SKIP_SQL_REWRITE` for more scenarios
strongduanmu opened a new pull request, #24406:
URL: https://github.com/apache/shardingsphere/pull/24406
Fixes #24403.
Changes proposed in this pull request:
- Adapt `SKIP_ENCRYPT_REWRITE` to `SKIP_SQL_REWRITE` for more scenarios
- add sql rewrite test case
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 merged pull request #24406: Adapt `SKIP_ENCRYPT_REWRITE` to `SKIP_SQL_REWRITE` for more scenarios
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 merged PR #24406:
URL: https://github.com/apache/shardingsphere/pull/24406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24406: Adapt `SKIP_ENCRYPT_REWRITE` to `SKIP_SQL_REWRITE` for more scenarios
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24406:
URL: https://github.com/apache/shardingsphere/pull/24406#issuecomment-1449939771
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24406](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66ba0ca) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c506eb02778d78e2297bad5c9bf20f82b575daff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c506eb0) will **decrease** coverage by `0.04%`.
> The diff coverage is `45.45%`.
> :exclamation: Current head 66ba0ca differs from pull request most recent head 0378032. Consider uploading reports for the commit 0378032 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24406 +/- ##
============================================
- Coverage 50.04% 50.00% -0.04%
Complexity 1583 1583
============================================
Files 3248 3248
Lines 53531 53533 +2
Branches 9863 9865 +2
============================================
- Hits 26788 26768 -20
- Misses 24353 24370 +17
- Partials 2390 2395 +5
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ite/context/EncryptSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29udGV4dC9FbmNyeXB0U1FMUmV3cml0ZUNvbnRleHREZWNvcmF0b3IuamF2YQ==) | `12.90% <0.00%> (ø)` | |
| [...ra/binder/statement/CommonSQLStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L0NvbW1vblNRTFN0YXRlbWVudENvbnRleHQuamF2YQ==) | `77.27% <0.00%> (-3.68%)` | :arrow_down: |
| [...tate/exception/UnavailableDataSourceException.java](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3N0YXRlL2V4Y2VwdGlvbi9VbmF2YWlsYWJsZURhdGFTb3VyY2VFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/shardingsphere/infra/hint/HintValueContext.java](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L0hpbnRWYWx1ZUNvbnRleHQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../shardingsphere/infra/rewrite/SQLRewriteEntry.java](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9TUUxSZXdyaXRlRW50cnkuamF2YQ==) | `78.26% <0.00%> (-7.46%)` | :arrow_down: |
| [...phere/infra/rewrite/context/SQLRewriteContext.java](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9jb250ZXh0L1NRTFJld3JpdGVDb250ZXh0LmphdmE=) | `95.00% <50.00%> (-5.00%)` | :arrow_down: |
| [...he/shardingsphere/infra/hint/SQLHintExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRFeHRyYWN0b3IuamF2YQ==) | `75.86% <100.00%> (ø)` | |
| [...hardingsphere/infra/hint/SQLHintPropertiesKey.java](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRQcm9wZXJ0aWVzS2V5LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...apache/shardingsphere/infra/hint/SQLHintUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRVdGlscy5qYXZh) | `81.13% <100.00%> (ø)` | |
| [...ere/proxy/backend/connector/BackendConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2Nvbm5lY3Rvci9CYWNrZW5kQ29ubmVjdGlvbi5qYXZh) | `71.71% <0.00%> (-11.85%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/shardingsphere/pull/24406?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org