You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "yuzelin (via GitHub)" <gi...@apache.org> on 2023/08/11 09:38:25 UTC

[GitHub] [incubator-paimon] yuzelin commented on a diff in pull request #1708: [flink] support bit type for flink sync job

yuzelin commented on code in PR #1708:
URL: https://github.com/apache/incubator-paimon/pull/1708#discussion_r1291122645


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlTypeUtils.java:
##########
@@ -152,6 +152,11 @@ public static DataType toDataType(
             Boolean tinyInt1ToBool) {
         switch (type.toUpperCase()) {
             case BIT:
+                if (length == null || length == 1) {
+                    return DataTypes.BOOLEAN();

Review Comment:
   Why cast bit(1) to boolean type?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org