You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rampart-dev@ws.apache.org by ka...@apache.org on 2007/08/13 10:39:15 UTC

svn commit: r565269 - in /webservices/rampart/trunk/c: src/omxmlsec/asym_ctx.c src/omxmlsec/openssl/x509.c src/omxmlsec/xml_encryption.c src/util/rampart_sec_header_processor.c test/omxmlsec/test.c

Author: kaushalye
Date: Mon Aug 13 01:39:14 2007
New Revision: 565269

URL: http://svn.apache.org/viewvc?view=rev&rev=565269
Log:
Fixed memory leak in asym_ctx.

Modified:
    webservices/rampart/trunk/c/src/omxmlsec/asym_ctx.c
    webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c
    webservices/rampart/trunk/c/src/omxmlsec/xml_encryption.c
    webservices/rampart/trunk/c/src/util/rampart_sec_header_processor.c
    webservices/rampart/trunk/c/test/omxmlsec/test.c

Modified: webservices/rampart/trunk/c/src/omxmlsec/asym_ctx.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/omxmlsec/asym_ctx.c?view=diff&rev=565269&r1=565268&r2=565269
==============================================================================
--- webservices/rampart/trunk/c/src/omxmlsec/asym_ctx.c (original)
+++ webservices/rampart/trunk/c/src/omxmlsec/asym_ctx.c Mon Aug 13 01:39:14 2007
@@ -255,7 +255,7 @@
 
     if (asym_ctx->private_key)
     {
-        /*openssl_pkey_free(asym_ctx->private_key, env);*/
+        openssl_pkey_free(asym_ctx->private_key, env);
         asym_ctx->private_key = NULL;
     }
     asym_ctx->private_key = private_key;
@@ -286,6 +286,7 @@
     asym_ctx->st_ref_pattern = NULL;
     asym_ctx->operation = -1;
     asym_ctx->certificate = NULL;
+    asym_ctx->private_key = NULL;
 
     return asym_ctx;
 }

Modified: webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c?view=diff&rev=565269&r1=565268&r2=565269
==============================================================================
--- webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c (original)
+++ webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c Mon Aug 13 01:39:14 2007
@@ -370,7 +370,12 @@
     }
     n = BIO_get_mem_data(out, &data);
     result = axutil_strndup( env, data, n);
+    
     BIO_free(out);
+    if(data){
+    /*    AXIS2_FREE(env->allocator, data);
+        data = NULL;*/
+    }
     out = NULL;
 
     return result;

Modified: webservices/rampart/trunk/c/src/omxmlsec/xml_encryption.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/omxmlsec/xml_encryption.c?view=diff&rev=565269&r1=565268&r2=565269
==============================================================================
--- webservices/rampart/trunk/c/src/omxmlsec/xml_encryption.c (original)
+++ webservices/rampart/trunk/c/src/omxmlsec/xml_encryption.c Mon Aug 13 01:39:14 2007
@@ -334,7 +334,7 @@
     parent_of_enc_node = axiom_node_get_parent(enc_type_node, env);
     axiom_node_add_child(parent_of_enc_node, env, deserialized_node);
     axiom_node_detach(enc_type_node, env);
-
+    /*Free result buf*/
     oxs_buffer_free(result_buf, env);
     result_buf = NULL;
 

Modified: webservices/rampart/trunk/c/src/util/rampart_sec_header_processor.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/util/rampart_sec_header_processor.c?view=diff&rev=565269&r1=565268&r2=565269
==============================================================================
--- webservices/rampart/trunk/c/src/util/rampart_sec_header_processor.c (original)
+++ webservices/rampart/trunk/c/src/util/rampart_sec_header_processor.c Mon Aug 13 01:39:14 2007
@@ -429,6 +429,7 @@
         /*Free*/
         oxs_ctx_free(ctx, env);
         ctx = NULL;
+        
 
         AXIS2_LOG_INFO(env->log, "[rampart][shp] Node ID=%s decrypted successfuly", id);
     }

Modified: webservices/rampart/trunk/c/test/omxmlsec/test.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/test/omxmlsec/test.c?view=diff&rev=565269&r1=565268&r2=565269
==============================================================================
--- webservices/rampart/trunk/c/test/omxmlsec/test.c (original)
+++ webservices/rampart/trunk/c/test/omxmlsec/test.c Mon Aug 13 01:39:14 2007
@@ -57,6 +57,8 @@
     if (!doc) printf("\n doc is NULL");
     tmpl = axiom_document_build_all(doc, env);
 
+    axiom_stax_builder_free_self(builder, env);
+    builder = NULL;
     /*    tmpl = axiom_document_get_root_element(doc, env);*/
     if (!tmpl) printf("\n tmpl is NULL");
     return tmpl;