[GitHub] srowen commented on a change in pull request #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter
URL: https://github.com/apache/spark/pull/20793#discussion_r255302941
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala
 ##########
 @@ -739,7 +739,7 @@ class PairRDDFunctionsSuite extends SparkFunSuite with SharedSparkContext {
         val dist = new BinomialDistribution(trials, p)
         val q = dist.cumulativeProbability(actual)
         withClue(s"p = $p: trials = $trials") {
-          assert(q >= 0.001 && q <= 0.999)
+          assert(q >= 0.001 && q < 0.99999)
 
 Review comment:
   This kind of a weird test, as it's almost asserting the CDF is in [0,1] which is true by definition. For symmetry, I'd change the lower bound to be smaller too, to match. Did the upper bound need to be this large? it doesn't indicate a problem, but just checking as that one is a little surprising. I don't think it indicates a bug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org