[impala] branch master updated: Add logging when query unregisters

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new cc1eddb  Add logging when query unregisters
cc1eddb is described below

commit cc1eddbe193daf228dee1d53bb1e4ccd064d90a5
Author: Bikramjeet Vig <bi...@gmail.com>
AuthorDate: Tue Aug 4 17:10:02 2020 -0700

    Add logging when query unregisters
    
    This adds a log line which is printed when a query is successfully
    unregistered by the async unregister thread pool. Added only for
    additional observability.
    
    Change-Id: I09be63afbee6b338a952a9b12321e028be9d7cb0
    Reviewed-on: http://gerrit.cloudera.org:8080/16285
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 be/src/service/impala-server.cc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/be/src/service/impala-server.cc b/be/src/service/impala-server.cc
index f1017ea..d4f05c8 100644
--- a/be/src/service/impala-server.cc
+++ b/be/src/service/impala-server.cc
@@ -1212,7 +1212,12 @@ void ImpalaServer::FinishUnregisterQuery(const QueryHandle& query_handle) {
   Status status = query_handle.query_driver()->Unregister(&query_driver_map_);
   string err_msg = "QueryDriver can only be deleted once: " + status.GetDetail();
   DCHECK(status.ok()) << err_msg;
-  if (UNLIKELY(!status.ok())) LOG(ERROR) << status.GetDetail();
+  if (UNLIKELY(!status.ok())) {
+    LOG(ERROR) << status.GetDetail();
+  } else {
+    VLOG_QUERY << "Query successfully unregistered: query_id="
+               << PrintId(query_handle->query_id());
+  }
 }
 
 void ImpalaServer::UnregisterQueryDiscardResult(