You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Bill Siggelkow <bi...@bellsouth.net> on 2005/02/05 04:23:01 UTC
TLDs not included in maven build of struts-taglib jar
After deploying then struts-mailreader app, built with maven, the
/WEB-INF/struts-logic.tld could not be found. In fact, neither the built
'struts-mailreader' directory or war file contained any of the
struts-taglib tlds; but the struts-taglib.jar file was included in the
WEB-INF/lib. Perhaps we should change the mailreader app so the TLDs can
be pulled from the jar. (Coincidentally, the TLDs are not be included in
the struts-taglib.jar)
-Bill Siggelkow
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: TLDs not included in maven build of struts-taglib jar
Posted by Bill Siggelkow <bi...@bellsouth.net>.
Martin Cooper wrote:
> I'm +1 on using the packaged taglibs mechanism in the samples.
> Unfortunately, we'll still need to provide the TLDs as separate files
> with the taglib subproject, so that people will not be forced to
> change all their own apps.
>
Hmm .. I see how the maven.xml uses XSL to create the TLDs -- (very
clever I might add). How would we want to package the taglib separately
outside of the jar? Or would we just provide instructions on where to
find the TLDs within the jar (they are located in the META-INF/tlds dir).
-Bill Siggelkow
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: TLDs not included in maven build of struts-taglib jar
Posted by Martin Cooper <mf...@gmail.com>.
On Sat, 5 Feb 2005 15:52:33 -0600, Joe Germuska <Jo...@germuska.com> wrote:
> At 4:12 PM -0500 2/5/05, Bill Siggelkow wrote:
> >Okay, the struts-taglib...jar now includes the TLD files. However,
> >there is still an issue with the struts-mailreader application.
> >Currently, it references the TLDs in the web.xml like this:
> >
> > <taglib>
> > <taglib-uri>/tags/struts-bean</taglib-uri>
> > <taglib-location>/WEB-INF/struts-bean.tld</taglib-location>
> > </taglib>
> >
> >However, since the tlds are now in the taglib jar we need to change
> >how this works. One way would be to remove the taglib declarations;
> >but this would require changing the JSPs to use the absolute URI.
> >Optionally, you can specify a jar file in the taglib location;
> >however, I do not know if you can refer to a specific TLD in that
> >jar?
>
> Although I don't think anyone has taken a firm step in this
> direction, I believe we're all in consensus about shifting the
> minimum specs for Struts 1.3 to Servlet 2.3/JSP 1.2. In so far as
> that's true, then all containers should support the TLD autodiscovery
> features, so I'd say we leave it out of the web.xml and use the
> "official" URI from the TLD files.
I'm +1 on using the packaged taglibs mechanism in the samples.
Unfortunately, we'll still need to provide the TLDs as separate files
with the taglib subproject, so that people will not be forced to
change all their own apps.
--
Martin Cooper
> Joe
>
> --
> Joe Germuska
> Joe@Germuska.com
> http://blog.germuska.com
> "Narrow minds are weapons made for mass destruction" -The Ex
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: TLDs not included in maven build of struts-taglib jar
Posted by Joe Germuska <Jo...@Germuska.com>.
At 4:12 PM -0500 2/5/05, Bill Siggelkow wrote:
>Okay, the struts-taglib...jar now includes the TLD files. However,
>there is still an issue with the struts-mailreader application.
>Currently, it references the TLDs in the web.xml like this:
>
> <taglib>
> <taglib-uri>/tags/struts-bean</taglib-uri>
> <taglib-location>/WEB-INF/struts-bean.tld</taglib-location>
> </taglib>
>
>However, since the tlds are now in the taglib jar we need to change
>how this works. One way would be to remove the taglib declarations;
>but this would require changing the JSPs to use the absolute URI.
>Optionally, you can specify a jar file in the taglib location;
>however, I do not know if you can refer to a specific TLD in that
>jar?
Although I don't think anyone has taken a firm step in this
direction, I believe we're all in consensus about shifting the
minimum specs for Struts 1.3 to Servlet 2.3/JSP 1.2. In so far as
that's true, then all containers should support the TLD autodiscovery
features, so I'd say we leave it out of the web.xml and use the
"official" URI from the TLD files.
Joe
--
Joe Germuska
Joe@Germuska.com
http://blog.germuska.com
"Narrow minds are weapons made for mass destruction" -The Ex
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: TLDs not included in maven build of struts-taglib jar
Posted by Bill Siggelkow <bi...@bellsouth.net>.
Okay, the struts-taglib...jar now includes the TLD files. However, there
is still an issue with the struts-mailreader application. Currently, it
references the TLDs in the web.xml like this:
<taglib>
<taglib-uri>/tags/struts-bean</taglib-uri>
<taglib-location>/WEB-INF/struts-bean.tld</taglib-location>
</taglib>
However, since the tlds are now in the taglib jar we need to change how
this works. One way would be to remove the taglib declarations; but this
would require changing the JSPs to use the absolute URI. Optionally, you
can specify a jar file in the taglib location; however, I do not know if
you can refer to a specific TLD in that jar?
Joe Germuska wrote:
> At 10:23 PM -0500 2/4/05, Bill Siggelkow wrote:
>
>> After deploying then struts-mailreader app, built with maven, the
>> /WEB-INF/struts-logic.tld could not be found. In fact, neither the
>> built 'struts-mailreader' directory or war file contained any of the
>> struts-taglib tlds; but the struts-taglib.jar file was included in the
>> WEB-INF/lib. Perhaps we should change the mailreader app so the TLDs
>> can be pulled from the jar. (Coincidentally, the TLDs are not be
>> included in the struts-taglib.jar)
>
>
> I think that the TLD issue is now fixed; the base XML files which are
> transformed into TLDs and the maven.xml file which adds that to the
> "jar" goal hadn't been copied from the core to the taglib project.
>
> I haven't tested the artifact generated, but I did look to see the TLDs
> in there, and since I just moved things around, I'm hoping it's all
> good. I'm also hoping to actually test it this weekend anyway ;-) but I
> thought I'd mention the fix now...
>
> Thanks for catching this!
>
> Joe
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: TLDs not included in maven build of struts-taglib jar
Posted by Joe Germuska <Jo...@Germuska.com>.
At 10:23 PM -0500 2/4/05, Bill Siggelkow wrote:
>After deploying then struts-mailreader app, built with maven, the
>/WEB-INF/struts-logic.tld could not be found. In fact, neither the
>built 'struts-mailreader' directory or war file contained any of the
>struts-taglib tlds; but the struts-taglib.jar file was included in
>the WEB-INF/lib. Perhaps we should change the mailreader app so the
>TLDs can be pulled from the jar. (Coincidentally, the TLDs are not
>be included in the struts-taglib.jar)
I think that the TLD issue is now fixed; the base XML files which are
transformed into TLDs and the maven.xml file which adds that to the
"jar" goal hadn't been copied from the core to the taglib project.
I haven't tested the artifact generated, but I did look to see the
TLDs in there, and since I just moved things around, I'm hoping it's
all good. I'm also hoping to actually test it this weekend anyway
;-) but I thought I'd mention the fix now...
Thanks for catching this!
Joe
--
Joe Germuska
Joe@Germuska.com
http://blog.germuska.com
"Narrow minds are weapons made for mass destruction" -The Ex
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org