You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/25 06:55:37 UTC

[GitHub] [flink] carp84 commented on a change in pull request #16964: [FLINK-23791] Enable RocksDB info log by default

carp84 commented on a change in pull request #16964:
URL: https://github.com/apache/flink/pull/16964#discussion_r695452721



##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java
##########
@@ -61,7 +61,9 @@
         public DBOptions createDBOptions(Collection<AutoCloseable> handlesToClose) {
             return new DBOptions()
                     .setUseFsync(false)
-                    .setInfoLogLevel(InfoLogLevel.HEADER_LEVEL)
+                    .setInfoLogLevel(InfoLogLevel.INFO_LEVEL)
+                    .setMaxLogFileSize(DEFAULT_LOG_FILE_SIZE)
+                    .setKeepLogFileNum(DEFAULT_LOG_FILE_NUM)

Review comment:
       Mind explain why we don't set these default values in `RocksDBConfigurableOptions` directly? Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org