You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/19 07:31:15 UTC

[GitHub] [skywalking-booster-ui] Fine0830 commented on a diff in pull request #93: feat: remove the total filed from query conditions

Fine0830 commented on code in PR #93:
URL: https://github.com/apache/skywalking-booster-ui/pull/93#discussion_r876704594


##########
src/views/dashboard/related/trace/Filter.vue:
##########
@@ -100,8 +110,8 @@ const selectorStore = useSelectorStore();
 const dashboardStore = useDashboardStore();
 const traceStore = useTraceStore();
 const traceId = ref<string>("");
-const minTraceDuration = ref<string>("");
-const maxTraceDuration = ref<string>("");
+const minTraceDuration = ref<number>(NaN);
+const maxTraceDuration = ref<number>(NaN);

Review Comment:
   Yes. I will do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org