You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2017/11/17 03:00:13 UTC

[GitHub] rdhabalia opened a new pull request #908: Deserialize LoadManagerReport with custom-deserializer + fix broker-discovery

rdhabalia opened a new pull request #908: Deserialize LoadManagerReport with custom-deserializer + fix broker-discovery
URL: https://github.com/apache/incubator-pulsar/pull/908
 
 
   ### Motivation
   
   After changing default LoadManager as `ModularLoadManagerImpl`, Proxy and discovery service will fail due to load-report deserialization. 
   
   `ModularLoadManagerImpl` and `SimpleLoadManagerImpl` has different load-report type and proxy/discovery service tries to deserialize load-report in `SimpleLoadManagerImpl-LoadReport` and that will fail in parsing.
   
   So, it requires a custom deserialization based on report-type so, none of the service will face parsing issue for load-report.
   
   ### Modifications
   
   - Add custom deserializer for `LoadManagerReport`.
   - Change load-report parsing to `LoadManagerReport` in proxy/discovery service.
   - fix broken [ZookeeperCacheLoaderTest](https://github.com/apache/incubator-pulsar/blob/master/pulsar-discovery-service/src/test/java/org/apache/pulsar/discovery/service/web/ZookeeperCacheLoaderTest.java)
   
   ### Result
   
   Proxy/Discovery service will be able to handle different types of load-report parsing.
   
   Note: we will need this PR for 1.21 as default load-manager type is `ModularLoadManagerImpl` in 1.21.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services