You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Zhen Zhang <ne...@gmail.com> on 2014/07/22 00:37:50 UTC
Review Request 23777: [HELIX-475] Remove code duplication for Zk tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23777/
-----------------------------------------------------------
Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
Repository: helix-git
Description
-------
[HELIX-475] Remove code duplication for Zk tests
Diffs
-----
helix-admin-webapp/src/test/java/org/apache/helix/webapp/AdminTestBase.java 5b4411b
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestClusterManagementWebapp.java b645dfd
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestDisableResource.java 9800179
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java 8082f04
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java fdcb1e5
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetPartitionState.java 3970b7a
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java 64ed249
helix-agent/src/test/java/org/apache/helix/agent/TestHelixAgent.java ccf64ce
helix-core/src/test/java/org/apache/helix/TestConfigAccessor.java d58389d
helix-core/src/test/java/org/apache/helix/TestHelixConfigAccessor.java 9e8b079
helix-core/src/test/java/org/apache/helix/TestHelper.java 871d717
helix-core/src/test/java/org/apache/helix/TestHierarchicalDataStore.java af953e9
helix-core/src/test/java/org/apache/helix/TestListenerCallback.java 77bb19d
helix-core/src/test/java/org/apache/helix/TestZKCallback.java da438ba
helix-core/src/test/java/org/apache/helix/TestZkBasis.java 8b315d8
helix-core/src/test/java/org/apache/helix/TestZkClientWrapper.java 0decbd8
helix-core/src/test/java/org/apache/helix/TestZkConnectionCount.java f7353f7
helix-core/src/test/java/org/apache/helix/TestZnodeModify.java fdf6e72
helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java 5051db5
helix-core/src/test/java/org/apache/helix/api/TestNewStages.java 4f81729
helix-core/src/test/java/org/apache/helix/api/accessor/TestAccessorRecreate.java ee51834
helix-core/src/test/java/org/apache/helix/api/accessor/TestAtomicAccessors.java 443c3db
helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java dd5f441
helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java e55c682
helix-core/src/test/java/org/apache/helix/integration/TestAddClusterV2.java 32fdcff
helix-core/src/test/java/org/apache/helix/integration/TestAddNodeAfterControllerStart.java c7d83d0
helix-core/src/test/java/org/apache/helix/integration/TestAddStateModelFactoryAfterConnect.java c48b6c9
helix-core/src/test/java/org/apache/helix/integration/TestAutoIsWithEmptyMap.java fe23cb9
helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java 330b906
helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java 59e1b27
helix-core/src/test/java/org/apache/helix/integration/TestBasicSpectator.java bc09339
helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java af079c1
helix-core/src/test/java/org/apache/helix/integration/TestBatchMessageWrapper.java 9bfdfb5
helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 51b0d3c
helix-core/src/test/java/org/apache/helix/integration/TestCMWithFailParticipant.java 453bea6
helix-core/src/test/java/org/apache/helix/integration/TestCarryOverBadCurState.java 97b6ebb
helix-core/src/test/java/org/apache/helix/integration/TestCleanupExternalView.java 071fd13
helix-core/src/test/java/org/apache/helix/integration/TestClusterStartsup.java e844a27
helix-core/src/test/java/org/apache/helix/integration/TestCustomIdealState.java 5467932
helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java 33b95c1
helix-core/src/test/java/org/apache/helix/integration/TestDisable.java cc7fd5f
helix-core/src/test/java/org/apache/helix/integration/TestDisableCustomCodeRunner.java b9097b3
helix-core/src/test/java/org/apache/helix/integration/TestDisableNode.java ca54fb3
helix-core/src/test/java/org/apache/helix/integration/TestDisablePartition.java c81f6e0
helix-core/src/test/java/org/apache/helix/integration/TestDisableResource.java ea8974d
helix-core/src/test/java/org/apache/helix/integration/TestDistributedCMMain.java 8135191
helix-core/src/test/java/org/apache/helix/integration/TestDistributedClusterController.java f3def23
helix-core/src/test/java/org/apache/helix/integration/TestDriver.java 2f2431b
helix-core/src/test/java/org/apache/helix/integration/TestDrop.java 8919634
helix-core/src/test/java/org/apache/helix/integration/TestDropResource.java 047ea75
helix-core/src/test/java/org/apache/helix/integration/TestEnablePartitionDuringDisable.java 0291844
helix-core/src/test/java/org/apache/helix/integration/TestEntropyFreeNodeBounce.java 9b340e3
helix-core/src/test/java/org/apache/helix/integration/TestErrorPartition.java 71c4339
helix-core/src/test/java/org/apache/helix/integration/TestExpandCluster.java 8268679
helix-core/src/test/java/org/apache/helix/integration/TestExternalViewUpdates.java 3e31f17
helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java 021f63a
helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java d0c9bb8
helix-core/src/test/java/org/apache/helix/integration/TestHelixCustomCodeRunner.java 9423326
helix-core/src/test/java/org/apache/helix/integration/TestHelixInstanceTag.java 1f906d0
helix-core/src/test/java/org/apache/helix/integration/TestHelixUsingDifferentParams.java c414c1b
helix-core/src/test/java/org/apache/helix/integration/TestInstanceAutoJoin.java 2761634
helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java f2bf7f6
helix-core/src/test/java/org/apache/helix/integration/TestInvalidResourceRebalance.java 7b56f5d
helix-core/src/test/java/org/apache/helix/integration/TestLocalContainerProvider.java 111c921
helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle.java 0c7c131
helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle2.java a182753
helix-core/src/test/java/org/apache/helix/integration/TestNonOfflineInitState.java aa48c90
helix-core/src/test/java/org/apache/helix/integration/TestNullReplica.java 0f5cc72
helix-core/src/test/java/org/apache/helix/integration/TestParticipantErrorMessage.java 86d09d6
helix-core/src/test/java/org/apache/helix/integration/TestParticipantNameCollision.java aa67ac9
helix-core/src/test/java/org/apache/helix/integration/TestPartitionLevelTransitionConstraint.java b33ab23
helix-core/src/test/java/org/apache/helix/integration/TestPauseSignal.java a1c413b
helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java 561f084
helix-core/src/test/java/org/apache/helix/integration/TestRedefineStateModelDef.java 3057ee0
helix-core/src/test/java/org/apache/helix/integration/TestReelectedPipelineCorrectness.java a1f1868
helix-core/src/test/java/org/apache/helix/integration/TestRenamePartition.java d3a370d
helix-core/src/test/java/org/apache/helix/integration/TestResetInstance.java 7159a17
helix-core/src/test/java/org/apache/helix/integration/TestResetPartitionState.java 5821153
helix-core/src/test/java/org/apache/helix/integration/TestResetResource.java 46a05d8
helix-core/src/test/java/org/apache/helix/integration/TestRestartParticipant.java 64043ed
helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java 80797bb
helix-core/src/test/java/org/apache/helix/integration/TestSchemataSM.java a927520
helix-core/src/test/java/org/apache/helix/integration/TestSessionExpiryInTransition.java 4abb519
helix-core/src/test/java/org/apache/helix/integration/TestSharedConnection.java 0aef00e
helix-core/src/test/java/org/apache/helix/integration/TestStandAloneCMMain.java 7889700
helix-core/src/test/java/org/apache/helix/integration/TestStandAloneCMSessionExpiry.java dad998d
helix-core/src/test/java/org/apache/helix/integration/TestStartMultipleControllersWithSameName.java d191c18
helix-core/src/test/java/org/apache/helix/integration/TestStateTransitionTimeout.java 559d9f4
helix-core/src/test/java/org/apache/helix/integration/TestStatusUpdate.java 4b92670
helix-core/src/test/java/org/apache/helix/integration/TestSwapInstance.java 6cce716
helix-core/src/test/java/org/apache/helix/integration/TestUserDefRebalancerCompatibility.java e7cef4f
helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java 08af37b
helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java 5ce6664
helix-core/src/test/java/org/apache/helix/integration/TestZkSessionExpiry.java c911283
helix-core/src/test/java/org/apache/helix/integration/ZkIntegrationTestBase.java 25f049e
helix-core/src/test/java/org/apache/helix/integration/ZkStandAloneCMTestBase.java 5d169d5
helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java 69448dc
helix-core/src/test/java/org/apache/helix/integration/manager/TestControllerManager.java 0234300
helix-core/src/test/java/org/apache/helix/integration/manager/TestDistributedControllerManager.java f797d1b
helix-core/src/test/java/org/apache/helix/integration/manager/TestParticipantManager.java 82f583f
helix-core/src/test/java/org/apache/helix/integration/manager/TestStateModelLeak.java 2aff5b6
helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java 9b3c32f
helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java 1196f41
helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java 0a59ee1
helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java e555468
helix-core/src/test/java/org/apache/helix/lock/zk/TestZKHelixLock.java f39ca11
helix-core/src/test/java/org/apache/helix/manager/zk/TestHandleNewSession.java 352cdd5
helix-core/src/test/java/org/apache/helix/manager/zk/TestLiveInstanceBounce.java c2982b2
helix-core/src/test/java/org/apache/helix/manager/zk/TestWtCacheAsyncOpMultiThread.java c6875be
helix-core/src/test/java/org/apache/helix/manager/zk/TestWtCacheAsyncOpSingleThread.java ac7a0db
helix-core/src/test/java/org/apache/helix/manager/zk/TestWtCacheSyncOpSingleThread.java 979a179
helix-core/src/test/java/org/apache/helix/manager/zk/TestZKLiveInstanceData.java 29207ca
helix-core/src/test/java/org/apache/helix/manager/zk/TestZKUtil.java f7dcb85
helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordSizeLimit.java c47ef6f
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java 66c069f
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkCacheAsyncOpSingleThread.java ed84719
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkCacheSyncOpSingleThread.java 985a82f
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkClusterManager.java bcab38e
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java 79c74f5
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixAdmin.java d3925be
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixAutoController.java 856707b
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixController.java beac6aa
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixParticipant.java e566ef2
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkManagerFlappingDetection.java 78d1668
helix-core/src/test/java/org/apache/helix/messaging/handling/TestConfigThreadpoolSize.java 0f8c841
helix-core/src/test/java/org/apache/helix/messaging/handling/TestResourceThreadpoolSize.java a5777ab
helix-core/src/test/java/org/apache/helix/model/TestConstraint.java 691492e
helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java d8e1cab
helix-core/src/test/java/org/apache/helix/monitoring/TestZKPathDataDumpTask.java d073dd2
helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestDropResourceMetricsReset.java 17d45de
helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResetClusterMetrics.java 74f84e8
helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java 2e175d5
helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModel.java 9036cf3
helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModelFactory.java 43ffb9a
helix-core/src/test/java/org/apache/helix/store/zk/TestAutoFallbackPropertyStore.java 8bb1686
helix-core/src/test/java/org/apache/helix/store/zk/TestZkHelixPropertyStore.java b07cf8f
helix-core/src/test/java/org/apache/helix/store/zk/TestZkManagerWithAutoFallbackStore.java f2f8b35
helix-core/src/test/java/org/apache/helix/testutil/TestUtil.java PRE-CREATION
helix-core/src/test/java/org/apache/helix/testutil/ZkTestBase.java PRE-CREATION
helix-core/src/test/java/org/apache/helix/testutil/ZkTestUtil.java PRE-CREATION
helix-core/src/test/java/org/apache/helix/tools/TestClusterSetup.java a528a20
helix-core/src/test/java/org/apache/helix/tools/TestClusterStateVerifier.java abd1dd8
helix-core/src/test/java/org/apache/helix/tools/TestHelixAdminCli.java 1d9198b
helix-core/src/test/java/org/apache/helix/tools/TestZkCopy.java ee3d2bd
Diff: https://reviews.apache.org/r/23777/diff/
Testing
-------
Thanks,
Zhen Zhang