You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "XiaoYou201 (via GitHub)" <gi...@apache.org> on 2024/04/08 08:53:11 UTC
[PR] [INLONG-9402][Sort] Solve errors in UT test logs for sort-end-to-end-tests, but UT results show as successful [inlong]
XiaoYou201 opened a new pull request, #9940:
URL: https://github.com/apache/inlong/pull/9940
### Prepare a Pull Request
- [INLONG-9402][Sort] Solve errors in UT test logs for sort-end-to-end-tests, but UT results show as successful
- Fixes #9402
### Motivation
As issue #9402 description, there were two case encountered error but the final result show as successful.
### Modifications
- Case1
Question: Warning: Illegal reflective access by org.apache.flink.api.java.ClosureCleaner (file:/opt/flink/lib/flink-dist-1.15.4.jar) to field java.lang.String.value.
Reason: This error message indicates an illegal reflective access operation occurring while using Apache Flink, which is an open-source framework for processing streaming and batch data. Specifically, the error occurs because org.apache.flink.api.java.ClosureCleaner attempts to access the value field of the java.lang.String class illegally. This is more common with higher versions of Java, starting from Java 9 onwards, as the JDK has imposed stricter access controls on internal APIs to enhance security and modularity.
Solve: Change the flink docker java version from 11(flink:1.15.4-scala_2.12) to 8(flink:1.15.4-scala_2.12-java8).
- Case2
Question: Can't connect the mysql server and through errors in logs, the results show as successful.
Reason:The issue which run end-to-end-tests use ci_ut.yaml, so it will lead to some network problem. Because ahead module test maybe change the newort adapter.
Solve: Now, the project add ci_ut_flink13.yaml and ci_ut_flink15.yaml. The 1.13 and 1.15 end-to-end test can be tested without other module influence.The detail of yaml file as PR #9924 and #9869 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9402][Sort] Solve errors in UT test logs for sort-end-to-end-tests, but UT results show as successful [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #9940:
URL: https://github.com/apache/inlong/pull/9940#discussion_r1558899063
##########
inlong-sort/sort-end-to-end-tests/sort-end-to-end-tests-v1.15/src/test/java/org/apache/inlong/sort/tests/utils/FlinkContainerTestEnv.java:
##########
@@ -165,8 +134,8 @@ public void submitSQLJob(String sqlFile, Path... jars)
ExecResult execResult =
jobManager.execInContainer("bash", "-c", String.join(" ", commands));
LOG.info(execResult.getStdout());
- LOG.error(execResult.getStderr());
Review Comment:
the error might be useful for debugging, why change the place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9402][Sort] Solve errors in UT test logs for sort-end-to-end-tests, but UT results show as successful [inlong]
Posted by "XiaoYou201 (via GitHub)" <gi...@apache.org>.
XiaoYou201 commented on PR #9940:
URL: https://github.com/apache/inlong/pull/9940#issuecomment-2046688147
In end-to-end-test-v1.15, because the postgreSQL module use debezuim.postgreSQL v1.6 package which base on java 11 or high. And this package use reflect, So, the postgreSQL module still has
Warning: Illegal reflective access by org.apache.flink.api.java.ClosureCleaner (file:/opt/flink/lib/flink-dist-1.15.4.jar) to field java.lang.String.value.
As https://debezium.io/releases/1.6/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9402][Sort] Solve errors in UT test logs for sort-end-to-end-tests, but UT results show as successful [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #9940:
URL: https://github.com/apache/inlong/pull/9940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9402][Sort] Solve errors in UT test logs for sort-end-to-end-tests, but UT results show as successful [inlong]
Posted by "XiaoYou201 (via GitHub)" <gi...@apache.org>.
XiaoYou201 commented on code in PR #9940:
URL: https://github.com/apache/inlong/pull/9940#discussion_r1558956648
##########
inlong-sort/sort-end-to-end-tests/sort-end-to-end-tests-v1.15/src/test/java/org/apache/inlong/sort/tests/utils/FlinkContainerTestEnv.java:
##########
@@ -165,8 +134,8 @@ public void submitSQLJob(String sqlFile, Path... jars)
ExecResult execResult =
jobManager.execInContainer("bash", "-c", String.join(" ", commands));
LOG.info(execResult.getStdout());
- LOG.error(execResult.getStderr());
Review Comment:
I put the code for printing logs into the following if statement.Beacause if There were error in running, the execResult.getExitCode() will not equal 0,So, It will still print logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org