You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Terry Wang <zj...@gmail.com> on 2019/10/31 03:17:19 UTC

Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

Hi, everyone~

Sorry so late to reply this this thread again. 
I am working on FLIP-84 recently  to make sql api support return value which this flip depends on.
I think it’s time to pick up this discussion again and there are some new updates in this flip design:
https://docs.google.com/document/d/1mhZmx1h2ecfL0x8OzYD1n-nVRn4yE7pwk4jGed4k7kc/edit?usp=sharing <https://docs.google.com/document/d/1mhZmx1h2ecfL0x8OzYD1n-nVRn4yE7pwk4jGed4k7kc/edit?usp=sharing>

1. Remove function ddl section. For Peter Huang are working on FLIP-79 to convege function ddl support in a more overall way
2. Remove the proposed TableEnvironment SQL API Changes which is covered in FLIP-84
3. Update the design doc accoding to review comments.

Looking forward to receiving more comments ~

Best,
Terry Wang



> 2019年9月26日 00:44,Xuefu Z <us...@gmail.com> 写道:
> 
> Actually catalogs are more of system settings than of user objects that a
> user might create or drop constantly. Thus, it's probably sufficient to set
> up catalog information in the config file, at least for now.
> 
> Thanks,
> Xuefu
> 
> On Tue, Sep 24, 2019 at 7:10 PM Terry Wang <zjuwangg@gmail.com <ma...@gmail.com>> wrote:
> 
>> Thanks Bowen for your insightful comments, I’ll think twice and do
>> corresponding improvement.
>> After finished, I’ll update in this mailing thread again.
>> Best,
>> Terry Wang
>> 
>> 
>> 
>>> 在 2019年9月25日,上午8:28,Bowen Li <bo...@gmail.com> 写道:
>>> 
>>> BTW, will there be a "CREATE/DROP CATALOG" DDL?
>>> 
>>> Though it's not SQL standard, I can see it'll be useful and handy for
>> our end users in many cases.
>>> 
>>> On Mon, Sep 23, 2019 at 12:28 PM Bowen Li <bowenli86@gmail.com <ma...@gmail.com> <mailto:
>> bowenli86@gmail.com <ma...@gmail.com>>> wrote:
>>> Hi Terry,
>>> 
>>> Thanks for driving the effort! I left some comments in the doc.
>>> 
>>> AFAIU, the biggest motivation is to support DDLs in sql parser so that
>> both Table API and SQL CLI can share the stack, despite that SQL CLI has
>> already supported some commands itself. However, I don't see details on how
>> SQL CLI would migrate and depend on sql parser, and how Table API and SQL
>> CLI would actually share SQL parser. I'm not sure yet how much work that
>> will take, just want to double check that you didn't include them because
>> they are very trivial according to your estimate?
>>> 
>>> 
>>> On Mon, Sep 16, 2019 at 1:46 AM Terry Wang <zjuwangg@gmail.com <ma...@gmail.com> <mailto:
>> zjuwangg@gmail.com <ma...@gmail.com>>> wrote:
>>> Hi everyone,
>>> 
>>> In flink 1.9, we have introduced some awesome features such as complete
>> catalog support[1] and sql ddl support[2]. These features have been a
>> critical integration for Flink to be able to manage data and metadata like
>> a classic RDBMS and make developers more easy to construct their
>> real-time/off-line warehouse or sth similar base on flink.
>>> 
>>> But there is still a lack of support on how Flink SQL DDL to manage
>> metadata and data like classic RDBMS such as `alter table rename` and so on.
>>> 
>>> So I’d like to kick off a discussion on enhancing Flink Sql Ddls:
>>> 
>> https://docs.google.com/document/d/1mhZmx1h2ecfL0x8OzYD1n-nVRn4yE7pwk4jGed4k7kc/edit?usp=sharing <https://docs.google.com/document/d/1mhZmx1h2ecfL0x8OzYD1n-nVRn4yE7pwk4jGed4k7kc/edit?usp=sharing>
>> <
>> https://docs.google.com/document/d/1mhZmx1h2ecfL0x8OzYD1n-nVRn4yE7pwk4jGed4k7kc/edit?usp=sharing <https://docs.google.com/document/d/1mhZmx1h2ecfL0x8OzYD1n-nVRn4yE7pwk4jGed4k7kc/edit?usp=sharing>>
>> <
>> https://docs.google.com/document/d/1mhZmx1h2ecfL0x8OzYD1n-nVRn4yE7pwk4jGed4k7kc/edit?usp=sharing <https://docs.google.com/document/d/1mhZmx1h2ecfL0x8OzYD1n-nVRn4yE7pwk4jGed4k7kc/edit?usp=sharing>
>> <
>> https://docs.google.com/document/d/1mhZmx1h2ecfL0x8OzYD1n-nVRn4yE7pwk4jGed4k7kc/edit?usp=sharing <https://docs.google.com/document/d/1mhZmx1h2ecfL0x8OzYD1n-nVRn4yE7pwk4jGed4k7kc/edit?usp=sharing>
>>>> 
>>> 
>>> In short, it:
>>>        - Add Catalog DDL enhancement support:  show catalogs / describe
>> catalog / use catalog
>>>        - Add Database DDL enhancement support:  show databses / create
>> database / drop database/ alter database
>>>        - Add Table DDL enhancement support:    show tables/ describe
>> table / alter table
>>>        - Add Function DDL enhancement support: show functions/ create
>> function /drop function
>>> 
>>> Looking forward to your opinions.
>>> 
>>> Best,
>>> Terry Wang
>>> 
>>> 
>>> 
>>> [1]:https://issues.apache.org/jira/browse/FLINK-11275 <https://issues.apache.org/jira/browse/FLINK-11275> <
>> https://issues.apache.org/jira/browse/FLINK-11275 <https://issues.apache.org/jira/browse/FLINK-11275>> <
>> https://issues.apache.org/jira/browse/FLINK-11275 <https://issues.apache.org/jira/browse/FLINK-11275> <
>> https://issues.apache.org/jira/browse/FLINK-11275 <https://issues.apache.org/jira/browse/FLINK-11275>>>
>>> [2]:https://issues.apache.org/jira/browse/FLINK-1 <https://issues.apache.org/jira/browse/FLINK-1> <
>> https://issues.apache.org/jira/browse/FLINK-1 <https://issues.apache.org/jira/browse/FLINK-1>> <
>> https://issues.apache.org/jira/browse/FLINK-11275 <https://issues.apache.org/jira/browse/FLINK-11275> <
>> https://issues.apache.org/jira/browse/FLINK-11275 <https://issues.apache.org/jira/browse/FLINK-11275>>>0232
>>> <https://issues.apache.org/jira/browse/FLINK-11275 <https://issues.apache.org/jira/browse/FLINK-11275> <
>> https://issues.apache.org/jira/browse/FLINK-11275 <https://issues.apache.org/jira/browse/FLINK-11275>>>
>> 
>> 
> 
> -- 
> Xuefu Zhang
> 
> "In Honey We Trust!"