You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "belingueres (via GitHub)" <gi...@apache.org> on 2026/03/21 19:30:45 UTC
[PR] [MPIR-477] Replace ArtifactMetadataSource by Resolver API [maven-project-info-reports-plugin]
belingueres opened a new pull request, #628:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/628
Solves Github issue #326.
Also:
- Fixed some javadoc issues.
- Removed variables/parameters that were not used anywhere/anymore.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in other changes.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPIR-477] Replace ArtifactMetadataSource by Resolver API [maven-project-info-reports-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #628:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/628#issuecomment-5551537074
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPIR-477] Replace ArtifactMetadataSource by Resolver API [maven-project-info-reports-plugin]
Posted by "belingueres (via GitHub)" <gi...@apache.org>.
belingueres commented on PR #628:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/628#issuecomment-5234985707
@slachiewicz Thanks for the review. I believe I addressed all comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPIR-477] Replace ArtifactMetadataSource by Resolver API [maven-project-info-reports-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #628:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/628#issuecomment-5227045293
Flagging an overlap I created: I opened #650 today to remove `maven-compat` from this plugin without first checking for an existing PR, and it duplicates most of this one — 19 of its 20 changed files are the same files here, and it reaches the same solution independently (resolver `VersionRangeRequest`, with the artifact built from `ArtifactHandlerManager` + `DefaultArtifact`).
This PR came first and should land first; I have said so on #650 and will rebase mine down to the leftover `pom.xml` change once this merges, or close it.
Two findings from verifying the same code path, in case they are useful here:
**Behaviour change worth a release note.** `retrieveAvailableVersions` returned snapshots and Maven's `VersionRange.containsVersion` accepts them, so a SNAPSHOT could win a range like `[1.0,)`. Resolver's `DefaultVersionRangeResolver` requests `RELEASE`-nature metadata unless a range bound is itself a snapshot, so snapshots are now excluded. It aligns the report with Maven's own resolution, but users may see a different version rendered.
**Coverage gap for that change.** `DependencyManagementReportTest` pins a plain version, so the range branch never runs in unit tests. The `full-pom` IT does exercise it and its log confirms the resolution, but no fixture has a range whose matches include a snapshot — so that specific difference is reasoned, not observed.
Independent arrival at the same design is reassuring for the approach here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPIR-477] Replace ArtifactMetadataSource by Resolver API [maven-project-info-reports-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #628:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org