You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by kriserickson <gi...@git.apache.org> on 2014/03/09 19:37:14 UTC
[GitHub] cordova-plugin-inappbrowser pull request: Add a hardwareback optio...
GitHub user kriserickson opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/29
Add a hardwareback option to allow for the hardware back button to go back
Add's another android option 'hardwareback' that when set allows the android hardware back button to work as a back button in the InAppBrowser until there is no way to go back, at which point it closes the InAppBrowser.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kriserickson/cordova-plugin-inappbrowser master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit 392a73c2cdcfc643622832cb6d2ac218f4da082a
Author: Kris Erickson <ks...@yahoo.ca>
Date: 2014-03-09T18:33:24Z
Add a hardwareback option to allow for the hardware back button to go back.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Add a hardwareback optio...
Posted by ne0c0de <gi...@git.apache.org>.
Github user ne0c0de commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/29#issuecomment-45197165
Very good suggestion that it's already in my mind. I hope they will add it soon..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Add a hardwareback optio...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/29#issuecomment-77116947
Thanks Kris, finally got this in!
I changed the default to 'yes' and updated the docs.
Please consider signing the ICLA. Details here: http://cordova.apache.org/#contribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Add a hardwareback optio...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/29#issuecomment-45202676
I think the default should be true, to match wp8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Add a hardwareback optio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Add a hardwareback optio...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/29#issuecomment-43031979
I believe this should be the default behavior.
Here is a similar issue for wp8 : https://issues.apache.org/jira/browse/CB-3324
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Add a hardwareback optio...
Posted by lanash01 <gi...@git.apache.org>.
Github user lanash01 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/29#issuecomment-77085647
Very much needed change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Add a hardwareback optio...
Posted by designgrill <gi...@git.apache.org>.
Github user designgrill commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/29#issuecomment-68236992
Is something blocking this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org