You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/09/25 06:11:35 UTC
[PR] style(desktop): reveal turn metadata on hover and separate turns [maka]
Astro-Han opened a new pull request, #5715:
URL: https://github.com/apache/maka/pull/5715
## Summary
Each turn in the transcript had two rows of metadata that were always on screen. Under the prompt: its time and a copy button. Under the answer: branch, copy and the finish time. Neither row is a frequent next step, yet both were as present as the content. Turns were also only 16px apart while rows inside a turn were 12px apart, so the line between two turns was weaker than the lines inside one.
- The user message's meta row and the answer footer stay hidden until the message is hovered or has focus. They are hidden with opacity only: they keep their space, so nothing moves on hover, and their buttons stay in the tab order, which is what lets `:focus-within` reveal them. A delivery status or a Work status in the user row stays visible, because that is news rather than reference.
- Turns are separated by `--space-10` (40px) instead of `--spacing-4`, so each turn reads as one group. Measured in `NativeConversation`: prompt to answer is still 44px, and one turn's answer to the next prompt goes from 50px to 74px.
This is independent of #5714 and of the icon-scale PR; any of the three can land first.
## Verification
- `npm run format` and `npm run lint` pass.
- `npm --workspace @maka/ui run typecheck` and `npm --workspace @maka/desktop run typecheck` (which includes stories) pass.
- `@maka/ui` tests pass (659).
- `node scripts/storybook-visual-smoke.mjs` passes except `product-model-picker--executor-catalog-ready`. That story is flaky on `main` too, and this PR does not touch the model picker.
- `NativeConversation` asserts that both metadata rows are transparent at rest, and that focusing a footer button reveals the footer.
- `FullConversationAndWorkIdentity` asserts that a user row carrying a Work status stays opaque. Its before/after screenshots are pixel-identical.
Before is `main`'s storybook-static, after is this branch's. Same stories, 1440px viewport.
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Claude Code, directed and reviewed by the author, wrote the CSS and story changes, ran the checks and produced the before/after screenshots.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] style(desktop): reveal turn metadata on hover and separate turns [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #5715:
URL: https://github.com/apache/maka/pull/5715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org