You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "amrishlal (via GitHub)" <gi...@apache.org> on 2023/08/03 20:23:11 UTC
[GitHub] [hudi] amrishlal opened a new pull request, #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
amrishlal opened a new pull request, #9359:
URL: https://github.com/apache/hudi/pull/9359
Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
### Change Logs
Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
### Impact
Rename config to better describe what it is for.
### Risk level (write none, low medium or high below)
None
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [X] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [X] Change Logs and Impact were stated clearly
- [X] Adequate tests were added if applicable
- [X] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1664628275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8163de397fcdbf1b3194bcf696435be9d28c171 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1665900327
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
}, {
"hash" : "646198385e45dd36a991d0b55be59c06de130a15",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062",
"triggerID" : "646198385e45dd36a991d0b55be59c06de130a15",
"triggerType" : "PUSH"
}, {
"hash" : "7a3c650ae6e023332324559eb491fbaff6964932",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a3c650ae6e023332324559eb491fbaff6964932",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 646198385e45dd36a991d0b55be59c06de130a15 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062)
* 7a3c650ae6e023332324559eb491fbaff6964932 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1664852578
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048)
* 7308946c4344ca04736b2c83b505d3a159146541 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1665035137
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7308946c4344ca04736b2c83b505d3a159146541 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] amrishlal commented on a diff in pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "amrishlal (via GitHub)" <gi...@apache.org>.
amrishlal commented on code in PR #9359:
URL: https://github.com/apache/hudi/pull/9359#discussion_r1283857986
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -194,9 +194,9 @@ trait ProvidesHoodieConfig extends Logging {
val insertMode = InsertMode.of(combinedOpts.getOrElse(DataSourceWriteOptions.SQL_INSERT_MODE.key,
DataSourceWriteOptions.SQL_INSERT_MODE.defaultValue()))
val insertModeSet = combinedOpts.contains(SQL_INSERT_MODE.key)
- val sqlWriteOperationOpt = combinedOpts.get(SQL_WRITE_OPERATION.key())
+ val sqlWriteOperationOpt = combinedOpts.get(SPARK_SQL_INSERT_INTO_OPERATION.key())
val sqlWriteOperationSet = sqlWriteOperationOpt.nonEmpty
- val sqlWriteOperation = sqlWriteOperationOpt.getOrElse(SQL_WRITE_OPERATION.defaultValue())
+ val sqlWriteOperation = sqlWriteOperationOpt.getOrElse(SPARK_SQL_INSERT_INTO_OPERATION.defaultValue())
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1665091316
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
}, {
"hash" : "646198385e45dd36a991d0b55be59c06de130a15",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "646198385e45dd36a991d0b55be59c06de130a15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7308946c4344ca04736b2c83b505d3a159146541 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050)
* 646198385e45dd36a991d0b55be59c06de130a15 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #9359:
URL: https://github.com/apache/hudi/pull/9359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1665098988
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
}, {
"hash" : "646198385e45dd36a991d0b55be59c06de130a15",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062",
"triggerID" : "646198385e45dd36a991d0b55be59c06de130a15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7308946c4344ca04736b2c83b505d3a159146541 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050)
* 646198385e45dd36a991d0b55be59c06de130a15 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1665980472
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
}, {
"hash" : "646198385e45dd36a991d0b55be59c06de130a15",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062",
"triggerID" : "646198385e45dd36a991d0b55be59c06de130a15",
"triggerType" : "PUSH"
}, {
"hash" : "7a3c650ae6e023332324559eb491fbaff6964932",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19079",
"triggerID" : "7a3c650ae6e023332324559eb491fbaff6964932",
"triggerType" : "PUSH"
}, {
"hash" : "c695d8fc59ebdbf339f40ea31db465858ea83f98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c695d8fc59ebdbf339f40ea31db465858ea83f98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 646198385e45dd36a991d0b55be59c06de130a15 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062)
* 7a3c650ae6e023332324559eb491fbaff6964932 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19079)
* c695d8fc59ebdbf339f40ea31db465858ea83f98 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1666029141
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
}, {
"hash" : "646198385e45dd36a991d0b55be59c06de130a15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062",
"triggerID" : "646198385e45dd36a991d0b55be59c06de130a15",
"triggerType" : "PUSH"
}, {
"hash" : "7a3c650ae6e023332324559eb491fbaff6964932",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19079",
"triggerID" : "7a3c650ae6e023332324559eb491fbaff6964932",
"triggerType" : "PUSH"
}, {
"hash" : "c695d8fc59ebdbf339f40ea31db465858ea83f98",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19085",
"triggerID" : "c695d8fc59ebdbf339f40ea31db465858ea83f98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a3c650ae6e023332324559eb491fbaff6964932 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19079)
* c695d8fc59ebdbf339f40ea31db465858ea83f98 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19085)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1664617802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8163de397fcdbf1b3194bcf696435be9d28c171 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1664798077
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8163de397fcdbf1b3194bcf696435be9d28c171 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045)
* 3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1665229029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
}, {
"hash" : "646198385e45dd36a991d0b55be59c06de130a15",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062",
"triggerID" : "646198385e45dd36a991d0b55be59c06de130a15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 646198385e45dd36a991d0b55be59c06de130a15 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1665912148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
}, {
"hash" : "646198385e45dd36a991d0b55be59c06de130a15",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062",
"triggerID" : "646198385e45dd36a991d0b55be59c06de130a15",
"triggerType" : "PUSH"
}, {
"hash" : "7a3c650ae6e023332324559eb491fbaff6964932",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19079",
"triggerID" : "7a3c650ae6e023332324559eb491fbaff6964932",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 646198385e45dd36a991d0b55be59c06de130a15 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062)
* 7a3c650ae6e023332324559eb491fbaff6964932 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19079)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1664847379
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8163de397fcdbf1b3194bcf696435be9d28c171 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045)
* 3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048)
* 7308946c4344ca04736b2c83b505d3a159146541 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1666337335
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
}, {
"hash" : "7308946c4344ca04736b2c83b505d3a159146541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19050",
"triggerID" : "7308946c4344ca04736b2c83b505d3a159146541",
"triggerType" : "PUSH"
}, {
"hash" : "646198385e45dd36a991d0b55be59c06de130a15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19062",
"triggerID" : "646198385e45dd36a991d0b55be59c06de130a15",
"triggerType" : "PUSH"
}, {
"hash" : "7a3c650ae6e023332324559eb491fbaff6964932",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19079",
"triggerID" : "7a3c650ae6e023332324559eb491fbaff6964932",
"triggerType" : "PUSH"
}, {
"hash" : "c695d8fc59ebdbf339f40ea31db465858ea83f98",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19085",
"triggerID" : "c695d8fc59ebdbf339f40ea31db465858ea83f98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c695d8fc59ebdbf339f40ea31db465858ea83f98 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19085)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #9359:
URL: https://github.com/apache/hudi/pull/9359#discussion_r1283833724
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -194,9 +194,9 @@ trait ProvidesHoodieConfig extends Logging {
val insertMode = InsertMode.of(combinedOpts.getOrElse(DataSourceWriteOptions.SQL_INSERT_MODE.key,
DataSourceWriteOptions.SQL_INSERT_MODE.defaultValue()))
val insertModeSet = combinedOpts.contains(SQL_INSERT_MODE.key)
- val sqlWriteOperationOpt = combinedOpts.get(SQL_WRITE_OPERATION.key())
+ val sqlWriteOperationOpt = combinedOpts.get(SPARK_SQL_INSERT_INTO_OPERATION.key())
val sqlWriteOperationSet = sqlWriteOperationOpt.nonEmpty
- val sqlWriteOperation = sqlWriteOperationOpt.getOrElse(SQL_WRITE_OPERATION.defaultValue())
+ val sqlWriteOperation = sqlWriteOperationOpt.getOrElse(SPARK_SQL_INSERT_INTO_OPERATION.defaultValue())
Review Comment:
minor.
can we rename the method deduceSqlWriteOperation to deduceSparkSqlInsetIntoWriteOperation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9359: [HUDI-6639] Rename hoodie.sql.write.operation to hoodie.spark.sql.insert.into.operation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9359:
URL: https://github.com/apache/hudi/pull/9359#issuecomment-1664806676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045",
"triggerID" : "e8163de397fcdbf1b3194bcf696435be9d28c171",
"triggerType" : "PUSH"
}, {
"hash" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048",
"triggerID" : "3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8163de397fcdbf1b3194bcf696435be9d28c171 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19045)
* 3dd8c31863ff6b5dc918a23ff0d13041cbc60bd3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19048)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org