You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/17 23:52:41 UTC
[GitHub] [superset] dd-willgan opened a new pull request #17811: other: Add Helm chart option for configOverrides through file
dd-willgan opened a new pull request #17811:
URL: https://github.com/apache/superset/pull/17811
### SUMMARY
To extend `superset_config.py`, the Superset Helm chart currently allows users to [add code](https://github.com/apache/superset/blob/master/helm/superset/values.yaml#L113) under `configOverrides` in `values.yaml`. However, it would be better if this code was in a separate `.py` file in the chart directory. This PR enables that through a similar setup.
### TESTING INSTRUCTIONS
Create a `test.py` in `helm/superset` and add `test: test.py` as an entry under `configOverridesFiles`. Install with
```
helm install superset helm/superset
```
After installing,
```
k get secret/superset-config -o json | jq '.data."superset_config.py"' -r | base64 -D
```
should show the code in test.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai merged pull request #17811: other: Add Helm chart option for configOverrides through file
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #17811:
URL: https://github.com/apache/superset/pull/17811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 edited a comment on pull request #17811: other: Add Helm chart option for configOverrides through file
Posted by GitBox <gi...@apache.org>.
amitmiran137 edited a comment on pull request #17811:
URL: https://github.com/apache/superset/pull/17811#issuecomment-997142340
You need to bump your chart version manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ofekisr commented on pull request #17811: other: Add Helm chart option for configOverrides through file
Posted by GitBox <gi...@apache.org>.
ofekisr commented on pull request #17811:
URL: https://github.com/apache/superset/pull/17811#issuecomment-997347826
btw using superset_config.py as a Secret object is bad practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on pull request #17811: other: Add Helm chart option for configOverrides through file
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #17811:
URL: https://github.com/apache/superset/pull/17811#issuecomment-997142340
You need to bump your version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org