You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/05/04 13:32:34 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #23935: fix: methods incorrect type and update deprecated targets
dpgaspar opened a new pull request, #23935:
URL: https://github.com/apache/superset/pull/23935
### SUMMARY
While gradually adding type annotations to FAB, having `@expose` methods as a List popped up as an error.
Also updated missing target to deprecation warnings
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #23935: fix: methods incorrect type and update deprecated targets
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #23935:
URL: https://github.com/apache/superset/pull/23935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23935: fix: methods incorrect type and update deprecated targets
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23935:
URL: https://github.com/apache/superset/pull/23935#issuecomment-1534846941
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23935](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eae17c9) into [master](https://app.codecov.io/gh/apache/superset/commit/f1fa1a733d247ec4793c17b69c4eb40c631c5080?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1fa1a7) will **decrease** coverage by `11.27%`.
> The diff coverage is `99.47%`.
> :exclamation: Current head eae17c9 differs from pull request most recent head 5c9aa75. Consider uploading reports for the commit 5c9aa75 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23935 +/- ##
===========================================
- Coverage 68.12% 56.85% -11.27%
===========================================
Files 1941 1941
Lines 75073 75074 +1
Branches 8155 8155
===========================================
- Hits 51141 42684 -8457
- Misses 21849 30307 +8458
Partials 2083 2083
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.01% <99.47%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.92% <99.47%> (+<0.01%)` | :arrow_up: |
| python | `59.40% <99.47%> (-23.29%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.81% <99.47%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/datasource/api.py](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNvdXJjZS9hcGkucHk=) | `55.26% <ø> (-44.74%)` | :arrow_down: |
| [superset/key\_value/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `45.83% <0.00%> (-47.92%)` | :arrow_down: |
| [superset/advanced\_data\_type/api.py](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYWR2YW5jZWRfZGF0YV90eXBlL2FwaS5weQ==) | `77.50% <100.00%> (-22.50%)` | :arrow_down: |
| [superset/annotation\_layers/annotations/api.py](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `59.54% <100.00%> (-29.78%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `58.11% <100.00%> (-28.21%)` | :arrow_down: |
| [superset/async\_events/api.py](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FwaS5weQ==) | `72.00% <100.00%> (-28.00%)` | :arrow_down: |
| [superset/available\_domains/api.py](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXZhaWxhYmxlX2RvbWFpbnMvYXBpLnB5) | `92.00% <100.00%> (-8.00%)` | :arrow_down: |
| [superset/cachekeys/api.py](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2FjaGVrZXlzL2FwaS5weQ==) | `51.92% <100.00%> (-44.24%)` | :arrow_down: |
| [superset/charts/api.py](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `50.16% <100.00%> (-35.55%)` | :arrow_down: |
| [superset/charts/data/api.py](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2RhdGEvYXBpLnB5) | `88.95% <100.00%> (ø)` | |
| ... and [35 more](https://app.codecov.io/gh/apache/superset/pull/23935?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [267 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/23935/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org