You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/30 22:23:55 UTC
[GitHub] [airflow] o-nikolas opened a new pull request #19907: Move to watchtower 2.0.1 - Fixes Watchtower crash when logging empty line
o-nikolas opened a new pull request #19907:
URL: https://github.com/apache/airflow/pull/19907
## Overview
This version of watchtower contains patches (submitted by myself and Andrey the maintainer) that fixes #15279 where empty log lines would crash Watchtower.
## Testing
I wrote a dag with the following benchmarks:
- Log a single line from a task
- Log an empty line
- Log 1000 lines
- Log 10,000 lines
- Log 100,000 lines
I detected no noticeable regression in task run time, and as expected the new watchtower version does not crash when logging an empty line.
**Note**: The logic, as Andrey wrote it, ignores empty log lines and emits a warning message (see snippet below). The warning messages could be a nuisance if you're logging empty lines frequently, but I think it's a also a good indicator to the user that their remote logs will look different than they expect due to the empty messages being filtered. Example output from my empty line benchmark task:
```
...
[2021-11-30, 19:22:45 UTC] Running command: ['bash', '-c', "echo ''"]
[2021-11-30, 19:22:45 UTC] Output:
[2021-11-30, 19:22:45 UTC] /usr/local/lib/python3.6/site-packages/watchtower/__init__.py:349 WatchtowerWarning: Received empty message. Empty messages cannot be sent to CloudWatch Logs
[2021-11-30, 19:22:45 UTC] Command exited with return code 0
...
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a change in pull request #19907: Move to watchtower 2.0.1 - Fixes Watchtower crash when logging empty line
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on a change in pull request #19907:
URL: https://github.com/apache/airflow/pull/19907#discussion_r759708573
##########
File path: airflow/providers/amazon/aws/log/cloudwatch_task_handler.py
##########
@@ -81,7 +81,7 @@ def set_context(self, ti):
self.handler = watchtower.CloudWatchLogHandler(
log_group=self.log_group,
stream_name=self._render_filename(ti, ti.try_number),
- boto3_session=self.hook.get_session(self.region_name),
+ boto3_client=self.hook.get_conn(),
Review comment:
Watchtower now expects a Boto3 client instead of a session, this was changed in this commit: https://github.com/o-nikolas/watchtower/commit/a6232505d5aba2f5d2a67641e30bfbaa5874a0fa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a change in pull request #19907: Move to watchtower 2.0.1 - Fixes Watchtower crash when logging empty line
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on a change in pull request #19907:
URL: https://github.com/apache/airflow/pull/19907#discussion_r759708573
##########
File path: airflow/providers/amazon/aws/log/cloudwatch_task_handler.py
##########
@@ -81,7 +81,7 @@ def set_context(self, ti):
self.handler = watchtower.CloudWatchLogHandler(
log_group=self.log_group,
stream_name=self._render_filename(ti, ti.try_number),
- boto3_session=self.hook.get_session(self.region_name),
+ boto3_client=self.hook.get_conn(),
Review comment:
Watchtower now expects a Boto3 client instead of a session, this was changed in this commit: https://github.com/kislyuk/watchtower/commit/a6232505d5aba2f5d2a67641e30bfbaa5874a0fa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19907: Move to watchtower 2.0.1 - Fixes Watchtower crash when logging empty line
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19907:
URL: https://github.com/apache/airflow/pull/19907#issuecomment-983439537
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19907: Move to watchtower 2.0.1 - Fixes Watchtower crash when logging empty line
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19907:
URL: https://github.com/apache/airflow/pull/19907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org