You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/11/04 20:26:41 UTC
[GitHub] [cordova-plugin-dialogs] dpa99c opened a new pull request #148: feature (GH-128) ios/android: enable programmatic dismissal of open dialogs. Resolves #128.
dpa99c opened a new pull request #148:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/148
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS and Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
Enables programmatic dismissal of currently open dialogs.
Example use case is where a dialog is opened but the context for the dialog changes in real-time so the dialog is no longer relevant.
<!-- If it fixes an open issue, please link to the issue here. -->
Resolves #128 and supersedes #79.
### Description
<!-- Describe your changes in detail -->
Two new plugin API methods have been added:
- [`dismissPrevious()`](https://github.com/dpa99c/cordova-plugin-dialogs/tree/GH-128#navigatornotificationdismissprevious) - dismisses the dialog that was most recently opened
- [`dismissAll()`](https://github.com/dpa99c/cordova-plugin-dialogs/tree/GH-128#navigatornotificationdismissall) - dismisses all open dialogs
Both functions take `successCallback` and `errorCallback` arguments:
- `successCallback` is invoked when one or more previously opened dialogs has been dismissed
- `errorCallback` is invoked if no previously opened dialogs exist to dismiss
### Testing
<!-- Please describe in detail how you tested your changes. -->
- A test harness Cordova project has been created - build+run iOS/Android platform to test new API methods: https://github.com/dpa99c/cordova-plugin-dialogs-test
- Automated tests [have been updated](https://github.com/dpa99c/cordova-plugin-dialogs/blob/GH-128/tests/tests.js#L50) to test the for existence of new API methods
- Manual tests [have been updated](https://github.com/dpa99c/cordova-plugin-dialogs/blob/GH-128/tests/tests.js#L340) to test both new API methods
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-dialogs] dpa99c commented on pull request #148: feature (GH-128) ios/android: enable programmatic dismissal of open dialogs. Resolves #128.
Posted by GitBox <gi...@apache.org>.
dpa99c commented on pull request #148:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/148#issuecomment-722308976
Travis CI browser platform tests are failing for some reason but I don't think it's related to changes made by this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-dialogs] dpa99c merged pull request #148: feature (GH-128) ios/android: enable programmatic dismissal of open dialogs. Resolves #128.
Posted by GitBox <gi...@apache.org>.
dpa99c merged pull request #148:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-dialogs] timbru31 commented on pull request #148: feature (GH-128) ios/android: enable programmatic dismissal of open dialogs. Resolves #128.
Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #148:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/148#issuecomment-722313659
Yeah we've got an issue in paramedic that causes the failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org