You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apiri <gi...@git.apache.org> on 2018/05/02 15:42:23 UTC
[GitHub] nifi-minifi pull request #123: MINIFI-452 Updating MiNiFi to 1.6.0 NiFi comp...
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/123
MINIFI-452 Updating MiNiFi to 1.6.0 NiFi components.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi MINIFI-452
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #123
----
commit 3e7ea674892a633147eaa63ddac803d4452d7c3a
Author: Aldrin Piri <al...@...>
Date: 2018-05-02T15:08:46Z
MINIFI-452 Updating MiNiFi to 1.6.0 NiFi components.
----
---
[GitHub] nifi-minifi pull request #123: MINIFI-452 Updating MiNiFi to 1.6.0 NiFi comp...
Posted by jzonthemtn <gi...@git.apache.org>.
Github user jzonthemtn commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/123#discussion_r185639878
--- Diff: minifi-nar-bundles/minifi-provenance-repository-bundle/minifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/MiNiFiPersistentProvenanceRepository.java ---
@@ -2065,6 +2065,21 @@ public void run() {
}
}
+ @Override
+ public String getContainerFileStoreName(final String containerName) {
+ final Map<String, File> map = configuration.getStorageDirectories();
+ final File container = map.get(containerName);
+ if (container == null) {
+ return null;
+ }
+
+ try {
+ return Files.getFileStore(container.toPath()).name();
+ } catch (IOException e) {
+ return null;
--- End diff --
I don't disagree -- you would know better than me anyway. :)
---
[GitHub] nifi-minifi pull request #123: MINIFI-452 Updating MiNiFi to 1.6.0 NiFi comp...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/123#discussion_r185608884
--- Diff: minifi-nar-bundles/minifi-provenance-repository-bundle/minifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/MiNiFiPersistentProvenanceRepository.java ---
@@ -2065,6 +2065,21 @@ public void run() {
}
}
+ @Override
+ public String getContainerFileStoreName(final String containerName) {
+ final Map<String, File> map = configuration.getStorageDirectories();
+ final File container = map.get(containerName);
+ if (container == null) {
+ return null;
+ }
+
+ try {
+ return Files.getFileStore(container.toPath()).name();
+ } catch (IOException e) {
+ return null;
--- End diff --
Combing through source, I don't think there is a lot to glean from this scenario. If I am overlooking something let me know and we should be sure to make the appropriate changes in NiFi, where this is grabbed from; one of the unfortunate idiosyncrasies of the current model that minifi is.
---
[GitHub] nifi-minifi pull request #123: MINIFI-452 Updating MiNiFi to 1.6.0 NiFi comp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi/pull/123
---
[GitHub] nifi-minifi pull request #123: MINIFI-452 Updating MiNiFi to 1.6.0 NiFi comp...
Posted by jzonthemtn <gi...@git.apache.org>.
Github user jzonthemtn commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/123#discussion_r185586648
--- Diff: minifi-nar-bundles/minifi-provenance-repository-bundle/minifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/MiNiFiPersistentProvenanceRepository.java ---
@@ -2065,6 +2065,21 @@ public void run() {
}
}
+ @Override
+ public String getContainerFileStoreName(final String containerName) {
+ final Map<String, File> map = configuration.getStorageDirectories();
+ final File container = map.get(containerName);
+ if (container == null) {
+ return null;
+ }
+
+ try {
+ return Files.getFileStore(container.toPath()).name();
+ } catch (IOException e) {
+ return null;
--- End diff --
Wondering if there's any use in logging the error?
---