You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by Philip Zeyliger <ph...@cloudera.com> on 2018/05/11 19:02:41 UTC
New message on your code reviews when cherry-picking your change fails.
Hey folks,
I just updated https://jenkins.impala.io/job/cherrypick-2.x-and-test/ to
comment on a code review the first time a change causes the cherry-picking
job to fail. A sample e-mail is forwarded below, with the message
highlighted by me. I've used Gerrit to send e-mail, which, frankly, was
easier to implement for me, but it does end up possibly sending to more
people than a more targeted approach.
Hopefully this helps get failed cherrypicks noticed and handled expediently.
Please holler if you either notice this being buggy or if you hate it. I
figure we can try it for a week and rip it up if we don't like it.
-- Philip
---------- Forwarded message ----------
From: Impala Public Jenkins (Code Review) <ge...@cloudera.org>
Date: Fri, May 11, 2018 at 11:58 AM
Subject: [Impala-ASF-CR] Update version to 3.1.0-SNAPSHOT
To: Sailesh Mukil <sa...@cloudera.com>, impala-cr@cloudera.com,
reviews@impala.incubator.apache.org
Impala Public Jenkins *posted comments* on this change.
View Change <http://gerrit.cloudera.org:8080/10360>
Patch set 2:
This change did not cherrypick successfully into branch 2.x. To resolve
this, please do the cherry-pick manually and submit it to Gerrit at
refs/for/2.x or add an exception to the branch 2.x copy of
bin/ignored_commits.json. Thanks, your friendly bot at
https://jenkins.impala.io/job/cherrypick-2.x-and-test/479/ .
To view, visit change 10360 <http://gerrit.cloudera.org:8080/10360>. To
unsubscribe, visit settings <http://gerrit.cloudera.org:8080/settings>.
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2e2df73d27fa332d17fec4e9aa469ea91b14167
Gerrit-Change-Number: 10360
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 May 2018 18:58:13 +0000
Gerrit-HasComments: No
--
You received this message because you are subscribed to the Google Groups
"impala-cr" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to impala-cr+unsubscribe@cloudera.com.
For more options, visit https://groups.google.com/a/cloudera.com/d/optout.
Re: New message on your code reviews when cherry-picking your change fails.
Posted by Sailesh Mukil <sa...@cloudera.com>.
Thanks for doing this!
On Fri, May 11, 2018 at 12:17 PM, Tim Armstrong <ta...@cloudera.com>
wrote:
> Thanks for setting this up, this should make things a lot easier.
>
> On Fri, May 11, 2018 at 12:02 PM, Philip Zeyliger <ph...@cloudera.com>
> wrote:
>
> > Hey folks,
> >
> > I just updated https://jenkins.impala.io/job/cherrypick-2.x-and-test/ to
> > comment on a code review the first time a change causes the
> cherry-picking
> > job to fail. A sample e-mail is forwarded below, with the message
> > highlighted by me. I've used Gerrit to send e-mail, which, frankly, was
> > easier to implement for me, but it does end up possibly sending to more
> > people than a more targeted approach.
> >
> > Hopefully this helps get failed cherrypicks noticed and handled
> > expediently.
> >
> > Please holler if you either notice this being buggy or if you hate it. I
> > figure we can try it for a week and rip it up if we don't like it.
> >
> > -- Philip
> >
> > ---------- Forwarded message ----------
> > From: Impala Public Jenkins (Code Review) <ge...@cloudera.org>
> > Date: Fri, May 11, 2018 at 11:58 AM
> > Subject: [Impala-ASF-CR] Update version to 3.1.0-SNAPSHOT
> > To: Sailesh Mukil <sa...@cloudera.com>, impala-cr@cloudera.com,
> > reviews@impala.incubator.apache.org
> >
> >
> > Impala Public Jenkins *posted comments* on this change.
> >
> > View Change <http://gerrit.cloudera.org:8080/10360>
> >
> > Patch set 2:
> >
> > This change did not cherrypick successfully into branch 2.x. To resolve
> > this, please do the cherry-pick manually and submit it to Gerrit at
> > refs/for/2.x or add an exception to the branch 2.x copy of
> > bin/ignored_commits.json. Thanks, your friendly bot at
> > https://jenkins.impala.io/job/cherrypick-2.x-and-test/479/ .
> >
> >
> > To view, visit change 10360 <http://gerrit.cloudera.org:8080/10360>. To
> > unsubscribe, visit settings <http://gerrit.cloudera.org:8080/settings>.
> > Gerrit-Project: Impala-ASF
> > Gerrit-Branch: master
> > Gerrit-MessageType: comment
> > Gerrit-Change-Id: Ia2e2df73d27fa332d17fec4e9aa469ea91b14167
> > Gerrit-Change-Number: 10360
> > Gerrit-PatchSet: 2
> > Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
> > Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@
> cloudera.com
> > >
> > Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
> > Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
> > Gerrit-Comment-Date: Fri, 11 May 2018 18:58:13 +0000
> > Gerrit-HasComments: No
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "impala-cr" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to impala-cr+unsubscribe@cloudera.com.
> > For more options, visit https://groups.google.com/a/
> cloudera.com/d/optout.
> >
>
Re: New message on your code reviews when cherry-picking your change fails.
Posted by Tim Armstrong <ta...@cloudera.com>.
Thanks for setting this up, this should make things a lot easier.
On Fri, May 11, 2018 at 12:02 PM, Philip Zeyliger <ph...@cloudera.com>
wrote:
> Hey folks,
>
> I just updated https://jenkins.impala.io/job/cherrypick-2.x-and-test/ to
> comment on a code review the first time a change causes the cherry-picking
> job to fail. A sample e-mail is forwarded below, with the message
> highlighted by me. I've used Gerrit to send e-mail, which, frankly, was
> easier to implement for me, but it does end up possibly sending to more
> people than a more targeted approach.
>
> Hopefully this helps get failed cherrypicks noticed and handled
> expediently.
>
> Please holler if you either notice this being buggy or if you hate it. I
> figure we can try it for a week and rip it up if we don't like it.
>
> -- Philip
>
> ---------- Forwarded message ----------
> From: Impala Public Jenkins (Code Review) <ge...@cloudera.org>
> Date: Fri, May 11, 2018 at 11:58 AM
> Subject: [Impala-ASF-CR] Update version to 3.1.0-SNAPSHOT
> To: Sailesh Mukil <sa...@cloudera.com>, impala-cr@cloudera.com,
> reviews@impala.incubator.apache.org
>
>
> Impala Public Jenkins *posted comments* on this change.
>
> View Change <http://gerrit.cloudera.org:8080/10360>
>
> Patch set 2:
>
> This change did not cherrypick successfully into branch 2.x. To resolve
> this, please do the cherry-pick manually and submit it to Gerrit at
> refs/for/2.x or add an exception to the branch 2.x copy of
> bin/ignored_commits.json. Thanks, your friendly bot at
> https://jenkins.impala.io/job/cherrypick-2.x-and-test/479/ .
>
>
> To view, visit change 10360 <http://gerrit.cloudera.org:8080/10360>. To
> unsubscribe, visit settings <http://gerrit.cloudera.org:8080/settings>.
> Gerrit-Project: Impala-ASF
> Gerrit-Branch: master
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Ia2e2df73d27fa332d17fec4e9aa469ea91b14167
> Gerrit-Change-Number: 10360
> Gerrit-PatchSet: 2
> Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com
> >
> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
> Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
> Gerrit-Comment-Date: Fri, 11 May 2018 18:58:13 +0000
> Gerrit-HasComments: No
>
> --
> You received this message because you are subscribed to the Google Groups
> "impala-cr" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to impala-cr+unsubscribe@cloudera.com.
> For more options, visit https://groups.google.com/a/cloudera.com/d/optout.
>