You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/04/11 16:52:37 UTC
Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC
Background Task
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Robert Levas.
Bugs: AMBARI-20714
https://issues.apache.org/jira/browse/AMBARI-20714
Repository: ambari
Description
-------
Create a new UpgradeCatalog for v2.5.1 and add the DB changes in AMBARI-20712
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 590a3e8
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/58363/diff/1/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC
Background Task
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/#review171753
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 12, 2017, 12:55 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58363/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 12:55 a.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-20714
> https://issues.apache.org/jira/browse/AMBARI-20714
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a new UpgradeCatalog for v2.5.1 and add the DB changes in AMBARI-20712
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java fdec5f0
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 590a3e8
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 5785a9d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 96ef0ac
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3396ce9
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c6bfa94
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql bbf5d3c
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 13ab01d
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58363/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC
Background Task
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/#review171731
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 11, 2017, 8:55 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58363/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 8:55 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-20714
> https://issues.apache.org/jira/browse/AMBARI-20714
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a new UpgradeCatalog for v2.5.1 and add the DB changes in AMBARI-20712
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java fdec5f0
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 590a3e8
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 5785a9d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 96ef0ac
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3396ce9
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c6bfa94
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql bbf5d3c
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 13ab01d
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58363/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC
Background Task
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/
-----------------------------------------------------------
(Updated April 11, 2017, 8:55 p.m.)
Review request for Ambari, Nate Cole and Robert Levas.
Bugs: AMBARI-20714
https://issues.apache.org/jira/browse/AMBARI-20714
Repository: ambari
Description
-------
Create a new UpgradeCatalog for v2.5.1 and add the DB changes in AMBARI-20712
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java fdec5f0
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 590a3e8
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java PRE-CREATION
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 5785a9d
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 96ef0ac
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3396ce9
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c6bfa94
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql bbf5d3c
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 13ab01d
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/58363/diff/2/
Changes: https://reviews.apache.org/r/58363/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC
Background Task
Posted by Nate Cole <nc...@hortonworks.com>.
> On April 11, 2017, 2:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
> > Lines 31 (patched)
> > <https://reviews.apache.org/r/58363/diff/1/?file=1688843#file1688843line31>
> >
> > Can we shorten this to "is_background"?
+1 for this suggestion.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/#review171591
-----------------------------------------------------------
On April 11, 2017, 12:52 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58363/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 12:52 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-20714
> https://issues.apache.org/jira/browse/AMBARI-20714
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a new UpgradeCatalog for v2.5.1 and add the DB changes in AMBARI-20712
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 590a3e8
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58363/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC
Background Task
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On April 11, 2017, 2:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
> > Lines 31 (patched)
> > <https://reviews.apache.org/r/58363/diff/1/?file=1688843#file1688843line31>
> >
> > Can we shorten this to "is_background"?
>
> Nate Cole wrote:
> +1 for this suggestion.
Sure - I'll change the SQL as well and update the patch.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/#review171591
-----------------------------------------------------------
On April 11, 2017, 12:52 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58363/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 12:52 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-20714
> https://issues.apache.org/jira/browse/AMBARI-20714
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a new UpgradeCatalog for v2.5.1 and add the DB changes in AMBARI-20712
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 590a3e8
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58363/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC
Background Task
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/#review171591
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
Lines 31 (patched)
<https://reviews.apache.org/r/58363/#comment244531>
Can we shorten this to "is_background"?
- Alejandro Fernandez
On April 11, 2017, 4:52 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58363/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 4:52 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-20714
> https://issues.apache.org/jira/browse/AMBARI-20714
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a new UpgradeCatalog for v2.5.1 and add the DB changes in AMBARI-20712
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 590a3e8
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58363/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>