You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Dave Thompson (Jira)" <ji...@apache.org> on 2024/06/02 15:07:00 UTC

[jira] [Closed] (DAFFODIL-2883) Pre-existing PUA characters in data cause SDE

     [ https://issues.apache.org/jira/browse/DAFFODIL-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Thompson closed DAFFODIL-2883.
-----------------------------------

Verified the specified commits (commits 8433f4d83d33da31371fcdfa016a7c627011aca3 and 182f157d64d515af84e94576625bb3510c5126af) are included in the latest pull from the daffodil repository.

Verified, via review, changes identified in the commit comment were implemented. 

Verified the affected daffodil subproject sbt test suites executed successfully, including the modified and new tests.

Rolled commit back to pre-fix commit and verified that the Pre-existing pua Infoset Chars tests render an SDE error message as identified in the initial writeup.

Verified the nightly test suite executes successfully with no unexpected failures.

> Pre-existing PUA characters in data cause SDE
> ---------------------------------------------
>
>                 Key: DAFFODIL-2883
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2883
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Back End
>    Affects Versions: 3.6.0
>            Reporter: Mike Beckerle
>            Assignee: Mike Beckerle
>            Priority: Major
>             Fix For: 3.8.0
>
>
> If data contains Unicode PUA characters, these cause the Infoset Outputter to convert the RemapPUACharDetected into an SDE.
> We can't get away with this. We need to tolerate PUA characters in data and have them either cause a ParseError, or just tolerate them. (Or have a switch to choose between those modes) 
> This was discovered by fuzz testing. 
> If the existence of PUA characters means the data is gibberish, then perhaps the parser is speculating down a path that should be backtracked. We need a parse error in that case. 
> If the existence of PUA characters is acceptable, then we need no error at all from them. 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)