You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2021/12/14 03:10:26 UTC
[GitHub] [incubator-teaclave] mssun opened a new pull request #589: Fix rebuild packages every time
mssun opened a new pull request #589:
URL: https://github.com/apache/incubator-teaclave/pull/589
## Description
This PR fix building issue.
According to https://github.com/rust-lang/cargo/issues/2904, I enabled cargo log with `CARGO_LOG=cargo::core::compiler::fingerprint=trace` and see this log:
```
[2021-12-14T02:19:39Z INFO cargo::core::compiler::fingerprint] err: RUSTFLAGS has changed: ["--cfg", "test_mode", "--cfg", "sgx_sim", "--cfg", "executor_builtin", "--cfg", "executor_mesapy", "--cfg", "executor_wamr", "--cfg", "test_mode"] != ["--cfg", "test_mode", "--cfg", "sgx_sim", "--cfg", "executor_builtin", "--cfg", "executor_mesapy", "--cfg", "executor_wamr"]
```
I realize that this additional `test_mode` flag affect the rebuild. However, when building with `TEST_MODE=ON`, the `test_mode` flag has been added to all services. Therefore, we can safely delete this.
## Type of change (select or add applied and delete the others)
- [x] Bug fix (non-breaking change which fixes an issue)
## How has this been tested?
CI.
## Checklist
- [x] Fork the repo and create your branch from `master`.
- [x] If you've added code that should be tested, add tests.
- [x] If you've changed APIs, update the documentation.
- [x] Ensure the tests pass (see CI results).
- [x] Make sure your code lints/format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun merged pull request #589: Fix packages rebuild every time
Posted by GitBox <gi...@apache.org>.
mssun merged pull request #589:
URL: https://github.com/apache/incubator-teaclave/pull/589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org