You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Mostafa Mokhtar (Code Review)" <ge...@cloudera.org> on 2017/09/13 23:09:59 UTC

[Impala-ASF-CR] IMPALA-5926 : Avoid printing expensive stack when closing a session

Mostafa Mokhtar has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/8060

Change subject: IMPALA-5926 : Avoid printing expensive stack when closing a session
......................................................................

IMPALA-5926 : Avoid printing expensive stack when closing a session

When conducting high concurrency tests for short running queries
 noticed that queries are spending lots of time in Unregister query.
Investigation showed that CloseSessionInternal calls
status("Session closed") which unnecessarily prints the stack
to the log which is expensive and not required, refer to IMPALA-5275.

The fix uses Expected(const std::string& error_msg) which doesn't
print the stack.

Table below summarizes speedup for highly selective scan query.

+-----------+--------------------------+---------------------+---------+
| Num users | Baseline Queries/minutes | Fix Queries/minutes | Speedup |
+-----------+--------------------------+---------------------+---------+
| 1         | 19                       | 24                  | 1.23x   |
| 2         | 41                       | 48                  | 1.17x   |
| 4         | 71                       | 91                  | 1.28x   |
| 8         | 96                       | 161                 | 1.67x   |
| 16        | 117                      | 226                 | 1.92x   |
| 32        | 140                      | 266                 | 1.90x   |
| 64        | 174                      | 269                 | 1.54x   |
| 128       | 202                      | 265                 | 1.31x   |
+-----------+--------------------------+---------------------+---------+

Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/8060/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>

[Impala-ASF-CR] IMPALA-5926: Avoid printing expensive stack when closing a session

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5926: Avoid printing expensive stack when closing a session
......................................................................


IMPALA-5926: Avoid printing expensive stack when closing a session

When conducting high concurrency tests for short running queries
 noticed that queries are spending lots of time in Unregister query.
Investigation showed that CloseSessionInternal calls
status("Session closed") which unnecessarily prints the stack
to the log which is expensive and not required, refer to IMPALA-5275.

The fix uses Expected(const std::string& error_msg) which doesn't
print the stack.

Table below summarizes speedup for highly selective scan query.

+-----------+--------------------------+---------------------+---------+
| Num users | Baseline Queries/minutes | Fix Queries/minutes | Speedup |
+-----------+--------------------------+---------------------+---------+
| 1         | 19                       | 24                  | 1.23x   |
| 2         | 41                       | 48                  | 1.17x   |
| 4         | 71                       | 91                  | 1.28x   |
| 8         | 96                       | 161                 | 1.67x   |
| 16        | 117                      | 226                 | 1.92x   |
| 32        | 140                      | 266                 | 1.90x   |
| 64        | 174                      | 269                 | 1.54x   |
| 128       | 202                      | 265                 | 1.31x   |
+-----------+--------------------------+---------------------+---------+

Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Reviewed-on: http://gerrit.cloudera.org:8080/8060
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-5926: Avoid printing expensive stack when closing a session

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5926: Avoid printing expensive stack when closing a session
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1220/

-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5926 : Avoid printing expensive stack when closing a session

Posted by "Mostafa Mokhtar (Code Review)" <ge...@cloudera.org>.
Mostafa Mokhtar has restored this change.

Change subject: IMPALA-5926 : Avoid printing expensive stack when closing a session
......................................................................


Restored

-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>

[Impala-ASF-CR] IMPALA-5926: Avoid printing expensive stack when closing a session

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/8060

to look at the new patch set (#2).

Change subject: IMPALA-5926: Avoid printing expensive stack when closing a session
......................................................................

IMPALA-5926: Avoid printing expensive stack when closing a session

When conducting high concurrency tests for short running queries
 noticed that queries are spending lots of time in Unregister query.
Investigation showed that CloseSessionInternal calls
status("Session closed") which unnecessarily prints the stack
to the log which is expensive and not required, refer to IMPALA-5275.

The fix uses Expected(const std::string& error_msg) which doesn't
print the stack.

Table below summarizes speedup for highly selective scan query.

+-----------+--------------------------+---------------------+---------+
| Num users | Baseline Queries/minutes | Fix Queries/minutes | Speedup |
+-----------+--------------------------+---------------------+---------+
| 1         | 19                       | 24                  | 1.23x   |
| 2         | 41                       | 48                  | 1.17x   |
| 4         | 71                       | 91                  | 1.28x   |
| 8         | 96                       | 161                 | 1.67x   |
| 16        | 117                      | 226                 | 1.92x   |
| 32        | 140                      | 266                 | 1.90x   |
| 64        | 174                      | 269                 | 1.54x   |
| 128       | 202                      | 265                 | 1.31x   |
+-----------+--------------------------+---------------------+---------+

Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/8060/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-5926: Avoid printing expensive stack when closing a session

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: IMPALA-5926: Avoid printing expensive stack when closing a session
......................................................................


Patch Set 2: Code-Review+2

Remove space from commit msg. Carry +2

-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5926 : Avoid printing expensive stack when closing a session

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5926 : Avoid printing expensive stack when closing a session
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5926: Avoid printing expensive stack when closing a session

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change.

Change subject: IMPALA-5926: Avoid printing expensive stack when closing a session
......................................................................


Patch Set 3:

I took the liberty of trawling through some large impalad log files to see where else this sort of thing could be happening. What you're seeing below is the stack traces produced by status.cc from about 1GB of log files of impala on a cluster at work. I've removed the timestamps, removed the hostnames (outside of the script below), and the query ids.

The punch line is that "Not implemented for this format" sure seems to come up a lot and may benefit from similar treatment.

I'm not proud of it, but here's the "query":

find . -type f -name '*IMPALAD*.gz' | xargs gzcat  | awk '/^I/ { if(x) { print x; } x = "" } /status.cc/ { x=" "; } { if(x) { x=x  $0 } }'  | sed -e 's/0x[0-9a-fx]* //g' | sed -e 's/[0-9a-f]\{16\}:[0-9a-f]*/QUERYID/g' |  tr -s '\t' ' ' | tr '[0-9]' 'N' | sort | uniq -c  | sort -n | tee output.txt


300090  INNNN NN:NN:NN.NNNNNN NNNNN status.cc:NNNN Not implemented for this format. @ impala::Status::Status() @ impala::HdfsScanNodeBase::Codegen() @ impala::ExecNode::Codegen() @ impala::PartitionedAggregationNode::Codegen() @ impala::FragmentInstanceState::Prepare() @ impala::FragmentInstanceState::Exec() @ impala::QueryState::ExecFInstance() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
70111  INNNN NN:NN:NN.NNNNNN NNNN status.cc:NNNN Not implemented for this format. @ impala::Status::Status() @ impala::HdfsScanNodeBase::Codegen() @ impala::ExecNode::Codegen() @ impala::PartitionedAggregationNode::Codegen() @ impala::FragmentInstanceState::Prepare() @ impala::FragmentInstanceState::Exec() @ impala::QueryState::ExecFInstance() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
52119  INNNN NN:NN:NN.NNNNNN NNNNN status.cc:NNNN Session closed @ impala::Status::Status() @ impala::ImpalaServer::CloseSessionInternal() @ impala::ImpalaServer::ConnectionEnd() @ impala::ThriftServer::ThriftServerEventProcessor::deleteContext() @ apache::thrift::server::TThreadPoolServer::Task::run() @ apache::thrift::concurrency::ThreadManager::Worker::run() @ impala::ThriftThread::RunRunnable() @ boost::detail::function::void_function_obj_invokerN<>::invoke() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
50797  INNNN NN:NN:NN.NNNNNN NNNNNN status.cc:NNNN Not implemented for this format. @ impala::Status::Status() @ impala::HdfsScanNodeBase::Codegen() @ impala::ExecNode::Codegen() @ impala::PartitionedAggregationNode::Codegen() @ impala::FragmentInstanceState::Prepare() @ impala::FragmentInstanceState::Exec() @ impala::QueryState::ExecFInstance() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
43115  INNNN NN:NN:NN.NNNNNN NNNNN status.cc:NNNN Not implemented for this format. @ impala::Status::Status() @ impala::HdfsScanNodeBase::Codegen() @ impala::ExecNode::Codegen() @ impala::TopNNode::Codegen() @ impala::FragmentInstanceState::Prepare() @ impala::FragmentInstanceState::Exec() @ impala::QueryState::ExecFInstance() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
21064  INNNN NN:NN:NN.NNNNNN NNNNN status.cc:NNNN Session closed @ impala::Status::Status() @ impala::ImpalaServer::CloseSessionInternal() @ impala::ImpalaServer::CloseSession() @ apache::hive::service::cli::thrift::TCLIServiceProcessor::process_CloseSession() @ apache::hive::service::cli::thrift::TCLIServiceProcessor::dispatchCall() @ apache::thrift::TDispatchProcessor::process() @ apache::thrift::server::TThreadPoolServer::Task::run() @ apache::thrift::concurrency::ThreadManager::Worker::run() @ impala::ThriftThread::RunRunnable() @ boost::detail::function::void_function_obj_invokerN<>::invoke() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
16750  INNNN NN:NN:NN.NNNNNN NNNNNN status.cc:NNNN Session closed @ impala::Status::Status() @ impala::ImpalaServer::CloseSessionInternal() @ impala::ImpalaServer::ConnectionEnd() @ impala::ThriftServer::ThriftServerEventProcessor::deleteContext() @ apache::thrift::server::TThreadPoolServer::Task::run() @ apache::thrift::concurrency::ThreadManager::Worker::run() @ impala::ThriftThread::RunRunnable() @ boost::detail::function::void_function_obj_invokerN<>::invoke() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
10784  INNNN NN:NN:NN.NNNNNN NNNN status.cc:NNNN Not implemented for this format. @ impala::Status::Status() @ impala::HdfsScanNodeBase::Codegen() @ impala::ExecNode::Codegen() @ impala::TopNNode::Codegen() @ impala::FragmentInstanceState::Prepare() @ impala::FragmentInstanceState::Exec() @ impala::QueryState::ExecFInstance() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
9112  INNNN NN:NN:NN.NNNNNN NNNN status.cc:NNNN Session closed @ impala::Status::Status() @ impala::ImpalaServer::CloseSessionInternal() @ impala::ImpalaServer::ConnectionEnd() @ impala::ThriftServer::ThriftServerEventProcessor::deleteContext() @ apache::thrift::server::TThreadPoolServer::Task::run() @ apache::thrift::concurrency::ThreadManager::Worker::run() @ impala::ThriftThread::RunRunnable() @ boost::detail::function::void_function_obj_invokerN<>::invoke() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
7855  INNNN NN:NN:NN.NNNNNN NNNNNN status.cc:NNNN Not implemented for this format. @ impala::Status::Status() @ impala::HdfsScanNodeBase::Codegen() @ impala::ExecNode::Codegen() @ impala::TopNNode::Codegen() @ impala::FragmentInstanceState::Prepare() @ impala::FragmentInstanceState::Exec() @ impala::QueryState::ExecFInstance() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
5700  INNNN NN:NN:NN.NNNNNN NNNNNN status.cc:NNNN Session closed @ impala::Status::Status() @ impala::ImpalaServer::CloseSessionInternal() @ impala::ImpalaServer::CloseSession() @ apache::hive::service::cli::thrift::TCLIServiceProcessor::process_CloseSession() @ apache::hive::service::cli::thrift::TCLIServiceProcessor::dispatchCall() @ apache::thrift::TDispatchProcessor::process() @ apache::thrift::server::TThreadPoolServer::Task::run() @ apache::thrift::concurrency::ThreadManager::Worker::run() @ impala::ThriftThread::RunRunnable() @ boost::detail::function::void_function_obj_invokerN<>::invoke() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
4761  INNNN NN:NN:NN.NNNNNN NNNN status.cc:NNNN Session closed @ impala::Status::Status() @ impala::ImpalaServer::CloseSessionInternal() @ impala::ImpalaServer::CloseSession() @ apache::hive::service::cli::thrift::TCLIServiceProcessor::process_CloseSession() @ apache::hive::service::cli::thrift::TCLIServiceProcessor::dispatchCall() @ apache::thrift::TDispatchProcessor::process() @ apache::thrift::server::TThreadPoolServer::Task::run() @ apache::thrift::concurrency::ThreadManager::Worker::run() @ impala::ThriftThread::RunRunnable() @ boost::detail::function::void_function_obj_invokerN<>::invoke() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
4080  INNNN NN:NN:NN.NNNNNN NNNNN status.cc:NNN RPC recv timed out: Client hostname:NNNNN timed-out during recv call. @ impala::Status::Status() @ impala::DataStreamSender::Channel::DoTransmitDataRpc() @ impala::DataStreamSender::Channel::TransmitDataHelper() @ impala::DataStreamSender::Channel::TransmitData() @ impala::ThreadPool<>::WorkerThread() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
3976  INNNN NN:NN:NN.NNNNNN NNN status.cc:NNNN Not implemented for this format. @ impala::Status::Status() @ impala::HdfsScanNodeBase::Codegen() @ impala::ExecNode::Codegen() @ impala::PartitionedAggregationNode::Codegen() @ impala::FragmentInstanceState::Prepare() @ impala::FragmentInstanceState::Exec() @ impala::QueryState::ExecFInstance() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
3421  INNNN NN:NN:NN.NNNNNN NNNNN status.cc:NNNN Timestamp not yet supported for codegen. @ impala::Status::Status() @ impala::HdfsScanner::CodegenWriteCompleteTuple() @ impala::HdfsTextScanner::Codegen() @ impala::HdfsScanNodeBase::Codegen() @ impala::FragmentInstanceState::Prepare() @ impala::FragmentInstanceState::Exec() @ impala::QueryState::ExecFInstance() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
3227  INNNN NN:NN:NN.NNNNNN NNNNN status.cc:NNN ReportExecStatus(): Received report for unknown query ID (probably closed or cancelled): QUERYID @ impala::Status::Status() @ impala::ImpalaServer::ReportExecStatus() @ impala::ImpalaInternalServiceProcessor::process_ReportExecStatus() @ impala::ImpalaInternalServiceProcessor::dispatchCall() @ apache::thrift::TDispatchProcessor::process() @ apache::thrift::server::TAcceptQueueServer::Task::run() @ impala::ThriftThread::RunRunnable() @ boost::detail::function::void_function_obj_invokerN<>::invoke() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
2335  INNNN NN:NN:NN.NNNNNN NNNNN status.cc:NNNN Invalid session id: QUERYID @ impala::Status::Status() @ impala::ImpalaServer::CloseSessionInternal() @ impala::ImpalaServer::CloseSession() @ apache::hive::service::cli::thrift::TCLIServiceProcessor::process_CloseSession() @ apache::hive::service::cli::thrift::TCLIServiceProcessor::dispatchCall() @ apache::thrift::TDispatchProcessor::process() @ apache::thrift::server::TThreadPoolServer::Task::run() @ apache::thrift::concurrency::ThreadManager::Worker::run() @ impala::ThriftThread::RunRunnable() @ boost::detail::function::void_function_obj_invokerN<>::invoke() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
2016  INNNN NN:NN:NN.NNNNNN NNNNNN status.cc:NNNN Timestamp not yet supported for codegen. @ impala::Status::Status() @ impala::HdfsScanner::CodegenWriteCompleteTuple() @ impala::HdfsTextScanner::Codegen() @ impala::HdfsScanNodeBase::Codegen() @ impala::FragmentInstanceState::Prepare() @ impala::FragmentInstanceState::Exec() @ impala::QueryState::ExecFInstance() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
1404  INNNN NN:NN:NN.NNNNNN NNN status.cc:NNNN Session closed @ impala::Status::Status() @ impala::ImpalaServer::CloseSessionInternal() @ impala::ImpalaServer::ConnectionEnd() @ impala::ThriftServer::ThriftServerEventProcessor::deleteContext() @ apache::thrift::server::TThreadPoolServer::Task::run() @ apache::thrift::concurrency::ThreadManager::Worker::run() @ impala::ThriftThread::RunRunnable() @ boost::detail::function::void_function_obj_invokerN<>::invoke() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
1384  INNNN NN:NN:NN.NNNNNN NNNNN status.cc:NNNN couldn't deserialize thrift msg:No more data to read. @ impala::Status::Status() @ impala::DeserializeThriftMsg<>() @ impala::BaseScalarColumnReader::ReadPageHeader() @ impala::BaseScalarColumnReader::ReadDataPage() @ impala::BaseScalarColumnReader::NextPage() @ impala::ScalarColumnReader<>::ReadNonRepeatedValueBatch() @ impala::HdfsParquetScanner::AssembleRows() @ impala::HdfsParquetScanner::GetNextInternal() @ impala::HdfsParquetScanner::ProcessSplit() @ impala::HdfsScanNode::ProcessSplit() @ impala::HdfsScanNode::ScannerThread() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
1358  INNNN NN:NN:NN.NNNNNN NNNNN status.cc:NNN RPC recv timed out: Client hostname:NNNNN timed-out during recv call. @ impala::Status::Status() @ impala::ClientConnection<>::DoRpc<>() @ impala::DataStreamSender::Channel::DoTransmitDataRpc() @ impala::DataStreamSender::Channel::TransmitDataHelper() @ impala::DataStreamSender::Channel::TransmitData() @ impala::ThreadPool<>::WorkerThread() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
1031  INNNN NN:NN:NN.NNNNNN NNNNNN status.cc:NNN RPC recv timed out: Client hostname:NNNNN timed-out during recv call. @ impala::Status::Status() @ impala::DataStreamSender::Channel::DoTransmitDataRpc() @ impala::DataStreamSender::Channel::TransmitDataHelper() @ impala::DataStreamSender::Channel::TransmitData() @ impala::ThreadPool<>::WorkerThread() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone
1008  INNNN NN:NN:NN.NNNNNN NNNNNN status.cc:NNNN couldn't deserialize thrift msg:No more data to read. @ impala::Status::Status() @ impala::DeserializeThriftMsg<>() @ impala::BaseScalarColumnReader::ReadPageHeader() @ impala::BaseScalarColumnReader::ReadDataPage() @ impala::BaseScalarColumnReader::NextPage() @ impala::ScalarColumnReader<>::ReadNonRepeatedValueBatch() @ impala::HdfsParquetScanner::AssembleRows() @ impala::HdfsParquetScanner::GetNextInternal() @ impala::HdfsParquetScanner::ProcessSplit() @ impala::HdfsScanNode::ProcessSplit() @ impala::HdfsScanNode::ScannerThread() @ impala::Thread::SuperviseThread() @ boost::detail::thread_data<>::run() @ (unknown) @ start_thread @ clone

-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5926: Avoid printing expensive stack when closing a session

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5926: Avoid printing expensive stack when closing a session
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/154/

-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5926 : Avoid printing expensive stack when closing a session

Posted by "Mostafa Mokhtar (Code Review)" <ge...@cloudera.org>.
Mostafa Mokhtar has abandoned this change.

Change subject: IMPALA-5926 : Avoid printing expensive stack when closing a session
......................................................................


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>

[Impala-ASF-CR] IMPALA-5926: Avoid printing expensive stack when closing a session

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5926: Avoid printing expensive stack when closing a session
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5926 : Avoid printing expensive stack when closing a session

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: IMPALA-5926 : Avoid printing expensive stack when closing a session
......................................................................


Patch Set 1: Code-Review+1

Amazing.

-- 
To view, visit http://gerrit.cloudera.org:8080/8060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d0ca485dd17bca758d916040745288c1a20c69f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No