You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/31 09:13:58 UTC
[GitHub] [beam] miamihotline opened a new pull request #17225: [BEAM-14205] [Playground] Tests for app states
miamihotline opened a new pull request #17225:
URL: https://github.com/apache/beam/pull/17225
Improved test coverage of the app states.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KonradJanica commented on a change in pull request #17225: [BEAM-14205] [Playground] Tests for app states
Posted by GitBox <gi...@apache.org>.
KonradJanica commented on a change in pull request #17225:
URL: https://github.com/apache/beam/pull/17225#discussion_r839851756
##########
File path: playground/frontend/lib/modules/examples/repositories/models/get_example_request.dart
##########
@@ -23,4 +23,14 @@ class GetExampleRequestWrapper {
final SDK sdk;
GetExampleRequestWrapper(this.path, this.sdk);
+
+ @override
+ bool operator ==(Object other) =>
+ identical(this, other) ||
+ other is GetExampleRequestWrapper &&
+ path == other.path &&
+ sdk == other.sdk;
+
+ @override
+ int get hashCode => path.hashCode ^ sdk.hashCode;
Review comment:
Nit: Flutter has the [hashValues](https://api.flutter.dev/flutter/dart-ui/hashValues.html) function which is more standard.
##########
File path: playground/frontend/lib/modules/examples/repositories/models/get_list_of_examples_request.dart
##########
@@ -23,4 +23,14 @@ class GetListOfExamplesRequestWrapper {
final String? category;
GetListOfExamplesRequestWrapper({required this.sdk, required this.category});
+
+ @override
+ bool operator ==(Object other) =>
+ identical(this, other) ||
+ other is GetListOfExamplesRequestWrapper &&
+ category == other.category &&
+ sdk == other.sdk;
+
+ @override
+ int get hashCode => category.hashCode ^ sdk.hashCode;
Review comment:
Nit: Flutter has the [hashValues](https://api.flutter.dev/flutter/dart-ui/hashValues.html) function which is more standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17225: [BEAM-14205] [Playground] Tests for app states
Posted by GitBox <gi...@apache.org>.
asf-ci commented on pull request #17225:
URL: https://github.com/apache/beam/pull/17225#issuecomment-1084305753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org