You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Piotr Zarzycki <pi...@gmail.com> on 2018/03/27 08:13:29 UTC
Re: [royale-asjs] branch feature/jewel-ui-set updated: removes
workaround for element styles thanks to bugs #30/#32 solved
Hi Carlos,
And again if you add in the description apache/royale-compiler#30 and
apache/royale-compiler#32 it will point to the proper issue. Now you are
pointing to some closed issue in asjs which is totally unrelated.
Thanks,
Piotr
2018-03-27 10:02 GMT+02:00 <ca...@apache.org>:
> This is an automated email from the ASF dual-hosted git repository.
>
> carlosrovira pushed a commit to branch feature/jewel-ui-set
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/feature/jewel-ui-set by
> this push:
> new 10d993c removes workaround for element styles thanks to bugs
> #30/#32 solved
> 10d993c is described below
>
> commit 10d993c21ef554019a249a8355e007adbab07ca8
> Author: Carlos Rovira <ca...@apache.org>
> AuthorDate: Tue Mar 27 10:02:00 2018 +0200
>
> removes workaround for element styles thanks to bugs #30/#32 solved
> ---
> .../src/main/resources/jewel-example-styles.css | 7 +++-
> .../src/main/royale/RadioButtonPlayGround.mxml | 2 +-
> .../royale/org/apache/royale/jewel/CheckBox.as | 4 +-
> .../royale/org/apache/royale/jewel/RadioButton.as | 4 +-
> .../main/royale/org/apache/royale/jewel/Slider.as | 2 +-
> .../royale/org/apache/royale/jewel/TextField.as | 2 +-
> .../JewelTheme/src/main/resources/defaults.css | 48
> +++++++++++-----------
> .../src/main/sass/components/_checkbox.sass | 4 +-
> .../src/main/sass/components/_radiobutton.sass | 4 +-
> .../src/main/sass/components/_slider.sass | 2 +-
> .../src/main/sass/components/_textfield.sass | 2 +-
> 11 files changed, 42 insertions(+), 39 deletions(-)
>
> diff --git a/examples/royale/JewelExample/src/main/
> resources/jewel-example-styles.css b/examples/royale/
> JewelExample/src/main/resources/jewel-example-styles.css
> index 003d6c8..c2ea379 100644
> --- a/examples/royale/JewelExample/src/main/resources/jewel-example-
> styles.css
> +++ b/examples/royale/JewelExample/src/main/resources/jewel-example-
> styles.css
> @@ -21,10 +21,13 @@
>
> @namespace "http://www.w3.org/1999/xhtml";
>
> -
> +body{
> + background: #fff;
> +}
>
> .container {
> background: #efefef;
> border-radius: 10px;
> padding: 20px;
> -}
> \ No newline at end of file
> +}
> +
> \ No newline at end of file
> diff --git a/examples/royale/JewelExample/src/main/royale/RadioButtonPlayGround.mxml
> b/examples/royale/JewelExample/src/main/royale/RadioButtonPlayGround.mxml
> index 3d34b18..9e6806d 100644
> --- a/examples/royale/JewelExample/src/main/royale/
> RadioButtonPlayGround.mxml
> +++ b/examples/royale/JewelExample/src/main/royale/
> RadioButtonPlayGround.mxml
> @@ -30,7 +30,7 @@ limitations under the License.
> <html:H3 text="Jewel RadioButton"/>
>
> <j:RadioButton text="RadioButton 1" groupName="radios" value="Test
> 1"/>
> - <j:RadioButton text="RadioButton 2" groupName="radios" value="Test
> 2"/>
> + <j:RadioButton text="RadioButton 2" groupName="radios" value="Test
> 2" selected="true"/>
> <j:RadioButton text="RadioButton 3" groupName="radios" value="Test
> 3"/>
>
> <j:RadioButton text="Disabled">
> diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/CheckBox.as
> b/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/CheckBox.as
> index d69fad6..5c78dbc 100644
> --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/CheckBox.as
> +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/CheckBox.as
> @@ -99,11 +99,11 @@ package org.apache.royale.jewel
>
> input = addElementToWrapper(this,'input') as
> HTMLInputElement;
> input.type = 'checkbox';
> - input.className = 'input';
> + //input.className = 'input';
> label.appendChild(input);
>
> checkbox = document.createElement('span') as HTMLSpanElement;
> - checkbox.className = 'span';
> + //checkbox.className = 'span';
> label.appendChild(checkbox);
>
> positioner = label as WrappedHTMLElement;
> diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/RadioButton.as
> b/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/RadioButton.as
> index 19d5981..b36b51a 100644
> --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/RadioButton.as
> +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/RadioButton.as
> @@ -316,14 +316,14 @@ package org.apache.royale.jewel
>
> icon = addElementToWrapper(this,'input') as HTMLInputElement;
> icon.type = "radio";
> - icon.className = 'input';
> + //icon.className = 'input';
> icon.id = '_radio_' + + Math.random();
> label.appendChild(icon);
>
> textNode = document.createTextNode('') as Text;
>
> radio = document.createElement('span') as HTMLSpanElement;
> - radio.className = 'span';
> + //radio.className = 'span';
> radio.appendChild(textNode);
> label.appendChild(radio);
> //radio.addEventListener('mouseover', mouseOverHandler,
> false);
> diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Slider.as
> b/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/Slider.as
> index 0cb0101..a9ddbbe 100644
> --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/Slider.as
> +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/Slider.as
> @@ -184,7 +184,7 @@ package org.apache.royale.jewel
>
> var input:HTMLInputElement = addElementToWrapper(this,'input')
> as HTMLInputElement;
> input.setAttribute('type', 'range');
> - input.className = "slider";
> + //input.className = "slider";
>
> //attach input handler to dispatch royale change
> event when user write in textinput
> //goog.events.listen(element, 'change', killChangeHandler);
> diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TextField.as
> b/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/TextField.as
> index 1c12711..a5d5c1c 100644
> --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/TextField.as
> +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/TextField.as
> @@ -82,7 +82,7 @@ package org.apache.royale.jewel
>
> input = addElementToWrapper(this,'input') as
> HTMLInputElement;
> input.setAttribute('type', 'text');
> - input.className = "input";
> + //input.className = "input";
>
> //attach input handler to dispatch royale change event when
> user write in textinput
> //goog.events.listen(element, 'change', killChangeHandler);
> diff --git a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> index 8f90431..e23ebd2 100644
> --- a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> +++ b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> @@ -196,7 +196,7 @@ div {
> width: 100%;
> height: 22px;
> }
> -.jewel.checkbox .input {
> +.jewel.checkbox input {
> -webkit-appearance: none;
> -moz-appearance: none;
> -o-appearance: none;
> @@ -212,26 +212,26 @@ div {
> border: 1px solid #b3b3b3;
> border-radius: 3px;
> }
> -.jewel.checkbox .input:checked, .jewel.checkbox .input:checked:active {
> +.jewel.checkbox input:checked, .jewel.checkbox input:checked:active {
> background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16 13'
> version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> transform='translate(-763, -290)'><g transform='translate(760,
> 285)'><g><polygon fill='#3CADF1' points='3 13 9 18 19 7 16 5 9 13 6
> 10'></polygon></g></g></g></svg>");
> background-repeat: no-repeat;
> background-size: 90%;
> background-position: center;
> background-attachment: fixed;
> }
> -.jewel.checkbox .input:focus {
> +.jewel.checkbox input:focus {
> outline: none;
> border: 1px solid #0f88d1;
> }
> -.jewel.checkbox .input[disabled] {
> +.jewel.checkbox input[disabled] {
> cursor: unset;
> border: 1px solid #c6c6c6;
> background: #F9F9F9;
> }
> -.jewel.checkbox .input[disabled] + .span {
> +.jewel.checkbox input[disabled] + .span {
> color: #c6c6c6;
> }
> -.jewel.checkbox .input[disabled]:checked {
> +.jewel.checkbox input[disabled]:checked {
> border: 1px solid #c6c6c6;
> background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16 13'
> version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> transform='translate(-763, -290)'><g transform='translate(760,
> 285)'><g><polygon fill='lightgray' points='3 13 9 18 19 7 16 5 9 13 6
> 10'></polygon></g></g></g></svg>");
> background-size: 90%;
> @@ -239,7 +239,7 @@ div {
> background-repeat: no-repeat;
> background-attachment: fixed;
> }
> -.jewel.checkbox .span {
> +.jewel.checkbox span {
> cursor: pointer;
> position: absolute;
> margin: 0;
> @@ -262,7 +262,7 @@ div {
> width: 100%;
> height: 22px;
> }
> -.jewel.radiobutton .input {
> +.jewel.radiobutton input {
> -webkit-appearance: none;
> -moz-appearance: none;
> -o-appearance: none;
> @@ -278,26 +278,26 @@ div {
> border: 1px solid #b3b3b3;
> border-radius: 50%;
> }
> -.jewel.radiobutton .input:checked, .jewel.radiobutton
> .input:checked:active {
> +.jewel.radiobutton input:checked, .jewel.radiobutton input:checked:active
> {
> background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12 12'
> version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> transform='translate(-616, -350)'><g transform='translate(611,
> 345)'><g><circle fill='#3CADF1' cx='11' cy='11'
> r='6'></circle></g></g></g></svg>");
> background-repeat: no-repeat;
> background-size: 60%;
> background-position: center;
> background-attachment: fixed;
> }
> -.jewel.radiobutton .input:focus {
> +.jewel.radiobutton input:focus {
> outline: none;
> border: 1px solid #0f88d1;
> }
> -.jewel.radiobutton .input[disabled] {
> +.jewel.radiobutton input[disabled] {
> cursor: unset;
> border: 1px solid #c6c6c6;
> background: #F9F9F9;
> }
> -.jewel.radiobutton .input[disabled] + .span {
> +.jewel.radiobutton input[disabled] + .span {
> color: #c6c6c6;
> }
> -.jewel.radiobutton .input[disabled]:checked {
> +.jewel.radiobutton input[disabled]:checked {
> border: 1px solid #c6c6c6;
> background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12 12'
> version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> transform='translate(-616, -350)'><g transform='translate(611,
> 345)'><g><circle fill='lightgray' cx='11' cy='11'
> r='6'></circle></g></g></g></svg>");
> background-size: 60%;
> @@ -305,7 +305,7 @@ div {
> background-repeat: no-repeat;
> background-attachment: fixed;
> }
> -.jewel.radiobutton .span {
> +.jewel.radiobutton span {
> cursor: pointer;
> position: absolute;
> margin: 0;
> @@ -314,7 +314,7 @@ div {
> line-height: 22px;
> }
>
> -.jewel.slider .slider {
> +.jewel.slider input {
> -webkit-appearance: none;
> width: 100%;
> height: 15px;
> @@ -325,13 +325,13 @@ div {
> -webkit-transition: 0.2s;
> transition: opacity 0.2s;
> }
> -.jewel.slider .slider:hover {
> +.jewel.slider input:hover {
> opacity: 1;
> }
> -.jewel.slider .slider:focus {
> +.jewel.slider input:focus {
> outline: none;
> }
> -.jewel.slider .slider::-webkit-slider-thumb {
> +.jewel.slider input::-webkit-slider-thumb {
> -webkit-appearance: none;
> appearance: none;
> width: 15px;
> @@ -340,7 +340,7 @@ div {
> background: #3CADF1;
> cursor: pointer;
> }
> -.jewel.slider .slider::-moz-range-thumb {
> +.jewel.slider input::-moz-range-thumb {
> width: 15px;
> height: 15px;
> border-radius: 50%;
> @@ -523,7 +523,7 @@ div {
> position: relative;
> display: inline-flex;
> }
> -.jewel.textfield .input {
> +.jewel.textfield input {
> margin: 0;
> padding: 0.67em 1em;
> max-width: 100%;
> @@ -542,20 +542,20 @@ div {
> transition-duration: 0.3s;
> transition-timing-function: easein;
> }
> -.jewel.textfield .input:focus {
> +.jewel.textfield input:focus {
> border: 1px solid #0f88d1;
> }
> -.jewel.textfield .input::placeholder {
> +.jewel.textfield input::placeholder {
> color: #a6a6a6;
> }
> -.jewel.textfield .input[disabled] {
> +.jewel.textfield input[disabled] {
> cursor: unset;
> border: 1px solid #c6c6c6;
> background: #F9F9F9;
> box-shadow: none;
> color: #c6c6c6;
> }
> -.jewel.textfield .input[disabled]::placeholder {
> +.jewel.textfield input[disabled]::placeholder {
> color: #c6c6c6;
> }
>
> diff --git a/frameworks/themes/JewelTheme/src/main/sass/components/_checkbox.sass
> b/frameworks/themes/JewelTheme/src/main/sass/components/_checkbox.sass
> index e79c952..92f4fd0 100644
> --- a/frameworks/themes/JewelTheme/src/main/sass/components/_checkbox.sass
> +++ b/frameworks/themes/JewelTheme/src/main/sass/components/_checkbox.sass
> @@ -39,7 +39,7 @@ $checkbox-label-font-size: 16px
> height: $checkbox-button-size
>
> // -- INPUT
> - .input
> + input
> +appear(none)
> cursor: pointer
> display: inline-block
> @@ -102,7 +102,7 @@ $checkbox-label-font-size: 16px
> //background: $disabled-color
>
> // -- LABEL
> - .span
> + span
> cursor: pointer
> position: absolute
> margin: 0
> diff --git a/frameworks/themes/JewelTheme/src/main/sass/components/_radiobutton.sass
> b/frameworks/themes/JewelTheme/src/main/sass/components/_radiobutton.sass
> index a224f28..d45a56a 100644
> --- a/frameworks/themes/JewelTheme/src/main/sass/
> components/_radiobutton.sass
> +++ b/frameworks/themes/JewelTheme/src/main/sass/
> components/_radiobutton.sass
> @@ -39,7 +39,7 @@ $radiobutton-label-font-size: 16px
> height: $radiobutton-button-size
>
> // -- INPUT
> - .input
> + input
> +appear(none)
> cursor: pointer
> display: inline-block
> @@ -93,7 +93,7 @@ $radiobutton-label-font-size: 16px
> background-attachment: fixed
>
> // -- LABEL
> - .span
> + span
> cursor: pointer
> position: absolute
> margin: 0
> diff --git a/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> index f92fdd0..115df2c 100644
> --- a/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> +++ b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> @@ -19,7 +19,7 @@
>
> .jewel.slider
>
> - .slider
> + input
> -webkit-appearance: none
> width: 100%
> height: 15px
> diff --git a/frameworks/themes/JewelTheme/src/main/sass/components/_textfield.sass
> b/frameworks/themes/JewelTheme/src/main/sass/components/_textfield.sass
> index 4165f6d..3e04d9a 100644
> --- a/frameworks/themes/JewelTheme/src/main/sass/
> components/_textfield.sass
> +++ b/frameworks/themes/JewelTheme/src/main/sass/
> components/_textfield.sass
> @@ -32,7 +32,7 @@ $textfield-border-radius: 3px
> position: relative
> display: inline-flex
>
> - .input
> + input
> margin: $textfield-margin
> padding: $textfield-padding
>
>
> --
> To stop receiving notification emails like this one, please contact
> carlosrovira@apache.org.
>
--
Piotr Zarzycki
Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*
Re: [royale-asjs] branch feature/jewel-ui-set updated: removes
workaround for element styles thanks to bugs #30/#32 solved
Posted by Carlos Rovira <ca...@apache.org>.
For me is ok, although I use to push directly when commit, so I hardly
could do an amend always will do the latter commit Alex propose.
thanks
2018-03-27 22:12 GMT+02:00 Alex Harui <ah...@adobe.com.invalid>:
> This post [1] implies that it is not allowed in the Linux Kernel repos.
> This post [2] also warns of danger
>
> My takeaway is that --amend is ok before you push. Instead, we could
> adopt a convention, like changing some dummy file or README or
> RELEASE_NOTES or one of the actual files and using a commit message that
> says "Commit hash <hash> should also contain message <message>".
>
> Thoughts?
> -Alex
>
> [1]
> https://stackoverflow.com/questions/457379/how-do-i-
> edit-an-incorrect-commi
> t-message-in-git-that-ive-pushed/457396#457396
> [2]
> https://stackoverflow.com/questions/8981194/changing-
> git-commit-message-aft
> er-push-given-that-no-one-pulled-from-remote
>
>
> On 3/27/18, 11:33 AM, "Piotr Zarzycki" <pi...@gmail.com> wrote:
>
> >Hi Alex,
> >
> >I didn't know that could be unsafe. I did it by amend.
> >If you see some article from a good source share here.
> >
> >Thanks,
> >Piotr
> >
> >On Tue, Mar 27, 2018, 20:04 Carlos Rovira <ca...@apache.org>
> wrote:
> >
> >> I think other way to do this with an "amend" command? (at least to add
> >> forgotten content to a commit..
> >>
> >> 2018-03-27 18:18 GMT+02:00 Alex Harui <ah...@adobe.com.invalid>:
> >>
> >> > Hi Piotr,
> >> >
> >> > Are you sure it is safe to change commit messages? I see some
> >>articles
> >> > saying that it is unsafe.
> >> >
> >> > Thoughts?
> >> > -Alex
> >> >
> >> > On 3/27/18, 1:26 AM, "Piotr Zarzycki" <pi...@gmail.com>
> >>wrote:
> >> >
> >> > >I just pushed changes -> Checkout how it looks like now ->
> >> > >https://na01.safelinks.protection.outlook.com/?url=
> >> > https%3A%2F%2Fgithub.co
> >> > >m%2Fapache%2Froyale-asjs%2Fcommit%2Fdf9808dc6ad261d33e58715c4644
> >> > 8a1da5ee50
> >> > >ad&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74ff0dad608d593bc
> >> > 75c4%7C
> >> > >fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636577359996677198&sdata=
> >> > agZM7t
> >> > >aOsrP2Zy99%2FP5iwKwWfCqeucpm5PNmC6fbQmg%3D&reserved=0
> >> > >
> >> > >2018-03-27 10:22 GMT+02:00 Piotr Zarzycki
> >><pi...@gmail.com>:
> >> > >
> >> > >> I will change message in your last commit. Yes that is how are you
> >> > >>linking
> >> > >> to the other repository. If it will be in typedefs you will do:
> >> > >> apache/royale-typedefs#number
> >> > >>
> >> > >> 2018-03-27 10:17 GMT+02:00 Carlos Rovira <carlosrovira@apache.org
> >:
> >> > >>
> >> > >>> Hi Piotr,
> >> > >>> thanks! I didn't realize that it's not the same repo, so for
> >> compiler I
> >> > >>> must put "apache/royale-compiler#<number>" ? Thanks, I'll do the
> >>next
> >> > >>> time!
> >> > >>> :)
> >> > >>>
> >> > >>> 2018-03-27 10:13 GMT+02:00 Piotr Zarzycki
> >><piotrzarzycki21@gmail.com
> >> >:
> >> > >>>
> >> > >>> > Hi Carlos,
> >> > >>> >
> >> > >>> > And again if you add in the description
> >>apache/royale-compiler#30
> >> and
> >> > >>> > apache/royale-compiler#32 it will point to the proper issue.
> >>Now
> >> you
> >> > >>> are
> >> > >>> > pointing to some closed issue in asjs which is totally
> >>unrelated.
> >> > >>> >
> >> > >>> > Thanks,
> >> > >>> > Piotr
> >> > >>> >
> >> > >>> > 2018-03-27 10:02 GMT+02:00 <ca...@apache.org>:
> >> > >>> >
> >> > >>> > > This is an automated email from the ASF dual-hosted git
> >> repository.
> >> > >>> > >
> >> > >>> > > carlosrovira pushed a commit to branch feature/jewel-ui-set
> >> > >>> > > in repository
> >> > >>>
> >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox
> >> > .
> >> > >>>apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%
> >> > 7C01%7Caharui%40adobe
> >> >
> >>>>>.com%7Ca45baaa226d74ff0dad608d593bc75c4%
> 7Cfa7b1b5a7b34438794aed2c178de
> >> > ce
> >> >
> >>>>>e1%7C0%7C0%7C636577359996677198&sdata=D3YDt7MXbmAhxG4D4zhxH2Hdrx8HtX
> >> > mhWf
> >> > >>>FL4704jOA%3D&reserved=0
> >> > >>> > >
> >> > >>> > >
> >> > >>> > > The following commit(s) were added to
> >> > >>>refs/heads/feature/jewel-ui-set
> >> > >>> by
> >> > >>> > > this push:
> >> > >>> > > new 10d993c removes workaround for element styles
> >>thanks to
> >> > >>>bugs
> >> > >>> > > #30/#32 solved
> >> > >>> > > 10d993c is described below
> >> > >>> > >
> >> > >>> > > commit 10d993c21ef554019a249a8355e007adbab07ca8
> >> > >>> > > Author: Carlos Rovira <ca...@apache.org>
> >> > >>> > > AuthorDate: Tue Mar 27 10:02:00 2018 +0200
> >> > >>> > >
> >> > >>> > > removes workaround for element styles thanks to bugs
> >>#30/#32
> >> > >>> solved
> >> > >>> > > ---
> >> > >>> > > .../src/main/resources/jewel-example-styles.css | 7 +++-
> >> > >>> > > .../src/main/royale/RadioButtonPlayGround.mxml | 2 +-
> >> > >>> > > .../royale/org/apache/royale/jewel/CheckBox.as | 4 +-
> >> > >>> > > .../royale/org/apache/royale/jewel/RadioButton.as | 4 +-
> >> > >>> > > .../main/royale/org/apache/royale/jewel/Slider.as | 2 +-
> >> > >>> > > .../royale/org/apache/royale/jewel/TextField.as | 2 +-
> >> > >>> > > .../JewelTheme/src/main/resources/defaults.css | 48
> >> > >>> > > +++++++++++-----------
> >> > >>> > > .../src/main/sass/components/_checkbox.sass | 4 +-
> >> > >>> > > .../src/main/sass/components/_radiobutton.sass | 4 +-
> >> > >>> > > .../src/main/sass/components/_slider.sass | 2 +-
> >> > >>> > > .../src/main/sass/components/_textfield.sass | 2 +-
> >> > >>> > > 11 files changed, 42 insertions(+), 39 deletions(-)
> >> > >>> > >
> >> > >>> > > diff --git a/examples/royale/JewelExample/src/main/
> >> > >>> > > resources/jewel-example-styles.css b/examples/royale/
> >> > >>> > > JewelExample/src/main/resources/jewel-example-styles.css
> >> > >>> > > index 003d6c8..c2ea379 100644
> >> > >>> > > ---
> >> > >>>a/examples/royale/JewelExample/src/main/resources/jewel-example-
> >> > >>> > > styles.css
> >> > >>> > > +++
> >> > >>>b/examples/royale/JewelExample/src/main/resources/jewel-example-
> >> > >>> > > styles.css
> >> > >>> > > @@ -21,10 +21,13 @@
> >> > >>> > >
> >> > >>> > > @namespace
> >> > >>>"
> >> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.w3
> >> > .
> >> > >>>org%2F1999%2Fxhtml&data=02%7C01%7Caharui%40adobe.com%
> >> > 7Ca45baaa226d74ff0d
> >> > >>>ad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C63657735999
> >> > >>>6677198&sdata=hCL1lfhr1M7AHjRbVVHmuupkJGR1nh
> >> > 2m5GSh0skwrAk%3D&reserved=0"
> >> > >>>;
> >> > >>> > >
> >> > >>> > > -
> >> > >>> > > +body{
> >> > >>> > > + background: #fff;
> >> > >>> > > +}
> >> > >>> > >
> >> > >>> > > .container {
> >> > >>> > > background: #efefef;
> >> > >>> > > border-radius: 10px;
> >> > >>> > > padding: 20px;
> >> > >>> > > -}
> >> > >>> > > \ No newline at end of file
> >> > >>> > > +}
> >> > >>> > > +
> >> > >>> > > \ No newline at end of file
> >> > >>> > > diff --git a/examples/royale/JewelExample/src/main/royale/
> >> > >>> > RadioButtonPlayGround.mxml
> >> > >>> > > b/examples/royale/JewelExample/src/main/royale/
> >> > >>> > RadioButtonPlayGround.mxml
> >> > >>> > > index 3d34b18..9e6806d 100644
> >> > >>> > > --- a/examples/royale/JewelExample/src/main/royale/
> >> > >>> > > RadioButtonPlayGround.mxml
> >> > >>> > > +++ b/examples/royale/JewelExample/src/main/royale/
> >> > >>> > > RadioButtonPlayGround.mxml
> >> > >>> > > @@ -30,7 +30,7 @@ limitations under the License.
> >> > >>> > > <html:H3 text="Jewel RadioButton"/>
> >> > >>> > >
> >> > >>> > > <j:RadioButton text="RadioButton 1" groupName="radios"
> >> > >>> > value="Test
> >> > >>> > > 1"/>
> >> > >>> > > - <j:RadioButton text="RadioButton 2" groupName="radios"
> >> > >>> > value="Test
> >> > >>> > > 2"/>
> >> > >>> > > + <j:RadioButton text="RadioButton 2" groupName="radios"
> >> > >>> > value="Test
> >> > >>> > > 2" selected="true"/>
> >> > >>> > > <j:RadioButton text="RadioButton 3" groupName="radios"
> >> > >>> > value="Test
> >> > >>> > > 3"/>
> >> > >>> > >
> >> > >>> > > <j:RadioButton text="Disabled">
> >> > >>> > > diff --git
> >> a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > royale/jewel/CheckBox.as
> >> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/CheckBox.as
> >> > >>> > > index d69fad6..5c78dbc 100644
> >> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/CheckBox.as
> >> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/CheckBox.as
> >> > >>> > > @@ -99,11 +99,11 @@ package org.apache.royale.jewel
> >> > >>> > >
> >> > >>> > > input = addElementToWrapper(this,'input') as
> >> > >>> > > HTMLInputElement;
> >> > >>> > > input.type = 'checkbox';
> >> > >>> > > - input.className = 'input';
> >> > >>> > > + //input.className = 'input';
> >> > >>> > > label.appendChild(input);
> >> > >>> > >
> >> > >>> > > checkbox = document.createElement('span') as
> >> > >>> > HTMLSpanElement;
> >> > >>> > > - checkbox.className = 'span';
> >> > >>> > > + //checkbox.className = 'span';
> >> > >>> > > label.appendChild(checkbox);
> >> > >>> > >
> >> > >>> > > positioner = label as WrappedHTMLElement;
> >> > >>> > > diff --git
> >> a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > royale/jewel/RadioButton.as
> >> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/RadioButton.as
> >> > >>> > > index 19d5981..b36b51a 100644
> >> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/RadioButton.as
> >> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/RadioButton.as
> >> > >>> > > @@ -316,14 +316,14 @@ package org.apache.royale.jewel
> >> > >>> > >
> >> > >>> > > icon = addElementToWrapper(this,'input') as
> >> > >>> > HTMLInputElement;
> >> > >>> > > icon.type = "radio";
> >> > >>> > > - icon.className = 'input';
> >> > >>> > > + //icon.className = 'input';
> >> > >>> > > icon.id = '_radio_' + + Math.random();
> >> > >>> > > label.appendChild(icon);
> >> > >>> > >
> >> > >>> > > textNode = document.createTextNode('') as Text;
> >> > >>> > >
> >> > >>> > > radio = document.createElement('span') as
> >> > >>> HTMLSpanElement;
> >> > >>> > > - radio.className = 'span';
> >> > >>> > > + //radio.className = 'span';
> >> > >>> > > radio.appendChild(textNode);
> >> > >>> > > label.appendChild(radio);
> >> > >>> > > //radio.addEventListener('mouseover',
> >> > >>>mouseOverHandler,
> >> > >>> > > false);
> >> > >>> > > diff --git
> >> a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > royale/jewel/Slider.as
> >> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/Slider.as
> >> > >>> > > index 0cb0101..a9ddbbe 100644
> >> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/Slider.as
> >> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/Slider.as
> >> > >>> > > @@ -184,7 +184,7 @@ package org.apache.royale.jewel
> >> > >>> > >
> >> > >>> > > var input:HTMLInputElement =
> >> > >>>addElementToWrapper(this,'
> >> > >>> > input')
> >> > >>> > > as HTMLInputElement;
> >> > >>> > > input.setAttribute('type', 'range');
> >> > >>> > > - input.className = "slider";
> >> > >>> > > + //input.className = "slider";
> >> > >>> > >
> >> > >>> > > //attach input handler to dispatch
> >>royale
> >> > >>> change
> >> > >>> > > event when user write in textinput
> >> > >>> > > //goog.events.listen(element, 'change',
> >> > >>> killChangeHandler);
> >> > >>> > > diff --git
> >> a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > royale/jewel/TextField.as
> >> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/TextField.as
> >> > >>> > > index 1c12711..a5d5c1c 100644
> >> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/TextField.as
> >> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >> > >>> > > royale/jewel/TextField.as
> >> > >>> > > @@ -82,7 +82,7 @@ package org.apache.royale.jewel
> >> > >>> > >
> >> > >>> > > input = addElementToWrapper(this,'input') as
> >> > >>> > > HTMLInputElement;
> >> > >>> > > input.setAttribute('type', 'text');
> >> > >>> > > - input.className = "input";
> >> > >>> > > + //input.className = "input";
> >> > >>> > >
> >> > >>> > > //attach input handler to dispatch royale change
> >> event
> >> > >>> when
> >> > >>> > > user write in textinput
> >> > >>> > > //goog.events.listen(element, 'change',
> >> > >>> killChangeHandler);
> >> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/resources/
> >> > >>> > defaults.css
> >> > >>> > > b/frameworks/themes/JewelTheme/src/main/resources/
> defaults.css
> >> > >>> > > index 8f90431..e23ebd2 100644
> >> > >>> > > ---
> >> a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> >> > >>> > > +++
> >> b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> >> > >>> > > @@ -196,7 +196,7 @@ div {
> >> > >>> > > width: 100%;
> >> > >>> > > height: 22px;
> >> > >>> > > }
> >> > >>> > > -.jewel.checkbox .input {
> >> > >>> > > +.jewel.checkbox input {
> >> > >>> > > -webkit-appearance: none;
> >> > >>> > > -moz-appearance: none;
> >> > >>> > > -o-appearance: none;
> >> > >>> > > @@ -212,26 +212,26 @@ div {
> >> > >>> > > border: 1px solid #b3b3b3;
> >> > >>> > > border-radius: 3px;
> >> > >>> > > }
> >> > >>> > > -.jewel.checkbox .input:checked, .jewel.checkbox
> >> > >>> .input:checked:active {
> >> > >>> > > +.jewel.checkbox input:checked, .jewel.checkbox
> >> > >>>input:checked:active {
> >> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0
> >>16
> >> > >>>13'
> >> > >>> > > version='1.1'
> >> >
> >>>>>xmlns='https://na01.safelinks.protection.outlook.
> com/?url=https%3A%2F%
> >>>>>2Fna01.safelinks.protection.outlook&data=02%7C01%7Caharui%40adobe.com
> %
> >>>>>7C7e5bcc761c784beadb7c08d594115965%7Cfa7b1b5a7b34438794aed2c178de
> cee1%
> >>>>>7C0%7C0%7C636577724600139244&sdata=Lut9lYckLkGTPjZP%2FwXYIr9ZCb%
> 2BTvEl
> >>>>>WdIG0JeKrqx8%3D&reserved=0.
> >> > com/?url=http%3A%2F%2Fw
> >> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> >> > %7Ca45baaa226d74
> >> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C6365773
> >> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> >> > 3D&reser
> >> > >>>ved=0'><g
> >> > >>> > > transform='translate(-763, -290)'><g transform='translate(760,
> >> > >>> > > 285)'><g><polygon fill='#3CADF1' points='3 13 9 18 19 7 16 5 9
> >> 13 6
> >> > >>> > > 10'></polygon></g></g></g></svg>");
> >> > >>> > > background-repeat: no-repeat;
> >> > >>> > > background-size: 90%;
> >> > >>> > > background-position: center;
> >> > >>> > > background-attachment: fixed;
> >> > >>> > > }
> >> > >>> > > -.jewel.checkbox .input:focus {
> >> > >>> > > +.jewel.checkbox input:focus {
> >> > >>> > > outline: none;
> >> > >>> > > border: 1px solid #0f88d1;
> >> > >>> > > }
> >> > >>> > > -.jewel.checkbox .input[disabled] {
> >> > >>> > > +.jewel.checkbox input[disabled] {
> >> > >>> > > cursor: unset;
> >> > >>> > > border: 1px solid #c6c6c6;
> >> > >>> > > background: #F9F9F9;
> >> > >>> > > }
> >> > >>> > > -.jewel.checkbox .input[disabled] + .span {
> >> > >>> > > +.jewel.checkbox input[disabled] + .span {
> >> > >>> > > color: #c6c6c6;
> >> > >>> > > }
> >> > >>> > > -.jewel.checkbox .input[disabled]:checked {
> >> > >>> > > +.jewel.checkbox input[disabled]:checked {
> >> > >>> > > border: 1px solid #c6c6c6;
> >> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0
> >>16
> >> > >>>13'
> >> > >>> > > version='1.1'
> >> >
> >>>>>xmlns='https://na01.safelinks.protection.outlook.
> com/?url=https%3A%2F%
> >>>>>2Fna01.safelinks.protection.outlook&data=02%7C01%7Caharui%40adobe.com
> %
> >>>>>7C7e5bcc761c784beadb7c08d594115965%7Cfa7b1b5a7b34438794aed2c178de
> cee1%
> >>>>>7C0%7C0%7C636577724600139244&sdata=Lut9lYckLkGTPjZP%2FwXYIr9ZCb%
> 2BTvEl
> >>>>>WdIG0JeKrqx8%3D&reserved=0.
> >> > com/?url=http%3A%2F%2Fw
> >> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> >> > %7Ca45baaa226d74
> >> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C6365773
> >> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> >> > 3D&reser
> >> > >>>ved=0'><g
> >> > >>> > > transform='translate(-763, -290)'><g transform='translate(760,
> >> > >>> > > 285)'><g><polygon fill='lightgray' points='3 13 9 18 19 7 16
> >>5 9
> >> > >>>13 6
> >> > >>> > > 10'></polygon></g></g></g></svg>");
> >> > >>> > > background-size: 90%;
> >> > >>> > > @@ -239,7 +239,7 @@ div {
> >> > >>> > > background-repeat: no-repeat;
> >> > >>> > > background-attachment: fixed;
> >> > >>> > > }
> >> > >>> > > -.jewel.checkbox .span {
> >> > >>> > > +.jewel.checkbox span {
> >> > >>> > > cursor: pointer;
> >> > >>> > > position: absolute;
> >> > >>> > > margin: 0;
> >> > >>> > > @@ -262,7 +262,7 @@ div {
> >> > >>> > > width: 100%;
> >> > >>> > > height: 22px;
> >> > >>> > > }
> >> > >>> > > -.jewel.radiobutton .input {
> >> > >>> > > +.jewel.radiobutton input {
> >> > >>> > > -webkit-appearance: none;
> >> > >>> > > -moz-appearance: none;
> >> > >>> > > -o-appearance: none;
> >> > >>> > > @@ -278,26 +278,26 @@ div {
> >> > >>> > > border: 1px solid #b3b3b3;
> >> > >>> > > border-radius: 50%;
> >> > >>> > > }
> >> > >>> > > -.jewel.radiobutton .input:checked, .jewel.radiobutton
> >> > >>> > > .input:checked:active {
> >> > >>> > > +.jewel.radiobutton input:checked, .jewel.radiobutton
> >> > >>> > input:checked:active
> >> > >>> > > {
> >> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0
> >>12
> >> > >>>12'
> >> > >>> > > version='1.1'
> >> >
> >>>>>xmlns='https://na01.safelinks.protection.outlook.
> com/?url=https%3A%2F%
> >>>>>2Fna01.safelinks.protection.outlook&data=02%7C01%7Caharui%40adobe.com
> %
> >>>>>7C7e5bcc761c784beadb7c08d594115965%7Cfa7b1b5a7b34438794aed2c178de
> cee1%
> >>>>>7C0%7C0%7C636577724600139244&sdata=Lut9lYckLkGTPjZP%2FwXYIr9ZCb%
> 2BTvEl
> >>>>>WdIG0JeKrqx8%3D&reserved=0.
> >> > com/?url=http%3A%2F%2Fw
> >> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> >> > %7Ca45baaa226d74
> >> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C6365773
> >> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> >> > 3D&reser
> >> > >>>ved=0'><g
> >> > >>> > > transform='translate(-616, -350)'><g transform='translate(611,
> >> > >>> > > 345)'><g><circle fill='#3CADF1' cx='11' cy='11'
> >> > >>> > > r='6'></circle></g></g></g></svg>");
> >> > >>> > > background-repeat: no-repeat;
> >> > >>> > > background-size: 60%;
> >> > >>> > > background-position: center;
> >> > >>> > > background-attachment: fixed;
> >> > >>> > > }
> >> > >>> > > -.jewel.radiobutton .input:focus {
> >> > >>> > > +.jewel.radiobutton input:focus {
> >> > >>> > > outline: none;
> >> > >>> > > border: 1px solid #0f88d1;
> >> > >>> > > }
> >> > >>> > > -.jewel.radiobutton .input[disabled] {
> >> > >>> > > +.jewel.radiobutton input[disabled] {
> >> > >>> > > cursor: unset;
> >> > >>> > > border: 1px solid #c6c6c6;
> >> > >>> > > background: #F9F9F9;
> >> > >>> > > }
> >> > >>> > > -.jewel.radiobutton .input[disabled] + .span {
> >> > >>> > > +.jewel.radiobutton input[disabled] + .span {
> >> > >>> > > color: #c6c6c6;
> >> > >>> > > }
> >> > >>> > > -.jewel.radiobutton .input[disabled]:checked {
> >> > >>> > > +.jewel.radiobutton input[disabled]:checked {
> >> > >>> > > border: 1px solid #c6c6c6;
> >> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0
> >>12
> >> > >>>12'
> >> > >>> > > version='1.1'
> >> >
> >>>>>xmlns='https://na01.safelinks.protection.outlook.
> com/?url=https%3A%2F%
> >>>>>2Fna01.safelinks.protection.outlook&data=02%7C01%7Caharui%40adobe.com
> %
> >>>>>7C7e5bcc761c784beadb7c08d594115965%7Cfa7b1b5a7b34438794aed2c178de
> cee1%
> >>>>>7C0%7C0%7C636577724600139244&sdata=Lut9lYckLkGTPjZP%2FwXYIr9ZCb%
> 2BTvEl
> >>>>>WdIG0JeKrqx8%3D&reserved=0.
> >> > com/?url=http%3A%2F%2Fw
> >> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> >> > %7Ca45baaa226d74
> >> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C6365773
> >> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> >> > 3D&reser
> >> > >>>ved=0'><g
> >> > >>> > > transform='translate(-616, -350)'><g transform='translate(611,
> >> > >>> > > 345)'><g><circle fill='lightgray' cx='11' cy='11'
> >> > >>> > > r='6'></circle></g></g></g></svg>");
> >> > >>> > > background-size: 60%;
> >> > >>> > > @@ -305,7 +305,7 @@ div {
> >> > >>> > > background-repeat: no-repeat;
> >> > >>> > > background-attachment: fixed;
> >> > >>> > > }
> >> > >>> > > -.jewel.radiobutton .span {
> >> > >>> > > +.jewel.radiobutton span {
> >> > >>> > > cursor: pointer;
> >> > >>> > > position: absolute;
> >> > >>> > > margin: 0;
> >> > >>> > > @@ -314,7 +314,7 @@ div {
> >> > >>> > > line-height: 22px;
> >> > >>> > > }
> >> > >>> > >
> >> > >>> > > -.jewel.slider .slider {
> >> > >>> > > +.jewel.slider input {
> >> > >>> > > -webkit-appearance: none;
> >> > >>> > > width: 100%;
> >> > >>> > > height: 15px;
> >> > >>> > > @@ -325,13 +325,13 @@ div {
> >> > >>> > > -webkit-transition: 0.2s;
> >> > >>> > > transition: opacity 0.2s;
> >> > >>> > > }
> >> > >>> > > -.jewel.slider .slider:hover {
> >> > >>> > > +.jewel.slider input:hover {
> >> > >>> > > opacity: 1;
> >> > >>> > > }
> >> > >>> > > -.jewel.slider .slider:focus {
> >> > >>> > > +.jewel.slider input:focus {
> >> > >>> > > outline: none;
> >> > >>> > > }
> >> > >>> > > -.jewel.slider .slider::-webkit-slider-thumb {
> >> > >>> > > +.jewel.slider input::-webkit-slider-thumb {
> >> > >>> > > -webkit-appearance: none;
> >> > >>> > > appearance: none;
> >> > >>> > > width: 15px;
> >> > >>> > > @@ -340,7 +340,7 @@ div {
> >> > >>> > > background: #3CADF1;
> >> > >>> > > cursor: pointer;
> >> > >>> > > }
> >> > >>> > > -.jewel.slider .slider::-moz-range-thumb {
> >> > >>> > > +.jewel.slider input::-moz-range-thumb {
> >> > >>> > > width: 15px;
> >> > >>> > > height: 15px;
> >> > >>> > > border-radius: 50%;
> >> > >>> > > @@ -523,7 +523,7 @@ div {
> >> > >>> > > position: relative;
> >> > >>> > > display: inline-flex;
> >> > >>> > > }
> >> > >>> > > -.jewel.textfield .input {
> >> > >>> > > +.jewel.textfield input {
> >> > >>> > > margin: 0;
> >> > >>> > > padding: 0.67em 1em;
> >> > >>> > > max-width: 100%;
> >> > >>> > > @@ -542,20 +542,20 @@ div {
> >> > >>> > > transition-duration: 0.3s;
> >> > >>> > > transition-timing-function: easein;
> >> > >>> > > }
> >> > >>> > > -.jewel.textfield .input:focus {
> >> > >>> > > +.jewel.textfield input:focus {
> >> > >>> > > border: 1px solid #0f88d1;
> >> > >>> > > }
> >> > >>> > > -.jewel.textfield .input::placeholder {
> >> > >>> > > +.jewel.textfield input::placeholder {
> >> > >>> > > color: #a6a6a6;
> >> > >>> > > }
> >> > >>> > > -.jewel.textfield .input[disabled] {
> >> > >>> > > +.jewel.textfield input[disabled] {
> >> > >>> > > cursor: unset;
> >> > >>> > > border: 1px solid #c6c6c6;
> >> > >>> > > background: #F9F9F9;
> >> > >>> > > box-shadow: none;
> >> > >>> > > color: #c6c6c6;
> >> > >>> > > }
> >> > >>> > > -.jewel.textfield .input[disabled]::placeholder {
> >> > >>> > > +.jewel.textfield input[disabled]::placeholder {
> >> > >>> > > color: #c6c6c6;
> >> > >>> > > }
> >> > >>> > >
> >> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > components/_checkbox.sass
> >> > >>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
> >> > >>> checkbox.sass
> >> > >>> > > index e79c952..92f4fd0 100644
> >> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > components/_checkbox.sass
> >> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > components/_checkbox.sass
> >> > >>> > > @@ -39,7 +39,7 @@ $checkbox-label-font-size: 16px
> >> > >>> > > height: $checkbox-button-size
> >> > >>> > >
> >> > >>> > > // -- INPUT
> >> > >>> > > - .input
> >> > >>> > > + input
> >> > >>> > > +appear(none)
> >> > >>> > > cursor: pointer
> >> > >>> > > display: inline-block
> >> > >>> > > @@ -102,7 +102,7 @@ $checkbox-label-font-size: 16px
> >> > >>> > > //background: $disabled-color
> >> > >>> > >
> >> > >>> > > // -- LABEL
> >> > >>> > > - .span
> >> > >>> > > + span
> >> > >>> > > cursor: pointer
> >> > >>> > > position: absolute
> >> > >>> > > margin: 0
> >> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > components/_radiobutton.sass
> >> > >>> > > b/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > components/_radiobutton.sass
> >> > >>> > > index a224f28..d45a56a 100644
> >> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > > components/_radiobutton.sass
> >> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > > components/_radiobutton.sass
> >> > >>> > > @@ -39,7 +39,7 @@ $radiobutton-label-font-size: 16px
> >> > >>> > > height: $radiobutton-button-size
> >> > >>> > >
> >> > >>> > > // -- INPUT
> >> > >>> > > - .input
> >> > >>> > > + input
> >> > >>> > > +appear(none)
> >> > >>> > > cursor: pointer
> >> > >>> > > display: inline-block
> >> > >>> > > @@ -93,7 +93,7 @@ $radiobutton-label-font-size: 16px
> >> > >>> > > background-attachment: fixed
> >> > >>> > >
> >> > >>> > > // -- LABEL
> >> > >>> > > - .span
> >> > >>> > > + span
> >> > >>> > > cursor: pointer
> >> > >>> > > position: absolute
> >> > >>> > > margin: 0
> >> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > components/_slider.sass
> >> > >>> > >
> >> >
> >>>>>b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> >> > >>> > > index f92fdd0..115df2c 100644
> >> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/components/_
> >> > >>> slider.sass
> >> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/components/_
> >> > >>> slider.sass
> >> > >>> > > @@ -19,7 +19,7 @@
> >> > >>> > >
> >> > >>> > > .jewel.slider
> >> > >>> > >
> >> > >>> > > - .slider
> >> > >>> > > + input
> >> > >>> > > -webkit-appearance: none
> >> > >>> > > width: 100%
> >> > >>> > > height: 15px
> >> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > components/_textfield.sass
> >> > >>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
> >> > >>> textfield.sass
> >> > >>> > > index 4165f6d..3e04d9a 100644
> >> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > > components/_textfield.sass
> >> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> >> > >>> > > components/_textfield.sass
> >> > >>> > > @@ -32,7 +32,7 @@ $textfield-border-radius: 3px
> >> > >>> > > position: relative
> >> > >>> > > display: inline-flex
> >> > >>> > >
> >> > >>> > > - .input
> >> > >>> > > + input
> >> > >>> > > margin: $textfield-margin
> >> > >>> > > padding: $textfield-padding
> >> > >>> > >
> >> > >>> > >
> >> > >>> > > --
> >> > >>> > > To stop receiving notification emails like this one, please
> >> contact
> >> > >>> > > carlosrovira@apache.org.
> >> > >>> > >
> >> > >>> >
> >> > >>> >
> >> > >>> >
> >> > >>> > --
> >> > >>> >
> >> > >>> > Piotr Zarzycki
> >> > >>> >
> >> > >>> > Patreon:
> >> > >>>*https://na01.safelinks.protection.outlook.com/?url=
> >> > https%3A%2F%2Fwww.pa
> >> > >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> >> > %7Ca45baaa226
> >> > >>>d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C6365
> >> > >>>77359996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> >> > 2B5E%3D&
> >> > >>>reserved=0
> >> > >>> >
> >> > >>><https://na01.safelinks.protection.outlook.com/?url=
> >> > https%3A%2F%2Fwww.pa
> >> > >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> >> > %7Ca45baaa226
> >> > >>>d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C6365
> >> > >>>77359996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> >> > 2B5E%3D&
> >> > >>>reserved=0>*
> >> > >>> >
> >> > >>>
> >> > >>>
> >> > >>>
> >> > >>> --
> >> > >>> Carlos Rovira
> >> > >>>
> >> > >>>https://na01.safelinks.protection.outlook.com/?url=
> >> > http%3A%2F%2Fabout.me
> >> > >>>%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%
> >> > 7Ca45baaa226d74ff0dad6
> >> > >>>08d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C63657735999667
> >> >
> >>>>>7198&sdata=BbM3FSzf3YGLSzq10huJ2EUfTkZ9%
> 2BoqZeYmLKTV5aN0%3D&reserved=0
> >> > >>>
> >> > >>
> >> > >>
> >> > >>
> >> > >> --
> >> > >>
> >> > >> Piotr Zarzycki
> >> > >>
> >> > >> Patreon:
> >> > >>*https://na01.safelinks.protection.outlook.com/?url=
> >> > https%3A%2F%2Fwww.pat
> >> > >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> >> > %7Ca45baaa226d7
> >> > >>4ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C6365773
> >> > >>59996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> >> > 2B5E%3D&rese
> >> > >>rved=0
> >> > >>
> >> > >><https://na01.safelinks.protection.outlook.com/?url=
> >> > https%3A%2F%2Fwww.pat
> >> > >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> >> > %7Ca45baaa226d7
> >> > >>4ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C6365773
> >> > >>59996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> >> > 2B5E%3D&rese
> >> > >>rved=0>*
> >> > >>
> >> > >
> >> > >
> >> > >
> >> > >--
> >> > >
> >> > >Piotr Zarzycki
> >> > >
> >> > >Patreon:
> >> > >*https://na01.safelinks.protection.outlook.com/?url=
> >> > https%3A%2F%2Fwww.patr
> >> > >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%
> >> > 7Ca45baaa226d74f
> >> > >f0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C6365773599
> >> > >96677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> >> > 2B5E%3D&reserved
> >> > >=0
> >> > ><https://na01.safelinks.protection.outlook.com/?url=
> >> > https%3A%2F%2Fwww.patr
> >> > >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%
> >> > 7Ca45baaa226d74f
> >> > >f0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> >> > cee1%7C0%7C0%7C6365773599
> >> > >96677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> >> > 2B5E%3D&reserved
> >> > >=0>*
> >> >
> >> >
> >>
> >>
> >> --
> >> Carlos Rovira
> >>
> >>https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fabout.me%
> >>2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%
> 7C7e5bcc761c784beadb7c08
> >>d594115965%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C63657772460014925
> >>2&sdata=aWM6AZAUk7x49fMBvEycFs1EatXMaYSVxX%2BmI5I10%2Fw%3D&reserved=0
> >>
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [royale-asjs] branch feature/jewel-ui-set updated: removes
workaround for element styles thanks to bugs #30/#32 solved
Posted by Alex Harui <ah...@adobe.com.INVALID>.
This post [1] implies that it is not allowed in the Linux Kernel repos.
This post [2] also warns of danger
My takeaway is that --amend is ok before you push. Instead, we could
adopt a convention, like changing some dummy file or README or
RELEASE_NOTES or one of the actual files and using a commit message that
says "Commit hash <hash> should also contain message <message>".
Thoughts?
-Alex
[1]
https://stackoverflow.com/questions/457379/how-do-i-edit-an-incorrect-commi
t-message-in-git-that-ive-pushed/457396#457396
[2]
https://stackoverflow.com/questions/8981194/changing-git-commit-message-aft
er-push-given-that-no-one-pulled-from-remote
On 3/27/18, 11:33 AM, "Piotr Zarzycki" <pi...@gmail.com> wrote:
>Hi Alex,
>
>I didn't know that could be unsafe. I did it by amend.
>If you see some article from a good source share here.
>
>Thanks,
>Piotr
>
>On Tue, Mar 27, 2018, 20:04 Carlos Rovira <ca...@apache.org> wrote:
>
>> I think other way to do this with an "amend" command? (at least to add
>> forgotten content to a commit..
>>
>> 2018-03-27 18:18 GMT+02:00 Alex Harui <ah...@adobe.com.invalid>:
>>
>> > Hi Piotr,
>> >
>> > Are you sure it is safe to change commit messages? I see some
>>articles
>> > saying that it is unsafe.
>> >
>> > Thoughts?
>> > -Alex
>> >
>> > On 3/27/18, 1:26 AM, "Piotr Zarzycki" <pi...@gmail.com>
>>wrote:
>> >
>> > >I just pushed changes -> Checkout how it looks like now ->
>> > >https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fgithub.co
>> > >m%2Fapache%2Froyale-asjs%2Fcommit%2Fdf9808dc6ad261d33e58715c4644
>> > 8a1da5ee50
>> > >ad&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74ff0dad608d593bc
>> > 75c4%7C
>> > >fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636577359996677198&sdata=
>> > agZM7t
>> > >aOsrP2Zy99%2FP5iwKwWfCqeucpm5PNmC6fbQmg%3D&reserved=0
>> > >
>> > >2018-03-27 10:22 GMT+02:00 Piotr Zarzycki
>><pi...@gmail.com>:
>> > >
>> > >> I will change message in your last commit. Yes that is how are you
>> > >>linking
>> > >> to the other repository. If it will be in typedefs you will do:
>> > >> apache/royale-typedefs#number
>> > >>
>> > >> 2018-03-27 10:17 GMT+02:00 Carlos Rovira <ca...@apache.org>:
>> > >>
>> > >>> Hi Piotr,
>> > >>> thanks! I didn't realize that it's not the same repo, so for
>> compiler I
>> > >>> must put "apache/royale-compiler#<number>" ? Thanks, I'll do the
>>next
>> > >>> time!
>> > >>> :)
>> > >>>
>> > >>> 2018-03-27 10:13 GMT+02:00 Piotr Zarzycki
>><piotrzarzycki21@gmail.com
>> >:
>> > >>>
>> > >>> > Hi Carlos,
>> > >>> >
>> > >>> > And again if you add in the description
>>apache/royale-compiler#30
>> and
>> > >>> > apache/royale-compiler#32 it will point to the proper issue.
>>Now
>> you
>> > >>> are
>> > >>> > pointing to some closed issue in asjs which is totally
>>unrelated.
>> > >>> >
>> > >>> > Thanks,
>> > >>> > Piotr
>> > >>> >
>> > >>> > 2018-03-27 10:02 GMT+02:00 <ca...@apache.org>:
>> > >>> >
>> > >>> > > This is an automated email from the ASF dual-hosted git
>> repository.
>> > >>> > >
>> > >>> > > carlosrovira pushed a commit to branch feature/jewel-ui-set
>> > >>> > > in repository
>> > >>>
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox
>> > .
>> > >>>apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%
>> > 7C01%7Caharui%40adobe
>> >
>>>>>.com%7Ca45baaa226d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > ce
>> >
>>>>>e1%7C0%7C0%7C636577359996677198&sdata=D3YDt7MXbmAhxG4D4zhxH2Hdrx8HtX
>> > mhWf
>> > >>>FL4704jOA%3D&reserved=0
>> > >>> > >
>> > >>> > >
>> > >>> > > The following commit(s) were added to
>> > >>>refs/heads/feature/jewel-ui-set
>> > >>> by
>> > >>> > > this push:
>> > >>> > > new 10d993c removes workaround for element styles
>>thanks to
>> > >>>bugs
>> > >>> > > #30/#32 solved
>> > >>> > > 10d993c is described below
>> > >>> > >
>> > >>> > > commit 10d993c21ef554019a249a8355e007adbab07ca8
>> > >>> > > Author: Carlos Rovira <ca...@apache.org>
>> > >>> > > AuthorDate: Tue Mar 27 10:02:00 2018 +0200
>> > >>> > >
>> > >>> > > removes workaround for element styles thanks to bugs
>>#30/#32
>> > >>> solved
>> > >>> > > ---
>> > >>> > > .../src/main/resources/jewel-example-styles.css | 7 +++-
>> > >>> > > .../src/main/royale/RadioButtonPlayGround.mxml | 2 +-
>> > >>> > > .../royale/org/apache/royale/jewel/CheckBox.as | 4 +-
>> > >>> > > .../royale/org/apache/royale/jewel/RadioButton.as | 4 +-
>> > >>> > > .../main/royale/org/apache/royale/jewel/Slider.as | 2 +-
>> > >>> > > .../royale/org/apache/royale/jewel/TextField.as | 2 +-
>> > >>> > > .../JewelTheme/src/main/resources/defaults.css | 48
>> > >>> > > +++++++++++-----------
>> > >>> > > .../src/main/sass/components/_checkbox.sass | 4 +-
>> > >>> > > .../src/main/sass/components/_radiobutton.sass | 4 +-
>> > >>> > > .../src/main/sass/components/_slider.sass | 2 +-
>> > >>> > > .../src/main/sass/components/_textfield.sass | 2 +-
>> > >>> > > 11 files changed, 42 insertions(+), 39 deletions(-)
>> > >>> > >
>> > >>> > > diff --git a/examples/royale/JewelExample/src/main/
>> > >>> > > resources/jewel-example-styles.css b/examples/royale/
>> > >>> > > JewelExample/src/main/resources/jewel-example-styles.css
>> > >>> > > index 003d6c8..c2ea379 100644
>> > >>> > > ---
>> > >>>a/examples/royale/JewelExample/src/main/resources/jewel-example-
>> > >>> > > styles.css
>> > >>> > > +++
>> > >>>b/examples/royale/JewelExample/src/main/resources/jewel-example-
>> > >>> > > styles.css
>> > >>> > > @@ -21,10 +21,13 @@
>> > >>> > >
>> > >>> > > @namespace
>> > >>>"
>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.w3
>> > .
>> > >>>org%2F1999%2Fxhtml&data=02%7C01%7Caharui%40adobe.com%
>> > 7Ca45baaa226d74ff0d
>> > >>>ad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C63657735999
>> > >>>6677198&sdata=hCL1lfhr1M7AHjRbVVHmuupkJGR1nh
>> > 2m5GSh0skwrAk%3D&reserved=0"
>> > >>>;
>> > >>> > >
>> > >>> > > -
>> > >>> > > +body{
>> > >>> > > + background: #fff;
>> > >>> > > +}
>> > >>> > >
>> > >>> > > .container {
>> > >>> > > background: #efefef;
>> > >>> > > border-radius: 10px;
>> > >>> > > padding: 20px;
>> > >>> > > -}
>> > >>> > > \ No newline at end of file
>> > >>> > > +}
>> > >>> > > +
>> > >>> > > \ No newline at end of file
>> > >>> > > diff --git a/examples/royale/JewelExample/src/main/royale/
>> > >>> > RadioButtonPlayGround.mxml
>> > >>> > > b/examples/royale/JewelExample/src/main/royale/
>> > >>> > RadioButtonPlayGround.mxml
>> > >>> > > index 3d34b18..9e6806d 100644
>> > >>> > > --- a/examples/royale/JewelExample/src/main/royale/
>> > >>> > > RadioButtonPlayGround.mxml
>> > >>> > > +++ b/examples/royale/JewelExample/src/main/royale/
>> > >>> > > RadioButtonPlayGround.mxml
>> > >>> > > @@ -30,7 +30,7 @@ limitations under the License.
>> > >>> > > <html:H3 text="Jewel RadioButton"/>
>> > >>> > >
>> > >>> > > <j:RadioButton text="RadioButton 1" groupName="radios"
>> > >>> > value="Test
>> > >>> > > 1"/>
>> > >>> > > - <j:RadioButton text="RadioButton 2" groupName="radios"
>> > >>> > value="Test
>> > >>> > > 2"/>
>> > >>> > > + <j:RadioButton text="RadioButton 2" groupName="radios"
>> > >>> > value="Test
>> > >>> > > 2" selected="true"/>
>> > >>> > > <j:RadioButton text="RadioButton 3" groupName="radios"
>> > >>> > value="Test
>> > >>> > > 3"/>
>> > >>> > >
>> > >>> > > <j:RadioButton text="Disabled">
>> > >>> > > diff --git
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > royale/jewel/CheckBox.as
>> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/CheckBox.as
>> > >>> > > index d69fad6..5c78dbc 100644
>> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/CheckBox.as
>> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/CheckBox.as
>> > >>> > > @@ -99,11 +99,11 @@ package org.apache.royale.jewel
>> > >>> > >
>> > >>> > > input = addElementToWrapper(this,'input') as
>> > >>> > > HTMLInputElement;
>> > >>> > > input.type = 'checkbox';
>> > >>> > > - input.className = 'input';
>> > >>> > > + //input.className = 'input';
>> > >>> > > label.appendChild(input);
>> > >>> > >
>> > >>> > > checkbox = document.createElement('span') as
>> > >>> > HTMLSpanElement;
>> > >>> > > - checkbox.className = 'span';
>> > >>> > > + //checkbox.className = 'span';
>> > >>> > > label.appendChild(checkbox);
>> > >>> > >
>> > >>> > > positioner = label as WrappedHTMLElement;
>> > >>> > > diff --git
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > royale/jewel/RadioButton.as
>> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/RadioButton.as
>> > >>> > > index 19d5981..b36b51a 100644
>> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/RadioButton.as
>> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/RadioButton.as
>> > >>> > > @@ -316,14 +316,14 @@ package org.apache.royale.jewel
>> > >>> > >
>> > >>> > > icon = addElementToWrapper(this,'input') as
>> > >>> > HTMLInputElement;
>> > >>> > > icon.type = "radio";
>> > >>> > > - icon.className = 'input';
>> > >>> > > + //icon.className = 'input';
>> > >>> > > icon.id = '_radio_' + + Math.random();
>> > >>> > > label.appendChild(icon);
>> > >>> > >
>> > >>> > > textNode = document.createTextNode('') as Text;
>> > >>> > >
>> > >>> > > radio = document.createElement('span') as
>> > >>> HTMLSpanElement;
>> > >>> > > - radio.className = 'span';
>> > >>> > > + //radio.className = 'span';
>> > >>> > > radio.appendChild(textNode);
>> > >>> > > label.appendChild(radio);
>> > >>> > > //radio.addEventListener('mouseover',
>> > >>>mouseOverHandler,
>> > >>> > > false);
>> > >>> > > diff --git
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > royale/jewel/Slider.as
>> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/Slider.as
>> > >>> > > index 0cb0101..a9ddbbe 100644
>> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/Slider.as
>> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/Slider.as
>> > >>> > > @@ -184,7 +184,7 @@ package org.apache.royale.jewel
>> > >>> > >
>> > >>> > > var input:HTMLInputElement =
>> > >>>addElementToWrapper(this,'
>> > >>> > input')
>> > >>> > > as HTMLInputElement;
>> > >>> > > input.setAttribute('type', 'range');
>> > >>> > > - input.className = "slider";
>> > >>> > > + //input.className = "slider";
>> > >>> > >
>> > >>> > > //attach input handler to dispatch
>>royale
>> > >>> change
>> > >>> > > event when user write in textinput
>> > >>> > > //goog.events.listen(element, 'change',
>> > >>> killChangeHandler);
>> > >>> > > diff --git
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > royale/jewel/TextField.as
>> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/TextField.as
>> > >>> > > index 1c12711..a5d5c1c 100644
>> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/TextField.as
>> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > >>> > > royale/jewel/TextField.as
>> > >>> > > @@ -82,7 +82,7 @@ package org.apache.royale.jewel
>> > >>> > >
>> > >>> > > input = addElementToWrapper(this,'input') as
>> > >>> > > HTMLInputElement;
>> > >>> > > input.setAttribute('type', 'text');
>> > >>> > > - input.className = "input";
>> > >>> > > + //input.className = "input";
>> > >>> > >
>> > >>> > > //attach input handler to dispatch royale change
>> event
>> > >>> when
>> > >>> > > user write in textinput
>> > >>> > > //goog.events.listen(element, 'change',
>> > >>> killChangeHandler);
>> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/resources/
>> > >>> > defaults.css
>> > >>> > > b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
>> > >>> > > index 8f90431..e23ebd2 100644
>> > >>> > > ---
>> a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
>> > >>> > > +++
>> b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
>> > >>> > > @@ -196,7 +196,7 @@ div {
>> > >>> > > width: 100%;
>> > >>> > > height: 22px;
>> > >>> > > }
>> > >>> > > -.jewel.checkbox .input {
>> > >>> > > +.jewel.checkbox input {
>> > >>> > > -webkit-appearance: none;
>> > >>> > > -moz-appearance: none;
>> > >>> > > -o-appearance: none;
>> > >>> > > @@ -212,26 +212,26 @@ div {
>> > >>> > > border: 1px solid #b3b3b3;
>> > >>> > > border-radius: 3px;
>> > >>> > > }
>> > >>> > > -.jewel.checkbox .input:checked, .jewel.checkbox
>> > >>> .input:checked:active {
>> > >>> > > +.jewel.checkbox input:checked, .jewel.checkbox
>> > >>>input:checked:active {
>> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0
>>16
>> > >>>13'
>> > >>> > > version='1.1'
>> >
>>>>>xmlns='https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%
>>>>>2Fna01.safelinks.protection.outlook&data=02%7C01%7Caharui%40adobe.com%
>>>>>7C7e5bcc761c784beadb7c08d594115965%7Cfa7b1b5a7b34438794aed2c178decee1%
>>>>>7C0%7C0%7C636577724600139244&sdata=Lut9lYckLkGTPjZP%2FwXYIr9ZCb%2BTvEl
>>>>>WdIG0JeKrqx8%3D&reserved=0.
>> > com/?url=http%3A%2F%2Fw
>> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
>> > %7Ca45baaa226d74
>> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C6365773
>> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
>> > 3D&reser
>> > >>>ved=0'><g
>> > >>> > > transform='translate(-763, -290)'><g transform='translate(760,
>> > >>> > > 285)'><g><polygon fill='#3CADF1' points='3 13 9 18 19 7 16 5 9
>> 13 6
>> > >>> > > 10'></polygon></g></g></g></svg>");
>> > >>> > > background-repeat: no-repeat;
>> > >>> > > background-size: 90%;
>> > >>> > > background-position: center;
>> > >>> > > background-attachment: fixed;
>> > >>> > > }
>> > >>> > > -.jewel.checkbox .input:focus {
>> > >>> > > +.jewel.checkbox input:focus {
>> > >>> > > outline: none;
>> > >>> > > border: 1px solid #0f88d1;
>> > >>> > > }
>> > >>> > > -.jewel.checkbox .input[disabled] {
>> > >>> > > +.jewel.checkbox input[disabled] {
>> > >>> > > cursor: unset;
>> > >>> > > border: 1px solid #c6c6c6;
>> > >>> > > background: #F9F9F9;
>> > >>> > > }
>> > >>> > > -.jewel.checkbox .input[disabled] + .span {
>> > >>> > > +.jewel.checkbox input[disabled] + .span {
>> > >>> > > color: #c6c6c6;
>> > >>> > > }
>> > >>> > > -.jewel.checkbox .input[disabled]:checked {
>> > >>> > > +.jewel.checkbox input[disabled]:checked {
>> > >>> > > border: 1px solid #c6c6c6;
>> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0
>>16
>> > >>>13'
>> > >>> > > version='1.1'
>> >
>>>>>xmlns='https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%
>>>>>2Fna01.safelinks.protection.outlook&data=02%7C01%7Caharui%40adobe.com%
>>>>>7C7e5bcc761c784beadb7c08d594115965%7Cfa7b1b5a7b34438794aed2c178decee1%
>>>>>7C0%7C0%7C636577724600139244&sdata=Lut9lYckLkGTPjZP%2FwXYIr9ZCb%2BTvEl
>>>>>WdIG0JeKrqx8%3D&reserved=0.
>> > com/?url=http%3A%2F%2Fw
>> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
>> > %7Ca45baaa226d74
>> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C6365773
>> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
>> > 3D&reser
>> > >>>ved=0'><g
>> > >>> > > transform='translate(-763, -290)'><g transform='translate(760,
>> > >>> > > 285)'><g><polygon fill='lightgray' points='3 13 9 18 19 7 16
>>5 9
>> > >>>13 6
>> > >>> > > 10'></polygon></g></g></g></svg>");
>> > >>> > > background-size: 90%;
>> > >>> > > @@ -239,7 +239,7 @@ div {
>> > >>> > > background-repeat: no-repeat;
>> > >>> > > background-attachment: fixed;
>> > >>> > > }
>> > >>> > > -.jewel.checkbox .span {
>> > >>> > > +.jewel.checkbox span {
>> > >>> > > cursor: pointer;
>> > >>> > > position: absolute;
>> > >>> > > margin: 0;
>> > >>> > > @@ -262,7 +262,7 @@ div {
>> > >>> > > width: 100%;
>> > >>> > > height: 22px;
>> > >>> > > }
>> > >>> > > -.jewel.radiobutton .input {
>> > >>> > > +.jewel.radiobutton input {
>> > >>> > > -webkit-appearance: none;
>> > >>> > > -moz-appearance: none;
>> > >>> > > -o-appearance: none;
>> > >>> > > @@ -278,26 +278,26 @@ div {
>> > >>> > > border: 1px solid #b3b3b3;
>> > >>> > > border-radius: 50%;
>> > >>> > > }
>> > >>> > > -.jewel.radiobutton .input:checked, .jewel.radiobutton
>> > >>> > > .input:checked:active {
>> > >>> > > +.jewel.radiobutton input:checked, .jewel.radiobutton
>> > >>> > input:checked:active
>> > >>> > > {
>> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0
>>12
>> > >>>12'
>> > >>> > > version='1.1'
>> >
>>>>>xmlns='https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%
>>>>>2Fna01.safelinks.protection.outlook&data=02%7C01%7Caharui%40adobe.com%
>>>>>7C7e5bcc761c784beadb7c08d594115965%7Cfa7b1b5a7b34438794aed2c178decee1%
>>>>>7C0%7C0%7C636577724600139244&sdata=Lut9lYckLkGTPjZP%2FwXYIr9ZCb%2BTvEl
>>>>>WdIG0JeKrqx8%3D&reserved=0.
>> > com/?url=http%3A%2F%2Fw
>> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
>> > %7Ca45baaa226d74
>> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C6365773
>> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
>> > 3D&reser
>> > >>>ved=0'><g
>> > >>> > > transform='translate(-616, -350)'><g transform='translate(611,
>> > >>> > > 345)'><g><circle fill='#3CADF1' cx='11' cy='11'
>> > >>> > > r='6'></circle></g></g></g></svg>");
>> > >>> > > background-repeat: no-repeat;
>> > >>> > > background-size: 60%;
>> > >>> > > background-position: center;
>> > >>> > > background-attachment: fixed;
>> > >>> > > }
>> > >>> > > -.jewel.radiobutton .input:focus {
>> > >>> > > +.jewel.radiobutton input:focus {
>> > >>> > > outline: none;
>> > >>> > > border: 1px solid #0f88d1;
>> > >>> > > }
>> > >>> > > -.jewel.radiobutton .input[disabled] {
>> > >>> > > +.jewel.radiobutton input[disabled] {
>> > >>> > > cursor: unset;
>> > >>> > > border: 1px solid #c6c6c6;
>> > >>> > > background: #F9F9F9;
>> > >>> > > }
>> > >>> > > -.jewel.radiobutton .input[disabled] + .span {
>> > >>> > > +.jewel.radiobutton input[disabled] + .span {
>> > >>> > > color: #c6c6c6;
>> > >>> > > }
>> > >>> > > -.jewel.radiobutton .input[disabled]:checked {
>> > >>> > > +.jewel.radiobutton input[disabled]:checked {
>> > >>> > > border: 1px solid #c6c6c6;
>> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0
>>12
>> > >>>12'
>> > >>> > > version='1.1'
>> >
>>>>>xmlns='https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%
>>>>>2Fna01.safelinks.protection.outlook&data=02%7C01%7Caharui%40adobe.com%
>>>>>7C7e5bcc761c784beadb7c08d594115965%7Cfa7b1b5a7b34438794aed2c178decee1%
>>>>>7C0%7C0%7C636577724600139244&sdata=Lut9lYckLkGTPjZP%2FwXYIr9ZCb%2BTvEl
>>>>>WdIG0JeKrqx8%3D&reserved=0.
>> > com/?url=http%3A%2F%2Fw
>> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
>> > %7Ca45baaa226d74
>> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C6365773
>> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
>> > 3D&reser
>> > >>>ved=0'><g
>> > >>> > > transform='translate(-616, -350)'><g transform='translate(611,
>> > >>> > > 345)'><g><circle fill='lightgray' cx='11' cy='11'
>> > >>> > > r='6'></circle></g></g></g></svg>");
>> > >>> > > background-size: 60%;
>> > >>> > > @@ -305,7 +305,7 @@ div {
>> > >>> > > background-repeat: no-repeat;
>> > >>> > > background-attachment: fixed;
>> > >>> > > }
>> > >>> > > -.jewel.radiobutton .span {
>> > >>> > > +.jewel.radiobutton span {
>> > >>> > > cursor: pointer;
>> > >>> > > position: absolute;
>> > >>> > > margin: 0;
>> > >>> > > @@ -314,7 +314,7 @@ div {
>> > >>> > > line-height: 22px;
>> > >>> > > }
>> > >>> > >
>> > >>> > > -.jewel.slider .slider {
>> > >>> > > +.jewel.slider input {
>> > >>> > > -webkit-appearance: none;
>> > >>> > > width: 100%;
>> > >>> > > height: 15px;
>> > >>> > > @@ -325,13 +325,13 @@ div {
>> > >>> > > -webkit-transition: 0.2s;
>> > >>> > > transition: opacity 0.2s;
>> > >>> > > }
>> > >>> > > -.jewel.slider .slider:hover {
>> > >>> > > +.jewel.slider input:hover {
>> > >>> > > opacity: 1;
>> > >>> > > }
>> > >>> > > -.jewel.slider .slider:focus {
>> > >>> > > +.jewel.slider input:focus {
>> > >>> > > outline: none;
>> > >>> > > }
>> > >>> > > -.jewel.slider .slider::-webkit-slider-thumb {
>> > >>> > > +.jewel.slider input::-webkit-slider-thumb {
>> > >>> > > -webkit-appearance: none;
>> > >>> > > appearance: none;
>> > >>> > > width: 15px;
>> > >>> > > @@ -340,7 +340,7 @@ div {
>> > >>> > > background: #3CADF1;
>> > >>> > > cursor: pointer;
>> > >>> > > }
>> > >>> > > -.jewel.slider .slider::-moz-range-thumb {
>> > >>> > > +.jewel.slider input::-moz-range-thumb {
>> > >>> > > width: 15px;
>> > >>> > > height: 15px;
>> > >>> > > border-radius: 50%;
>> > >>> > > @@ -523,7 +523,7 @@ div {
>> > >>> > > position: relative;
>> > >>> > > display: inline-flex;
>> > >>> > > }
>> > >>> > > -.jewel.textfield .input {
>> > >>> > > +.jewel.textfield input {
>> > >>> > > margin: 0;
>> > >>> > > padding: 0.67em 1em;
>> > >>> > > max-width: 100%;
>> > >>> > > @@ -542,20 +542,20 @@ div {
>> > >>> > > transition-duration: 0.3s;
>> > >>> > > transition-timing-function: easein;
>> > >>> > > }
>> > >>> > > -.jewel.textfield .input:focus {
>> > >>> > > +.jewel.textfield input:focus {
>> > >>> > > border: 1px solid #0f88d1;
>> > >>> > > }
>> > >>> > > -.jewel.textfield .input::placeholder {
>> > >>> > > +.jewel.textfield input::placeholder {
>> > >>> > > color: #a6a6a6;
>> > >>> > > }
>> > >>> > > -.jewel.textfield .input[disabled] {
>> > >>> > > +.jewel.textfield input[disabled] {
>> > >>> > > cursor: unset;
>> > >>> > > border: 1px solid #c6c6c6;
>> > >>> > > background: #F9F9F9;
>> > >>> > > box-shadow: none;
>> > >>> > > color: #c6c6c6;
>> > >>> > > }
>> > >>> > > -.jewel.textfield .input[disabled]::placeholder {
>> > >>> > > +.jewel.textfield input[disabled]::placeholder {
>> > >>> > > color: #c6c6c6;
>> > >>> > > }
>> > >>> > >
>> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > components/_checkbox.sass
>> > >>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
>> > >>> checkbox.sass
>> > >>> > > index e79c952..92f4fd0 100644
>> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > components/_checkbox.sass
>> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > components/_checkbox.sass
>> > >>> > > @@ -39,7 +39,7 @@ $checkbox-label-font-size: 16px
>> > >>> > > height: $checkbox-button-size
>> > >>> > >
>> > >>> > > // -- INPUT
>> > >>> > > - .input
>> > >>> > > + input
>> > >>> > > +appear(none)
>> > >>> > > cursor: pointer
>> > >>> > > display: inline-block
>> > >>> > > @@ -102,7 +102,7 @@ $checkbox-label-font-size: 16px
>> > >>> > > //background: $disabled-color
>> > >>> > >
>> > >>> > > // -- LABEL
>> > >>> > > - .span
>> > >>> > > + span
>> > >>> > > cursor: pointer
>> > >>> > > position: absolute
>> > >>> > > margin: 0
>> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > components/_radiobutton.sass
>> > >>> > > b/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > components/_radiobutton.sass
>> > >>> > > index a224f28..d45a56a 100644
>> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > > components/_radiobutton.sass
>> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > > components/_radiobutton.sass
>> > >>> > > @@ -39,7 +39,7 @@ $radiobutton-label-font-size: 16px
>> > >>> > > height: $radiobutton-button-size
>> > >>> > >
>> > >>> > > // -- INPUT
>> > >>> > > - .input
>> > >>> > > + input
>> > >>> > > +appear(none)
>> > >>> > > cursor: pointer
>> > >>> > > display: inline-block
>> > >>> > > @@ -93,7 +93,7 @@ $radiobutton-label-font-size: 16px
>> > >>> > > background-attachment: fixed
>> > >>> > >
>> > >>> > > // -- LABEL
>> > >>> > > - .span
>> > >>> > > + span
>> > >>> > > cursor: pointer
>> > >>> > > position: absolute
>> > >>> > > margin: 0
>> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > components/_slider.sass
>> > >>> > >
>> >
>>>>>b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
>> > >>> > > index f92fdd0..115df2c 100644
>> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/components/_
>> > >>> slider.sass
>> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/components/_
>> > >>> slider.sass
>> > >>> > > @@ -19,7 +19,7 @@
>> > >>> > >
>> > >>> > > .jewel.slider
>> > >>> > >
>> > >>> > > - .slider
>> > >>> > > + input
>> > >>> > > -webkit-appearance: none
>> > >>> > > width: 100%
>> > >>> > > height: 15px
>> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > components/_textfield.sass
>> > >>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
>> > >>> textfield.sass
>> > >>> > > index 4165f6d..3e04d9a 100644
>> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > > components/_textfield.sass
>> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
>> > >>> > > components/_textfield.sass
>> > >>> > > @@ -32,7 +32,7 @@ $textfield-border-radius: 3px
>> > >>> > > position: relative
>> > >>> > > display: inline-flex
>> > >>> > >
>> > >>> > > - .input
>> > >>> > > + input
>> > >>> > > margin: $textfield-margin
>> > >>> > > padding: $textfield-padding
>> > >>> > >
>> > >>> > >
>> > >>> > > --
>> > >>> > > To stop receiving notification emails like this one, please
>> contact
>> > >>> > > carlosrovira@apache.org.
>> > >>> > >
>> > >>> >
>> > >>> >
>> > >>> >
>> > >>> > --
>> > >>> >
>> > >>> > Piotr Zarzycki
>> > >>> >
>> > >>> > Patreon:
>> > >>>*https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fwww.pa
>> > >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> > %7Ca45baaa226
>> > >>>d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C6365
>> > >>>77359996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
>> > 2B5E%3D&
>> > >>>reserved=0
>> > >>> >
>> > >>><https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fwww.pa
>> > >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> > %7Ca45baaa226
>> > >>>d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C6365
>> > >>>77359996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
>> > 2B5E%3D&
>> > >>>reserved=0>*
>> > >>> >
>> > >>>
>> > >>>
>> > >>>
>> > >>> --
>> > >>> Carlos Rovira
>> > >>>
>> > >>>https://na01.safelinks.protection.outlook.com/?url=
>> > http%3A%2F%2Fabout.me
>> > >>>%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%
>> > 7Ca45baaa226d74ff0dad6
>> > >>>08d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C63657735999667
>> >
>>>>>7198&sdata=BbM3FSzf3YGLSzq10huJ2EUfTkZ9%2BoqZeYmLKTV5aN0%3D&reserved=0
>> > >>>
>> > >>
>> > >>
>> > >>
>> > >> --
>> > >>
>> > >> Piotr Zarzycki
>> > >>
>> > >> Patreon:
>> > >>*https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fwww.pat
>> > >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> > %7Ca45baaa226d7
>> > >>4ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C6365773
>> > >>59996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
>> > 2B5E%3D&rese
>> > >>rved=0
>> > >>
>> > >><https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fwww.pat
>> > >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> > %7Ca45baaa226d7
>> > >>4ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C6365773
>> > >>59996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
>> > 2B5E%3D&rese
>> > >>rved=0>*
>> > >>
>> > >
>> > >
>> > >
>> > >--
>> > >
>> > >Piotr Zarzycki
>> > >
>> > >Patreon:
>> > >*https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fwww.patr
>> > >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%
>> > 7Ca45baaa226d74f
>> > >f0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C6365773599
>> > >96677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
>> > 2B5E%3D&reserved
>> > >=0
>> > ><https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fwww.patr
>> > >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%
>> > 7Ca45baaa226d74f
>> > >f0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C6365773599
>> > >96677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
>> > 2B5E%3D&reserved
>> > >=0>*
>> >
>> >
>>
>>
>> --
>> Carlos Rovira
>>
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%
>>2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C7e5bcc761c784beadb7c08
>>d594115965%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63657772460014925
>>2&sdata=aWM6AZAUk7x49fMBvEycFs1EatXMaYSVxX%2BmI5I10%2Fw%3D&reserved=0
>>
Re: [royale-asjs] branch feature/jewel-ui-set updated: removes
workaround for element styles thanks to bugs #30/#32 solved
Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Alex,
I didn't know that could be unsafe. I did it by amend.
If you see some article from a good source share here.
Thanks,
Piotr
On Tue, Mar 27, 2018, 20:04 Carlos Rovira <ca...@apache.org> wrote:
> I think other way to do this with an "amend" command? (at least to add
> forgotten content to a commit..
>
> 2018-03-27 18:18 GMT+02:00 Alex Harui <ah...@adobe.com.invalid>:
>
> > Hi Piotr,
> >
> > Are you sure it is safe to change commit messages? I see some articles
> > saying that it is unsafe.
> >
> > Thoughts?
> > -Alex
> >
> > On 3/27/18, 1:26 AM, "Piotr Zarzycki" <pi...@gmail.com> wrote:
> >
> > >I just pushed changes -> Checkout how it looks like now ->
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.co
> > >m%2Fapache%2Froyale-asjs%2Fcommit%2Fdf9808dc6ad261d33e58715c4644
> > 8a1da5ee50
> > >ad&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74ff0dad608d593bc
> > 75c4%7C
> > >fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636577359996677198&sdata=
> > agZM7t
> > >aOsrP2Zy99%2FP5iwKwWfCqeucpm5PNmC6fbQmg%3D&reserved=0
> > >
> > >2018-03-27 10:22 GMT+02:00 Piotr Zarzycki <pi...@gmail.com>:
> > >
> > >> I will change message in your last commit. Yes that is how are you
> > >>linking
> > >> to the other repository. If it will be in typedefs you will do:
> > >> apache/royale-typedefs#number
> > >>
> > >> 2018-03-27 10:17 GMT+02:00 Carlos Rovira <ca...@apache.org>:
> > >>
> > >>> Hi Piotr,
> > >>> thanks! I didn't realize that it's not the same repo, so for
> compiler I
> > >>> must put "apache/royale-compiler#<number>" ? Thanks, I'll do the next
> > >>> time!
> > >>> :)
> > >>>
> > >>> 2018-03-27 10:13 GMT+02:00 Piotr Zarzycki <piotrzarzycki21@gmail.com
> >:
> > >>>
> > >>> > Hi Carlos,
> > >>> >
> > >>> > And again if you add in the description apache/royale-compiler#30
> and
> > >>> > apache/royale-compiler#32 it will point to the proper issue. Now
> you
> > >>> are
> > >>> > pointing to some closed issue in asjs which is totally unrelated.
> > >>> >
> > >>> > Thanks,
> > >>> > Piotr
> > >>> >
> > >>> > 2018-03-27 10:02 GMT+02:00 <ca...@apache.org>:
> > >>> >
> > >>> > > This is an automated email from the ASF dual-hosted git
> repository.
> > >>> > >
> > >>> > > carlosrovira pushed a commit to branch feature/jewel-ui-set
> > >>> > > in repository
> > >>>
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox
> > .
> > >>>apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%
> > 7C01%7Caharui%40adobe
> > >>>.com%7Ca45baaa226d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > ce
> > >>>e1%7C0%7C0%7C636577359996677198&sdata=D3YDt7MXbmAhxG4D4zhxH2Hdrx8HtX
> > mhWf
> > >>>FL4704jOA%3D&reserved=0
> > >>> > >
> > >>> > >
> > >>> > > The following commit(s) were added to
> > >>>refs/heads/feature/jewel-ui-set
> > >>> by
> > >>> > > this push:
> > >>> > > new 10d993c removes workaround for element styles thanks to
> > >>>bugs
> > >>> > > #30/#32 solved
> > >>> > > 10d993c is described below
> > >>> > >
> > >>> > > commit 10d993c21ef554019a249a8355e007adbab07ca8
> > >>> > > Author: Carlos Rovira <ca...@apache.org>
> > >>> > > AuthorDate: Tue Mar 27 10:02:00 2018 +0200
> > >>> > >
> > >>> > > removes workaround for element styles thanks to bugs #30/#32
> > >>> solved
> > >>> > > ---
> > >>> > > .../src/main/resources/jewel-example-styles.css | 7 +++-
> > >>> > > .../src/main/royale/RadioButtonPlayGround.mxml | 2 +-
> > >>> > > .../royale/org/apache/royale/jewel/CheckBox.as | 4 +-
> > >>> > > .../royale/org/apache/royale/jewel/RadioButton.as | 4 +-
> > >>> > > .../main/royale/org/apache/royale/jewel/Slider.as | 2 +-
> > >>> > > .../royale/org/apache/royale/jewel/TextField.as | 2 +-
> > >>> > > .../JewelTheme/src/main/resources/defaults.css | 48
> > >>> > > +++++++++++-----------
> > >>> > > .../src/main/sass/components/_checkbox.sass | 4 +-
> > >>> > > .../src/main/sass/components/_radiobutton.sass | 4 +-
> > >>> > > .../src/main/sass/components/_slider.sass | 2 +-
> > >>> > > .../src/main/sass/components/_textfield.sass | 2 +-
> > >>> > > 11 files changed, 42 insertions(+), 39 deletions(-)
> > >>> > >
> > >>> > > diff --git a/examples/royale/JewelExample/src/main/
> > >>> > > resources/jewel-example-styles.css b/examples/royale/
> > >>> > > JewelExample/src/main/resources/jewel-example-styles.css
> > >>> > > index 003d6c8..c2ea379 100644
> > >>> > > ---
> > >>>a/examples/royale/JewelExample/src/main/resources/jewel-example-
> > >>> > > styles.css
> > >>> > > +++
> > >>>b/examples/royale/JewelExample/src/main/resources/jewel-example-
> > >>> > > styles.css
> > >>> > > @@ -21,10 +21,13 @@
> > >>> > >
> > >>> > > @namespace
> > >>>"
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.w3
> > .
> > >>>org%2F1999%2Fxhtml&data=02%7C01%7Caharui%40adobe.com%
> > 7Ca45baaa226d74ff0d
> > >>>ad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C63657735999
> > >>>6677198&sdata=hCL1lfhr1M7AHjRbVVHmuupkJGR1nh
> > 2m5GSh0skwrAk%3D&reserved=0"
> > >>>;
> > >>> > >
> > >>> > > -
> > >>> > > +body{
> > >>> > > + background: #fff;
> > >>> > > +}
> > >>> > >
> > >>> > > .container {
> > >>> > > background: #efefef;
> > >>> > > border-radius: 10px;
> > >>> > > padding: 20px;
> > >>> > > -}
> > >>> > > \ No newline at end of file
> > >>> > > +}
> > >>> > > +
> > >>> > > \ No newline at end of file
> > >>> > > diff --git a/examples/royale/JewelExample/src/main/royale/
> > >>> > RadioButtonPlayGround.mxml
> > >>> > > b/examples/royale/JewelExample/src/main/royale/
> > >>> > RadioButtonPlayGround.mxml
> > >>> > > index 3d34b18..9e6806d 100644
> > >>> > > --- a/examples/royale/JewelExample/src/main/royale/
> > >>> > > RadioButtonPlayGround.mxml
> > >>> > > +++ b/examples/royale/JewelExample/src/main/royale/
> > >>> > > RadioButtonPlayGround.mxml
> > >>> > > @@ -30,7 +30,7 @@ limitations under the License.
> > >>> > > <html:H3 text="Jewel RadioButton"/>
> > >>> > >
> > >>> > > <j:RadioButton text="RadioButton 1" groupName="radios"
> > >>> > value="Test
> > >>> > > 1"/>
> > >>> > > - <j:RadioButton text="RadioButton 2" groupName="radios"
> > >>> > value="Test
> > >>> > > 2"/>
> > >>> > > + <j:RadioButton text="RadioButton 2" groupName="radios"
> > >>> > value="Test
> > >>> > > 2" selected="true"/>
> > >>> > > <j:RadioButton text="RadioButton 3" groupName="radios"
> > >>> > value="Test
> > >>> > > 3"/>
> > >>> > >
> > >>> > > <j:RadioButton text="Disabled">
> > >>> > > diff --git
> a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > royale/jewel/CheckBox.as
> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/CheckBox.as
> > >>> > > index d69fad6..5c78dbc 100644
> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/CheckBox.as
> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/CheckBox.as
> > >>> > > @@ -99,11 +99,11 @@ package org.apache.royale.jewel
> > >>> > >
> > >>> > > input = addElementToWrapper(this,'input') as
> > >>> > > HTMLInputElement;
> > >>> > > input.type = 'checkbox';
> > >>> > > - input.className = 'input';
> > >>> > > + //input.className = 'input';
> > >>> > > label.appendChild(input);
> > >>> > >
> > >>> > > checkbox = document.createElement('span') as
> > >>> > HTMLSpanElement;
> > >>> > > - checkbox.className = 'span';
> > >>> > > + //checkbox.className = 'span';
> > >>> > > label.appendChild(checkbox);
> > >>> > >
> > >>> > > positioner = label as WrappedHTMLElement;
> > >>> > > diff --git
> a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > royale/jewel/RadioButton.as
> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/RadioButton.as
> > >>> > > index 19d5981..b36b51a 100644
> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/RadioButton.as
> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/RadioButton.as
> > >>> > > @@ -316,14 +316,14 @@ package org.apache.royale.jewel
> > >>> > >
> > >>> > > icon = addElementToWrapper(this,'input') as
> > >>> > HTMLInputElement;
> > >>> > > icon.type = "radio";
> > >>> > > - icon.className = 'input';
> > >>> > > + //icon.className = 'input';
> > >>> > > icon.id = '_radio_' + + Math.random();
> > >>> > > label.appendChild(icon);
> > >>> > >
> > >>> > > textNode = document.createTextNode('') as Text;
> > >>> > >
> > >>> > > radio = document.createElement('span') as
> > >>> HTMLSpanElement;
> > >>> > > - radio.className = 'span';
> > >>> > > + //radio.className = 'span';
> > >>> > > radio.appendChild(textNode);
> > >>> > > label.appendChild(radio);
> > >>> > > //radio.addEventListener('mouseover',
> > >>>mouseOverHandler,
> > >>> > > false);
> > >>> > > diff --git
> a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > royale/jewel/Slider.as
> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/Slider.as
> > >>> > > index 0cb0101..a9ddbbe 100644
> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/Slider.as
> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/Slider.as
> > >>> > > @@ -184,7 +184,7 @@ package org.apache.royale.jewel
> > >>> > >
> > >>> > > var input:HTMLInputElement =
> > >>>addElementToWrapper(this,'
> > >>> > input')
> > >>> > > as HTMLInputElement;
> > >>> > > input.setAttribute('type', 'range');
> > >>> > > - input.className = "slider";
> > >>> > > + //input.className = "slider";
> > >>> > >
> > >>> > > //attach input handler to dispatch royale
> > >>> change
> > >>> > > event when user write in textinput
> > >>> > > //goog.events.listen(element, 'change',
> > >>> killChangeHandler);
> > >>> > > diff --git
> a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > royale/jewel/TextField.as
> > >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/TextField.as
> > >>> > > index 1c12711..a5d5c1c 100644
> > >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/TextField.as
> > >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > >>> > > royale/jewel/TextField.as
> > >>> > > @@ -82,7 +82,7 @@ package org.apache.royale.jewel
> > >>> > >
> > >>> > > input = addElementToWrapper(this,'input') as
> > >>> > > HTMLInputElement;
> > >>> > > input.setAttribute('type', 'text');
> > >>> > > - input.className = "input";
> > >>> > > + //input.className = "input";
> > >>> > >
> > >>> > > //attach input handler to dispatch royale change
> event
> > >>> when
> > >>> > > user write in textinput
> > >>> > > //goog.events.listen(element, 'change',
> > >>> killChangeHandler);
> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/resources/
> > >>> > defaults.css
> > >>> > > b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> > >>> > > index 8f90431..e23ebd2 100644
> > >>> > > ---
> a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> > >>> > > +++
> b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> > >>> > > @@ -196,7 +196,7 @@ div {
> > >>> > > width: 100%;
> > >>> > > height: 22px;
> > >>> > > }
> > >>> > > -.jewel.checkbox .input {
> > >>> > > +.jewel.checkbox input {
> > >>> > > -webkit-appearance: none;
> > >>> > > -moz-appearance: none;
> > >>> > > -o-appearance: none;
> > >>> > > @@ -212,26 +212,26 @@ div {
> > >>> > > border: 1px solid #b3b3b3;
> > >>> > > border-radius: 3px;
> > >>> > > }
> > >>> > > -.jewel.checkbox .input:checked, .jewel.checkbox
> > >>> .input:checked:active {
> > >>> > > +.jewel.checkbox input:checked, .jewel.checkbox
> > >>>input:checked:active {
> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16
> > >>>13'
> > >>> > > version='1.1'
> > >>>xmlns='https://na01.safelinks.protection.outlook.
> > com/?url=http%3A%2F%2Fw
> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> > %7Ca45baaa226d74
> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C6365773
> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> > 3D&reser
> > >>>ved=0'><g
> > >>> > > transform='translate(-763, -290)'><g transform='translate(760,
> > >>> > > 285)'><g><polygon fill='#3CADF1' points='3 13 9 18 19 7 16 5 9
> 13 6
> > >>> > > 10'></polygon></g></g></g></svg>");
> > >>> > > background-repeat: no-repeat;
> > >>> > > background-size: 90%;
> > >>> > > background-position: center;
> > >>> > > background-attachment: fixed;
> > >>> > > }
> > >>> > > -.jewel.checkbox .input:focus {
> > >>> > > +.jewel.checkbox input:focus {
> > >>> > > outline: none;
> > >>> > > border: 1px solid #0f88d1;
> > >>> > > }
> > >>> > > -.jewel.checkbox .input[disabled] {
> > >>> > > +.jewel.checkbox input[disabled] {
> > >>> > > cursor: unset;
> > >>> > > border: 1px solid #c6c6c6;
> > >>> > > background: #F9F9F9;
> > >>> > > }
> > >>> > > -.jewel.checkbox .input[disabled] + .span {
> > >>> > > +.jewel.checkbox input[disabled] + .span {
> > >>> > > color: #c6c6c6;
> > >>> > > }
> > >>> > > -.jewel.checkbox .input[disabled]:checked {
> > >>> > > +.jewel.checkbox input[disabled]:checked {
> > >>> > > border: 1px solid #c6c6c6;
> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16
> > >>>13'
> > >>> > > version='1.1'
> > >>>xmlns='https://na01.safelinks.protection.outlook.
> > com/?url=http%3A%2F%2Fw
> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> > %7Ca45baaa226d74
> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C6365773
> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> > 3D&reser
> > >>>ved=0'><g
> > >>> > > transform='translate(-763, -290)'><g transform='translate(760,
> > >>> > > 285)'><g><polygon fill='lightgray' points='3 13 9 18 19 7 16 5 9
> > >>>13 6
> > >>> > > 10'></polygon></g></g></g></svg>");
> > >>> > > background-size: 90%;
> > >>> > > @@ -239,7 +239,7 @@ div {
> > >>> > > background-repeat: no-repeat;
> > >>> > > background-attachment: fixed;
> > >>> > > }
> > >>> > > -.jewel.checkbox .span {
> > >>> > > +.jewel.checkbox span {
> > >>> > > cursor: pointer;
> > >>> > > position: absolute;
> > >>> > > margin: 0;
> > >>> > > @@ -262,7 +262,7 @@ div {
> > >>> > > width: 100%;
> > >>> > > height: 22px;
> > >>> > > }
> > >>> > > -.jewel.radiobutton .input {
> > >>> > > +.jewel.radiobutton input {
> > >>> > > -webkit-appearance: none;
> > >>> > > -moz-appearance: none;
> > >>> > > -o-appearance: none;
> > >>> > > @@ -278,26 +278,26 @@ div {
> > >>> > > border: 1px solid #b3b3b3;
> > >>> > > border-radius: 50%;
> > >>> > > }
> > >>> > > -.jewel.radiobutton .input:checked, .jewel.radiobutton
> > >>> > > .input:checked:active {
> > >>> > > +.jewel.radiobutton input:checked, .jewel.radiobutton
> > >>> > input:checked:active
> > >>> > > {
> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12
> > >>>12'
> > >>> > > version='1.1'
> > >>>xmlns='https://na01.safelinks.protection.outlook.
> > com/?url=http%3A%2F%2Fw
> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> > %7Ca45baaa226d74
> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C6365773
> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> > 3D&reser
> > >>>ved=0'><g
> > >>> > > transform='translate(-616, -350)'><g transform='translate(611,
> > >>> > > 345)'><g><circle fill='#3CADF1' cx='11' cy='11'
> > >>> > > r='6'></circle></g></g></g></svg>");
> > >>> > > background-repeat: no-repeat;
> > >>> > > background-size: 60%;
> > >>> > > background-position: center;
> > >>> > > background-attachment: fixed;
> > >>> > > }
> > >>> > > -.jewel.radiobutton .input:focus {
> > >>> > > +.jewel.radiobutton input:focus {
> > >>> > > outline: none;
> > >>> > > border: 1px solid #0f88d1;
> > >>> > > }
> > >>> > > -.jewel.radiobutton .input[disabled] {
> > >>> > > +.jewel.radiobutton input[disabled] {
> > >>> > > cursor: unset;
> > >>> > > border: 1px solid #c6c6c6;
> > >>> > > background: #F9F9F9;
> > >>> > > }
> > >>> > > -.jewel.radiobutton .input[disabled] + .span {
> > >>> > > +.jewel.radiobutton input[disabled] + .span {
> > >>> > > color: #c6c6c6;
> > >>> > > }
> > >>> > > -.jewel.radiobutton .input[disabled]:checked {
> > >>> > > +.jewel.radiobutton input[disabled]:checked {
> > >>> > > border: 1px solid #c6c6c6;
> > >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12
> > >>>12'
> > >>> > > version='1.1'
> > >>>xmlns='https://na01.safelinks.protection.outlook.
> > com/?url=http%3A%2F%2Fw
> > >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> > %7Ca45baaa226d74
> > >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C6365773
> > >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> > 3D&reser
> > >>>ved=0'><g
> > >>> > > transform='translate(-616, -350)'><g transform='translate(611,
> > >>> > > 345)'><g><circle fill='lightgray' cx='11' cy='11'
> > >>> > > r='6'></circle></g></g></g></svg>");
> > >>> > > background-size: 60%;
> > >>> > > @@ -305,7 +305,7 @@ div {
> > >>> > > background-repeat: no-repeat;
> > >>> > > background-attachment: fixed;
> > >>> > > }
> > >>> > > -.jewel.radiobutton .span {
> > >>> > > +.jewel.radiobutton span {
> > >>> > > cursor: pointer;
> > >>> > > position: absolute;
> > >>> > > margin: 0;
> > >>> > > @@ -314,7 +314,7 @@ div {
> > >>> > > line-height: 22px;
> > >>> > > }
> > >>> > >
> > >>> > > -.jewel.slider .slider {
> > >>> > > +.jewel.slider input {
> > >>> > > -webkit-appearance: none;
> > >>> > > width: 100%;
> > >>> > > height: 15px;
> > >>> > > @@ -325,13 +325,13 @@ div {
> > >>> > > -webkit-transition: 0.2s;
> > >>> > > transition: opacity 0.2s;
> > >>> > > }
> > >>> > > -.jewel.slider .slider:hover {
> > >>> > > +.jewel.slider input:hover {
> > >>> > > opacity: 1;
> > >>> > > }
> > >>> > > -.jewel.slider .slider:focus {
> > >>> > > +.jewel.slider input:focus {
> > >>> > > outline: none;
> > >>> > > }
> > >>> > > -.jewel.slider .slider::-webkit-slider-thumb {
> > >>> > > +.jewel.slider input::-webkit-slider-thumb {
> > >>> > > -webkit-appearance: none;
> > >>> > > appearance: none;
> > >>> > > width: 15px;
> > >>> > > @@ -340,7 +340,7 @@ div {
> > >>> > > background: #3CADF1;
> > >>> > > cursor: pointer;
> > >>> > > }
> > >>> > > -.jewel.slider .slider::-moz-range-thumb {
> > >>> > > +.jewel.slider input::-moz-range-thumb {
> > >>> > > width: 15px;
> > >>> > > height: 15px;
> > >>> > > border-radius: 50%;
> > >>> > > @@ -523,7 +523,7 @@ div {
> > >>> > > position: relative;
> > >>> > > display: inline-flex;
> > >>> > > }
> > >>> > > -.jewel.textfield .input {
> > >>> > > +.jewel.textfield input {
> > >>> > > margin: 0;
> > >>> > > padding: 0.67em 1em;
> > >>> > > max-width: 100%;
> > >>> > > @@ -542,20 +542,20 @@ div {
> > >>> > > transition-duration: 0.3s;
> > >>> > > transition-timing-function: easein;
> > >>> > > }
> > >>> > > -.jewel.textfield .input:focus {
> > >>> > > +.jewel.textfield input:focus {
> > >>> > > border: 1px solid #0f88d1;
> > >>> > > }
> > >>> > > -.jewel.textfield .input::placeholder {
> > >>> > > +.jewel.textfield input::placeholder {
> > >>> > > color: #a6a6a6;
> > >>> > > }
> > >>> > > -.jewel.textfield .input[disabled] {
> > >>> > > +.jewel.textfield input[disabled] {
> > >>> > > cursor: unset;
> > >>> > > border: 1px solid #c6c6c6;
> > >>> > > background: #F9F9F9;
> > >>> > > box-shadow: none;
> > >>> > > color: #c6c6c6;
> > >>> > > }
> > >>> > > -.jewel.textfield .input[disabled]::placeholder {
> > >>> > > +.jewel.textfield input[disabled]::placeholder {
> > >>> > > color: #c6c6c6;
> > >>> > > }
> > >>> > >
> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > components/_checkbox.sass
> > >>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
> > >>> checkbox.sass
> > >>> > > index e79c952..92f4fd0 100644
> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > components/_checkbox.sass
> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > components/_checkbox.sass
> > >>> > > @@ -39,7 +39,7 @@ $checkbox-label-font-size: 16px
> > >>> > > height: $checkbox-button-size
> > >>> > >
> > >>> > > // -- INPUT
> > >>> > > - .input
> > >>> > > + input
> > >>> > > +appear(none)
> > >>> > > cursor: pointer
> > >>> > > display: inline-block
> > >>> > > @@ -102,7 +102,7 @@ $checkbox-label-font-size: 16px
> > >>> > > //background: $disabled-color
> > >>> > >
> > >>> > > // -- LABEL
> > >>> > > - .span
> > >>> > > + span
> > >>> > > cursor: pointer
> > >>> > > position: absolute
> > >>> > > margin: 0
> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > components/_radiobutton.sass
> > >>> > > b/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > components/_radiobutton.sass
> > >>> > > index a224f28..d45a56a 100644
> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > > components/_radiobutton.sass
> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > > components/_radiobutton.sass
> > >>> > > @@ -39,7 +39,7 @@ $radiobutton-label-font-size: 16px
> > >>> > > height: $radiobutton-button-size
> > >>> > >
> > >>> > > // -- INPUT
> > >>> > > - .input
> > >>> > > + input
> > >>> > > +appear(none)
> > >>> > > cursor: pointer
> > >>> > > display: inline-block
> > >>> > > @@ -93,7 +93,7 @@ $radiobutton-label-font-size: 16px
> > >>> > > background-attachment: fixed
> > >>> > >
> > >>> > > // -- LABEL
> > >>> > > - .span
> > >>> > > + span
> > >>> > > cursor: pointer
> > >>> > > position: absolute
> > >>> > > margin: 0
> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > components/_slider.sass
> > >>> > >
> > >>>b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> > >>> > > index f92fdd0..115df2c 100644
> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/components/_
> > >>> slider.sass
> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/components/_
> > >>> slider.sass
> > >>> > > @@ -19,7 +19,7 @@
> > >>> > >
> > >>> > > .jewel.slider
> > >>> > >
> > >>> > > - .slider
> > >>> > > + input
> > >>> > > -webkit-appearance: none
> > >>> > > width: 100%
> > >>> > > height: 15px
> > >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > components/_textfield.sass
> > >>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
> > >>> textfield.sass
> > >>> > > index 4165f6d..3e04d9a 100644
> > >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > > components/_textfield.sass
> > >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> > >>> > > components/_textfield.sass
> > >>> > > @@ -32,7 +32,7 @@ $textfield-border-radius: 3px
> > >>> > > position: relative
> > >>> > > display: inline-flex
> > >>> > >
> > >>> > > - .input
> > >>> > > + input
> > >>> > > margin: $textfield-margin
> > >>> > > padding: $textfield-padding
> > >>> > >
> > >>> > >
> > >>> > > --
> > >>> > > To stop receiving notification emails like this one, please
> contact
> > >>> > > carlosrovira@apache.org.
> > >>> > >
> > >>> >
> > >>> >
> > >>> >
> > >>> > --
> > >>> >
> > >>> > Piotr Zarzycki
> > >>> >
> > >>> > Patreon:
> > >>>*https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fwww.pa
> > >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> > %7Ca45baaa226
> > >>>d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C6365
> > >>>77359996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> > 2B5E%3D&
> > >>>reserved=0
> > >>> >
> > >>><https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fwww.pa
> > >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> > %7Ca45baaa226
> > >>>d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C6365
> > >>>77359996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> > 2B5E%3D&
> > >>>reserved=0>*
> > >>> >
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Carlos Rovira
> > >>>
> > >>>https://na01.safelinks.protection.outlook.com/?url=
> > http%3A%2F%2Fabout.me
> > >>>%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%
> > 7Ca45baaa226d74ff0dad6
> > >>>08d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C63657735999667
> > >>>7198&sdata=BbM3FSzf3YGLSzq10huJ2EUfTkZ9%2BoqZeYmLKTV5aN0%3D&reserved=0
> > >>>
> > >>
> > >>
> > >>
> > >> --
> > >>
> > >> Piotr Zarzycki
> > >>
> > >> Patreon:
> > >>*https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fwww.pat
> > >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> > %7Ca45baaa226d7
> > >>4ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C6365773
> > >>59996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> > 2B5E%3D&rese
> > >>rved=0
> > >>
> > >><https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fwww.pat
> > >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> > %7Ca45baaa226d7
> > >>4ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C6365773
> > >>59996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> > 2B5E%3D&rese
> > >>rved=0>*
> > >>
> > >
> > >
> > >
> > >--
> > >
> > >Piotr Zarzycki
> > >
> > >Patreon:
> > >*https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fwww.patr
> > >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%
> > 7Ca45baaa226d74f
> > >f0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C6365773599
> > >96677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> > 2B5E%3D&reserved
> > >=0
> > ><https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fwww.patr
> > >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%
> > 7Ca45baaa226d74f
> > >f0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C6365773599
> > >96677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> > 2B5E%3D&reserved
> > >=0>*
> >
> >
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
Re: [royale-asjs] branch feature/jewel-ui-set updated: removes
workaround for element styles thanks to bugs #30/#32 solved
Posted by Carlos Rovira <ca...@apache.org>.
I think other way to do this with an "amend" command? (at least to add
forgotten content to a commit..
2018-03-27 18:18 GMT+02:00 Alex Harui <ah...@adobe.com.invalid>:
> Hi Piotr,
>
> Are you sure it is safe to change commit messages? I see some articles
> saying that it is unsafe.
>
> Thoughts?
> -Alex
>
> On 3/27/18, 1:26 AM, "Piotr Zarzycki" <pi...@gmail.com> wrote:
>
> >I just pushed changes -> Checkout how it looks like now ->
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.co
> >m%2Fapache%2Froyale-asjs%2Fcommit%2Fdf9808dc6ad261d33e58715c4644
> 8a1da5ee50
> >ad&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74ff0dad608d593bc
> 75c4%7C
> >fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636577359996677198&sdata=
> agZM7t
> >aOsrP2Zy99%2FP5iwKwWfCqeucpm5PNmC6fbQmg%3D&reserved=0
> >
> >2018-03-27 10:22 GMT+02:00 Piotr Zarzycki <pi...@gmail.com>:
> >
> >> I will change message in your last commit. Yes that is how are you
> >>linking
> >> to the other repository. If it will be in typedefs you will do:
> >> apache/royale-typedefs#number
> >>
> >> 2018-03-27 10:17 GMT+02:00 Carlos Rovira <ca...@apache.org>:
> >>
> >>> Hi Piotr,
> >>> thanks! I didn't realize that it's not the same repo, so for compiler I
> >>> must put "apache/royale-compiler#<number>" ? Thanks, I'll do the next
> >>> time!
> >>> :)
> >>>
> >>> 2018-03-27 10:13 GMT+02:00 Piotr Zarzycki <pi...@gmail.com>:
> >>>
> >>> > Hi Carlos,
> >>> >
> >>> > And again if you add in the description apache/royale-compiler#30 and
> >>> > apache/royale-compiler#32 it will point to the proper issue. Now you
> >>> are
> >>> > pointing to some closed issue in asjs which is totally unrelated.
> >>> >
> >>> > Thanks,
> >>> > Piotr
> >>> >
> >>> > 2018-03-27 10:02 GMT+02:00 <ca...@apache.org>:
> >>> >
> >>> > > This is an automated email from the ASF dual-hosted git repository.
> >>> > >
> >>> > > carlosrovira pushed a commit to branch feature/jewel-ui-set
> >>> > > in repository
> >>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox
> .
> >>>apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%
> 7C01%7Caharui%40adobe
> >>>.com%7Ca45baaa226d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> ce
> >>>e1%7C0%7C0%7C636577359996677198&sdata=D3YDt7MXbmAhxG4D4zhxH2Hdrx8HtX
> mhWf
> >>>FL4704jOA%3D&reserved=0
> >>> > >
> >>> > >
> >>> > > The following commit(s) were added to
> >>>refs/heads/feature/jewel-ui-set
> >>> by
> >>> > > this push:
> >>> > > new 10d993c removes workaround for element styles thanks to
> >>>bugs
> >>> > > #30/#32 solved
> >>> > > 10d993c is described below
> >>> > >
> >>> > > commit 10d993c21ef554019a249a8355e007adbab07ca8
> >>> > > Author: Carlos Rovira <ca...@apache.org>
> >>> > > AuthorDate: Tue Mar 27 10:02:00 2018 +0200
> >>> > >
> >>> > > removes workaround for element styles thanks to bugs #30/#32
> >>> solved
> >>> > > ---
> >>> > > .../src/main/resources/jewel-example-styles.css | 7 +++-
> >>> > > .../src/main/royale/RadioButtonPlayGround.mxml | 2 +-
> >>> > > .../royale/org/apache/royale/jewel/CheckBox.as | 4 +-
> >>> > > .../royale/org/apache/royale/jewel/RadioButton.as | 4 +-
> >>> > > .../main/royale/org/apache/royale/jewel/Slider.as | 2 +-
> >>> > > .../royale/org/apache/royale/jewel/TextField.as | 2 +-
> >>> > > .../JewelTheme/src/main/resources/defaults.css | 48
> >>> > > +++++++++++-----------
> >>> > > .../src/main/sass/components/_checkbox.sass | 4 +-
> >>> > > .../src/main/sass/components/_radiobutton.sass | 4 +-
> >>> > > .../src/main/sass/components/_slider.sass | 2 +-
> >>> > > .../src/main/sass/components/_textfield.sass | 2 +-
> >>> > > 11 files changed, 42 insertions(+), 39 deletions(-)
> >>> > >
> >>> > > diff --git a/examples/royale/JewelExample/src/main/
> >>> > > resources/jewel-example-styles.css b/examples/royale/
> >>> > > JewelExample/src/main/resources/jewel-example-styles.css
> >>> > > index 003d6c8..c2ea379 100644
> >>> > > ---
> >>>a/examples/royale/JewelExample/src/main/resources/jewel-example-
> >>> > > styles.css
> >>> > > +++
> >>>b/examples/royale/JewelExample/src/main/resources/jewel-example-
> >>> > > styles.css
> >>> > > @@ -21,10 +21,13 @@
> >>> > >
> >>> > > @namespace
> >>>"https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.w3
> .
> >>>org%2F1999%2Fxhtml&data=02%7C01%7Caharui%40adobe.com%
> 7Ca45baaa226d74ff0d
> >>>ad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C63657735999
> >>>6677198&sdata=hCL1lfhr1M7AHjRbVVHmuupkJGR1nh
> 2m5GSh0skwrAk%3D&reserved=0"
> >>>;
> >>> > >
> >>> > > -
> >>> > > +body{
> >>> > > + background: #fff;
> >>> > > +}
> >>> > >
> >>> > > .container {
> >>> > > background: #efefef;
> >>> > > border-radius: 10px;
> >>> > > padding: 20px;
> >>> > > -}
> >>> > > \ No newline at end of file
> >>> > > +}
> >>> > > +
> >>> > > \ No newline at end of file
> >>> > > diff --git a/examples/royale/JewelExample/src/main/royale/
> >>> > RadioButtonPlayGround.mxml
> >>> > > b/examples/royale/JewelExample/src/main/royale/
> >>> > RadioButtonPlayGround.mxml
> >>> > > index 3d34b18..9e6806d 100644
> >>> > > --- a/examples/royale/JewelExample/src/main/royale/
> >>> > > RadioButtonPlayGround.mxml
> >>> > > +++ b/examples/royale/JewelExample/src/main/royale/
> >>> > > RadioButtonPlayGround.mxml
> >>> > > @@ -30,7 +30,7 @@ limitations under the License.
> >>> > > <html:H3 text="Jewel RadioButton"/>
> >>> > >
> >>> > > <j:RadioButton text="RadioButton 1" groupName="radios"
> >>> > value="Test
> >>> > > 1"/>
> >>> > > - <j:RadioButton text="RadioButton 2" groupName="radios"
> >>> > value="Test
> >>> > > 2"/>
> >>> > > + <j:RadioButton text="RadioButton 2" groupName="radios"
> >>> > value="Test
> >>> > > 2" selected="true"/>
> >>> > > <j:RadioButton text="RadioButton 3" groupName="radios"
> >>> > value="Test
> >>> > > 3"/>
> >>> > >
> >>> > > <j:RadioButton text="Disabled">
> >>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > royale/jewel/CheckBox.as
> >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/CheckBox.as
> >>> > > index d69fad6..5c78dbc 100644
> >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/CheckBox.as
> >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/CheckBox.as
> >>> > > @@ -99,11 +99,11 @@ package org.apache.royale.jewel
> >>> > >
> >>> > > input = addElementToWrapper(this,'input') as
> >>> > > HTMLInputElement;
> >>> > > input.type = 'checkbox';
> >>> > > - input.className = 'input';
> >>> > > + //input.className = 'input';
> >>> > > label.appendChild(input);
> >>> > >
> >>> > > checkbox = document.createElement('span') as
> >>> > HTMLSpanElement;
> >>> > > - checkbox.className = 'span';
> >>> > > + //checkbox.className = 'span';
> >>> > > label.appendChild(checkbox);
> >>> > >
> >>> > > positioner = label as WrappedHTMLElement;
> >>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > royale/jewel/RadioButton.as
> >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/RadioButton.as
> >>> > > index 19d5981..b36b51a 100644
> >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/RadioButton.as
> >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/RadioButton.as
> >>> > > @@ -316,14 +316,14 @@ package org.apache.royale.jewel
> >>> > >
> >>> > > icon = addElementToWrapper(this,'input') as
> >>> > HTMLInputElement;
> >>> > > icon.type = "radio";
> >>> > > - icon.className = 'input';
> >>> > > + //icon.className = 'input';
> >>> > > icon.id = '_radio_' + + Math.random();
> >>> > > label.appendChild(icon);
> >>> > >
> >>> > > textNode = document.createTextNode('') as Text;
> >>> > >
> >>> > > radio = document.createElement('span') as
> >>> HTMLSpanElement;
> >>> > > - radio.className = 'span';
> >>> > > + //radio.className = 'span';
> >>> > > radio.appendChild(textNode);
> >>> > > label.appendChild(radio);
> >>> > > //radio.addEventListener('mouseover',
> >>>mouseOverHandler,
> >>> > > false);
> >>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > royale/jewel/Slider.as
> >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/Slider.as
> >>> > > index 0cb0101..a9ddbbe 100644
> >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/Slider.as
> >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/Slider.as
> >>> > > @@ -184,7 +184,7 @@ package org.apache.royale.jewel
> >>> > >
> >>> > > var input:HTMLInputElement =
> >>>addElementToWrapper(this,'
> >>> > input')
> >>> > > as HTMLInputElement;
> >>> > > input.setAttribute('type', 'range');
> >>> > > - input.className = "slider";
> >>> > > + //input.className = "slider";
> >>> > >
> >>> > > //attach input handler to dispatch royale
> >>> change
> >>> > > event when user write in textinput
> >>> > > //goog.events.listen(element, 'change',
> >>> killChangeHandler);
> >>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > royale/jewel/TextField.as
> >>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/TextField.as
> >>> > > index 1c12711..a5d5c1c 100644
> >>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/TextField.as
> >>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> >>> > > royale/jewel/TextField.as
> >>> > > @@ -82,7 +82,7 @@ package org.apache.royale.jewel
> >>> > >
> >>> > > input = addElementToWrapper(this,'input') as
> >>> > > HTMLInputElement;
> >>> > > input.setAttribute('type', 'text');
> >>> > > - input.className = "input";
> >>> > > + //input.className = "input";
> >>> > >
> >>> > > //attach input handler to dispatch royale change event
> >>> when
> >>> > > user write in textinput
> >>> > > //goog.events.listen(element, 'change',
> >>> killChangeHandler);
> >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/resources/
> >>> > defaults.css
> >>> > > b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> >>> > > index 8f90431..e23ebd2 100644
> >>> > > --- a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> >>> > > +++ b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> >>> > > @@ -196,7 +196,7 @@ div {
> >>> > > width: 100%;
> >>> > > height: 22px;
> >>> > > }
> >>> > > -.jewel.checkbox .input {
> >>> > > +.jewel.checkbox input {
> >>> > > -webkit-appearance: none;
> >>> > > -moz-appearance: none;
> >>> > > -o-appearance: none;
> >>> > > @@ -212,26 +212,26 @@ div {
> >>> > > border: 1px solid #b3b3b3;
> >>> > > border-radius: 3px;
> >>> > > }
> >>> > > -.jewel.checkbox .input:checked, .jewel.checkbox
> >>> .input:checked:active {
> >>> > > +.jewel.checkbox input:checked, .jewel.checkbox
> >>>input:checked:active {
> >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16
> >>>13'
> >>> > > version='1.1'
> >>>xmlns='https://na01.safelinks.protection.outlook.
> com/?url=http%3A%2F%2Fw
> >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> %7Ca45baaa226d74
> >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365773
> >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> 3D&reser
> >>>ved=0'><g
> >>> > > transform='translate(-763, -290)'><g transform='translate(760,
> >>> > > 285)'><g><polygon fill='#3CADF1' points='3 13 9 18 19 7 16 5 9 13 6
> >>> > > 10'></polygon></g></g></g></svg>");
> >>> > > background-repeat: no-repeat;
> >>> > > background-size: 90%;
> >>> > > background-position: center;
> >>> > > background-attachment: fixed;
> >>> > > }
> >>> > > -.jewel.checkbox .input:focus {
> >>> > > +.jewel.checkbox input:focus {
> >>> > > outline: none;
> >>> > > border: 1px solid #0f88d1;
> >>> > > }
> >>> > > -.jewel.checkbox .input[disabled] {
> >>> > > +.jewel.checkbox input[disabled] {
> >>> > > cursor: unset;
> >>> > > border: 1px solid #c6c6c6;
> >>> > > background: #F9F9F9;
> >>> > > }
> >>> > > -.jewel.checkbox .input[disabled] + .span {
> >>> > > +.jewel.checkbox input[disabled] + .span {
> >>> > > color: #c6c6c6;
> >>> > > }
> >>> > > -.jewel.checkbox .input[disabled]:checked {
> >>> > > +.jewel.checkbox input[disabled]:checked {
> >>> > > border: 1px solid #c6c6c6;
> >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16
> >>>13'
> >>> > > version='1.1'
> >>>xmlns='https://na01.safelinks.protection.outlook.
> com/?url=http%3A%2F%2Fw
> >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> %7Ca45baaa226d74
> >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365773
> >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> 3D&reser
> >>>ved=0'><g
> >>> > > transform='translate(-763, -290)'><g transform='translate(760,
> >>> > > 285)'><g><polygon fill='lightgray' points='3 13 9 18 19 7 16 5 9
> >>>13 6
> >>> > > 10'></polygon></g></g></g></svg>");
> >>> > > background-size: 90%;
> >>> > > @@ -239,7 +239,7 @@ div {
> >>> > > background-repeat: no-repeat;
> >>> > > background-attachment: fixed;
> >>> > > }
> >>> > > -.jewel.checkbox .span {
> >>> > > +.jewel.checkbox span {
> >>> > > cursor: pointer;
> >>> > > position: absolute;
> >>> > > margin: 0;
> >>> > > @@ -262,7 +262,7 @@ div {
> >>> > > width: 100%;
> >>> > > height: 22px;
> >>> > > }
> >>> > > -.jewel.radiobutton .input {
> >>> > > +.jewel.radiobutton input {
> >>> > > -webkit-appearance: none;
> >>> > > -moz-appearance: none;
> >>> > > -o-appearance: none;
> >>> > > @@ -278,26 +278,26 @@ div {
> >>> > > border: 1px solid #b3b3b3;
> >>> > > border-radius: 50%;
> >>> > > }
> >>> > > -.jewel.radiobutton .input:checked, .jewel.radiobutton
> >>> > > .input:checked:active {
> >>> > > +.jewel.radiobutton input:checked, .jewel.radiobutton
> >>> > input:checked:active
> >>> > > {
> >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12
> >>>12'
> >>> > > version='1.1'
> >>>xmlns='https://na01.safelinks.protection.outlook.
> com/?url=http%3A%2F%2Fw
> >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> %7Ca45baaa226d74
> >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365773
> >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> 3D&reser
> >>>ved=0'><g
> >>> > > transform='translate(-616, -350)'><g transform='translate(611,
> >>> > > 345)'><g><circle fill='#3CADF1' cx='11' cy='11'
> >>> > > r='6'></circle></g></g></g></svg>");
> >>> > > background-repeat: no-repeat;
> >>> > > background-size: 60%;
> >>> > > background-position: center;
> >>> > > background-attachment: fixed;
> >>> > > }
> >>> > > -.jewel.radiobutton .input:focus {
> >>> > > +.jewel.radiobutton input:focus {
> >>> > > outline: none;
> >>> > > border: 1px solid #0f88d1;
> >>> > > }
> >>> > > -.jewel.radiobutton .input[disabled] {
> >>> > > +.jewel.radiobutton input[disabled] {
> >>> > > cursor: unset;
> >>> > > border: 1px solid #c6c6c6;
> >>> > > background: #F9F9F9;
> >>> > > }
> >>> > > -.jewel.radiobutton .input[disabled] + .span {
> >>> > > +.jewel.radiobutton input[disabled] + .span {
> >>> > > color: #c6c6c6;
> >>> > > }
> >>> > > -.jewel.radiobutton .input[disabled]:checked {
> >>> > > +.jewel.radiobutton input[disabled]:checked {
> >>> > > border: 1px solid #c6c6c6;
> >>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12
> >>>12'
> >>> > > version='1.1'
> >>>xmlns='https://na01.safelinks.protection.outlook.
> com/?url=http%3A%2F%2Fw
> >>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com
> %7Ca45baaa226d74
> >>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365773
> >>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%
> 3D&reser
> >>>ved=0'><g
> >>> > > transform='translate(-616, -350)'><g transform='translate(611,
> >>> > > 345)'><g><circle fill='lightgray' cx='11' cy='11'
> >>> > > r='6'></circle></g></g></g></svg>");
> >>> > > background-size: 60%;
> >>> > > @@ -305,7 +305,7 @@ div {
> >>> > > background-repeat: no-repeat;
> >>> > > background-attachment: fixed;
> >>> > > }
> >>> > > -.jewel.radiobutton .span {
> >>> > > +.jewel.radiobutton span {
> >>> > > cursor: pointer;
> >>> > > position: absolute;
> >>> > > margin: 0;
> >>> > > @@ -314,7 +314,7 @@ div {
> >>> > > line-height: 22px;
> >>> > > }
> >>> > >
> >>> > > -.jewel.slider .slider {
> >>> > > +.jewel.slider input {
> >>> > > -webkit-appearance: none;
> >>> > > width: 100%;
> >>> > > height: 15px;
> >>> > > @@ -325,13 +325,13 @@ div {
> >>> > > -webkit-transition: 0.2s;
> >>> > > transition: opacity 0.2s;
> >>> > > }
> >>> > > -.jewel.slider .slider:hover {
> >>> > > +.jewel.slider input:hover {
> >>> > > opacity: 1;
> >>> > > }
> >>> > > -.jewel.slider .slider:focus {
> >>> > > +.jewel.slider input:focus {
> >>> > > outline: none;
> >>> > > }
> >>> > > -.jewel.slider .slider::-webkit-slider-thumb {
> >>> > > +.jewel.slider input::-webkit-slider-thumb {
> >>> > > -webkit-appearance: none;
> >>> > > appearance: none;
> >>> > > width: 15px;
> >>> > > @@ -340,7 +340,7 @@ div {
> >>> > > background: #3CADF1;
> >>> > > cursor: pointer;
> >>> > > }
> >>> > > -.jewel.slider .slider::-moz-range-thumb {
> >>> > > +.jewel.slider input::-moz-range-thumb {
> >>> > > width: 15px;
> >>> > > height: 15px;
> >>> > > border-radius: 50%;
> >>> > > @@ -523,7 +523,7 @@ div {
> >>> > > position: relative;
> >>> > > display: inline-flex;
> >>> > > }
> >>> > > -.jewel.textfield .input {
> >>> > > +.jewel.textfield input {
> >>> > > margin: 0;
> >>> > > padding: 0.67em 1em;
> >>> > > max-width: 100%;
> >>> > > @@ -542,20 +542,20 @@ div {
> >>> > > transition-duration: 0.3s;
> >>> > > transition-timing-function: easein;
> >>> > > }
> >>> > > -.jewel.textfield .input:focus {
> >>> > > +.jewel.textfield input:focus {
> >>> > > border: 1px solid #0f88d1;
> >>> > > }
> >>> > > -.jewel.textfield .input::placeholder {
> >>> > > +.jewel.textfield input::placeholder {
> >>> > > color: #a6a6a6;
> >>> > > }
> >>> > > -.jewel.textfield .input[disabled] {
> >>> > > +.jewel.textfield input[disabled] {
> >>> > > cursor: unset;
> >>> > > border: 1px solid #c6c6c6;
> >>> > > background: #F9F9F9;
> >>> > > box-shadow: none;
> >>> > > color: #c6c6c6;
> >>> > > }
> >>> > > -.jewel.textfield .input[disabled]::placeholder {
> >>> > > +.jewel.textfield input[disabled]::placeholder {
> >>> > > color: #c6c6c6;
> >>> > > }
> >>> > >
> >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> >>> > components/_checkbox.sass
> >>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
> >>> checkbox.sass
> >>> > > index e79c952..92f4fd0 100644
> >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> >>> > components/_checkbox.sass
> >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> >>> > components/_checkbox.sass
> >>> > > @@ -39,7 +39,7 @@ $checkbox-label-font-size: 16px
> >>> > > height: $checkbox-button-size
> >>> > >
> >>> > > // -- INPUT
> >>> > > - .input
> >>> > > + input
> >>> > > +appear(none)
> >>> > > cursor: pointer
> >>> > > display: inline-block
> >>> > > @@ -102,7 +102,7 @@ $checkbox-label-font-size: 16px
> >>> > > //background: $disabled-color
> >>> > >
> >>> > > // -- LABEL
> >>> > > - .span
> >>> > > + span
> >>> > > cursor: pointer
> >>> > > position: absolute
> >>> > > margin: 0
> >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> >>> > components/_radiobutton.sass
> >>> > > b/frameworks/themes/JewelTheme/src/main/sass/
> >>> > components/_radiobutton.sass
> >>> > > index a224f28..d45a56a 100644
> >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> >>> > > components/_radiobutton.sass
> >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> >>> > > components/_radiobutton.sass
> >>> > > @@ -39,7 +39,7 @@ $radiobutton-label-font-size: 16px
> >>> > > height: $radiobutton-button-size
> >>> > >
> >>> > > // -- INPUT
> >>> > > - .input
> >>> > > + input
> >>> > > +appear(none)
> >>> > > cursor: pointer
> >>> > > display: inline-block
> >>> > > @@ -93,7 +93,7 @@ $radiobutton-label-font-size: 16px
> >>> > > background-attachment: fixed
> >>> > >
> >>> > > // -- LABEL
> >>> > > - .span
> >>> > > + span
> >>> > > cursor: pointer
> >>> > > position: absolute
> >>> > > margin: 0
> >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> >>> > components/_slider.sass
> >>> > >
> >>>b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> >>> > > index f92fdd0..115df2c 100644
> >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/components/_
> >>> slider.sass
> >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/components/_
> >>> slider.sass
> >>> > > @@ -19,7 +19,7 @@
> >>> > >
> >>> > > .jewel.slider
> >>> > >
> >>> > > - .slider
> >>> > > + input
> >>> > > -webkit-appearance: none
> >>> > > width: 100%
> >>> > > height: 15px
> >>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> >>> > components/_textfield.sass
> >>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
> >>> textfield.sass
> >>> > > index 4165f6d..3e04d9a 100644
> >>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> >>> > > components/_textfield.sass
> >>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> >>> > > components/_textfield.sass
> >>> > > @@ -32,7 +32,7 @@ $textfield-border-radius: 3px
> >>> > > position: relative
> >>> > > display: inline-flex
> >>> > >
> >>> > > - .input
> >>> > > + input
> >>> > > margin: $textfield-margin
> >>> > > padding: $textfield-padding
> >>> > >
> >>> > >
> >>> > > --
> >>> > > To stop receiving notification emails like this one, please contact
> >>> > > carlosrovira@apache.org.
> >>> > >
> >>> >
> >>> >
> >>> >
> >>> > --
> >>> >
> >>> > Piotr Zarzycki
> >>> >
> >>> > Patreon:
> >>>*https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pa
> >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> %7Ca45baaa226
> >>>d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365
> >>>77359996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> 2B5E%3D&
> >>>reserved=0
> >>> >
> >>><https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pa
> >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> %7Ca45baaa226
> >>>d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365
> >>>77359996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> 2B5E%3D&
> >>>reserved=0>*
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>> Carlos Rovira
> >>>
> >>>https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fabout.me
> >>>%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%
> 7Ca45baaa226d74ff0dad6
> >>>08d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C63657735999667
> >>>7198&sdata=BbM3FSzf3YGLSzq10huJ2EUfTkZ9%2BoqZeYmLKTV5aN0%3D&reserved=0
> >>>
> >>
> >>
> >>
> >> --
> >>
> >> Piotr Zarzycki
> >>
> >> Patreon:
> >>*https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pat
> >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> %7Ca45baaa226d7
> >>4ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365773
> >>59996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> 2B5E%3D&rese
> >>rved=0
> >>
> >><https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pat
> >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
> %7Ca45baaa226d7
> >>4ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365773
> >>59996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> 2B5E%3D&rese
> >>rved=0>*
> >>
> >
> >
> >
> >--
> >
> >Piotr Zarzycki
> >
> >Patreon:
> >*https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patr
> >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%
> 7Ca45baaa226d74f
> >f0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365773599
> >96677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> 2B5E%3D&reserved
> >=0
> ><https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patr
> >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%
> 7Ca45baaa226d74f
> >f0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365773599
> >96677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%
> 2B5E%3D&reserved
> >=0>*
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [royale-asjs] branch feature/jewel-ui-set updated: removes
workaround for element styles thanks to bugs #30/#32 solved
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Hi Piotr,
Are you sure it is safe to change commit messages? I see some articles
saying that it is unsafe.
Thoughts?
-Alex
On 3/27/18, 1:26 AM, "Piotr Zarzycki" <pi...@gmail.com> wrote:
>I just pushed changes -> Checkout how it looks like now ->
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
>m%2Fapache%2Froyale-asjs%2Fcommit%2Fdf9808dc6ad261d33e58715c46448a1da5ee50
>ad&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74ff0dad608d593bc75c4%7C
>fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636577359996677198&sdata=agZM7t
>aOsrP2Zy99%2FP5iwKwWfCqeucpm5PNmC6fbQmg%3D&reserved=0
>
>2018-03-27 10:22 GMT+02:00 Piotr Zarzycki <pi...@gmail.com>:
>
>> I will change message in your last commit. Yes that is how are you
>>linking
>> to the other repository. If it will be in typedefs you will do:
>> apache/royale-typedefs#number
>>
>> 2018-03-27 10:17 GMT+02:00 Carlos Rovira <ca...@apache.org>:
>>
>>> Hi Piotr,
>>> thanks! I didn't realize that it's not the same repo, so for compiler I
>>> must put "apache/royale-compiler#<number>" ? Thanks, I'll do the next
>>> time!
>>> :)
>>>
>>> 2018-03-27 10:13 GMT+02:00 Piotr Zarzycki <pi...@gmail.com>:
>>>
>>> > Hi Carlos,
>>> >
>>> > And again if you add in the description apache/royale-compiler#30 and
>>> > apache/royale-compiler#32 it will point to the proper issue. Now you
>>> are
>>> > pointing to some closed issue in asjs which is totally unrelated.
>>> >
>>> > Thanks,
>>> > Piotr
>>> >
>>> > 2018-03-27 10:02 GMT+02:00 <ca...@apache.org>:
>>> >
>>> > > This is an automated email from the ASF dual-hosted git repository.
>>> > >
>>> > > carlosrovira pushed a commit to branch feature/jewel-ui-set
>>> > > in repository
>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.
>>>apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe
>>>.com%7Ca45baaa226d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178dece
>>>e1%7C0%7C0%7C636577359996677198&sdata=D3YDt7MXbmAhxG4D4zhxH2Hdrx8HtXmhWf
>>>FL4704jOA%3D&reserved=0
>>> > >
>>> > >
>>> > > The following commit(s) were added to
>>>refs/heads/feature/jewel-ui-set
>>> by
>>> > > this push:
>>> > > new 10d993c removes workaround for element styles thanks to
>>>bugs
>>> > > #30/#32 solved
>>> > > 10d993c is described below
>>> > >
>>> > > commit 10d993c21ef554019a249a8355e007adbab07ca8
>>> > > Author: Carlos Rovira <ca...@apache.org>
>>> > > AuthorDate: Tue Mar 27 10:02:00 2018 +0200
>>> > >
>>> > > removes workaround for element styles thanks to bugs #30/#32
>>> solved
>>> > > ---
>>> > > .../src/main/resources/jewel-example-styles.css | 7 +++-
>>> > > .../src/main/royale/RadioButtonPlayGround.mxml | 2 +-
>>> > > .../royale/org/apache/royale/jewel/CheckBox.as | 4 +-
>>> > > .../royale/org/apache/royale/jewel/RadioButton.as | 4 +-
>>> > > .../main/royale/org/apache/royale/jewel/Slider.as | 2 +-
>>> > > .../royale/org/apache/royale/jewel/TextField.as | 2 +-
>>> > > .../JewelTheme/src/main/resources/defaults.css | 48
>>> > > +++++++++++-----------
>>> > > .../src/main/sass/components/_checkbox.sass | 4 +-
>>> > > .../src/main/sass/components/_radiobutton.sass | 4 +-
>>> > > .../src/main/sass/components/_slider.sass | 2 +-
>>> > > .../src/main/sass/components/_textfield.sass | 2 +-
>>> > > 11 files changed, 42 insertions(+), 39 deletions(-)
>>> > >
>>> > > diff --git a/examples/royale/JewelExample/src/main/
>>> > > resources/jewel-example-styles.css b/examples/royale/
>>> > > JewelExample/src/main/resources/jewel-example-styles.css
>>> > > index 003d6c8..c2ea379 100644
>>> > > ---
>>>a/examples/royale/JewelExample/src/main/resources/jewel-example-
>>> > > styles.css
>>> > > +++
>>>b/examples/royale/JewelExample/src/main/resources/jewel-example-
>>> > > styles.css
>>> > > @@ -21,10 +21,13 @@
>>> > >
>>> > > @namespace
>>>"https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.w3.
>>>org%2F1999%2Fxhtml&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74ff0d
>>>ad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63657735999
>>>6677198&sdata=hCL1lfhr1M7AHjRbVVHmuupkJGR1nh2m5GSh0skwrAk%3D&reserved=0"
>>>;
>>> > >
>>> > > -
>>> > > +body{
>>> > > + background: #fff;
>>> > > +}
>>> > >
>>> > > .container {
>>> > > background: #efefef;
>>> > > border-radius: 10px;
>>> > > padding: 20px;
>>> > > -}
>>> > > \ No newline at end of file
>>> > > +}
>>> > > +
>>> > > \ No newline at end of file
>>> > > diff --git a/examples/royale/JewelExample/src/main/royale/
>>> > RadioButtonPlayGround.mxml
>>> > > b/examples/royale/JewelExample/src/main/royale/
>>> > RadioButtonPlayGround.mxml
>>> > > index 3d34b18..9e6806d 100644
>>> > > --- a/examples/royale/JewelExample/src/main/royale/
>>> > > RadioButtonPlayGround.mxml
>>> > > +++ b/examples/royale/JewelExample/src/main/royale/
>>> > > RadioButtonPlayGround.mxml
>>> > > @@ -30,7 +30,7 @@ limitations under the License.
>>> > > <html:H3 text="Jewel RadioButton"/>
>>> > >
>>> > > <j:RadioButton text="RadioButton 1" groupName="radios"
>>> > value="Test
>>> > > 1"/>
>>> > > - <j:RadioButton text="RadioButton 2" groupName="radios"
>>> > value="Test
>>> > > 2"/>
>>> > > + <j:RadioButton text="RadioButton 2" groupName="radios"
>>> > value="Test
>>> > > 2" selected="true"/>
>>> > > <j:RadioButton text="RadioButton 3" groupName="radios"
>>> > value="Test
>>> > > 3"/>
>>> > >
>>> > > <j:RadioButton text="Disabled">
>>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > royale/jewel/CheckBox.as
>>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/CheckBox.as
>>> > > index d69fad6..5c78dbc 100644
>>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/CheckBox.as
>>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/CheckBox.as
>>> > > @@ -99,11 +99,11 @@ package org.apache.royale.jewel
>>> > >
>>> > > input = addElementToWrapper(this,'input') as
>>> > > HTMLInputElement;
>>> > > input.type = 'checkbox';
>>> > > - input.className = 'input';
>>> > > + //input.className = 'input';
>>> > > label.appendChild(input);
>>> > >
>>> > > checkbox = document.createElement('span') as
>>> > HTMLSpanElement;
>>> > > - checkbox.className = 'span';
>>> > > + //checkbox.className = 'span';
>>> > > label.appendChild(checkbox);
>>> > >
>>> > > positioner = label as WrappedHTMLElement;
>>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > royale/jewel/RadioButton.as
>>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/RadioButton.as
>>> > > index 19d5981..b36b51a 100644
>>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/RadioButton.as
>>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/RadioButton.as
>>> > > @@ -316,14 +316,14 @@ package org.apache.royale.jewel
>>> > >
>>> > > icon = addElementToWrapper(this,'input') as
>>> > HTMLInputElement;
>>> > > icon.type = "radio";
>>> > > - icon.className = 'input';
>>> > > + //icon.className = 'input';
>>> > > icon.id = '_radio_' + + Math.random();
>>> > > label.appendChild(icon);
>>> > >
>>> > > textNode = document.createTextNode('') as Text;
>>> > >
>>> > > radio = document.createElement('span') as
>>> HTMLSpanElement;
>>> > > - radio.className = 'span';
>>> > > + //radio.className = 'span';
>>> > > radio.appendChild(textNode);
>>> > > label.appendChild(radio);
>>> > > //radio.addEventListener('mouseover',
>>>mouseOverHandler,
>>> > > false);
>>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > royale/jewel/Slider.as
>>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/Slider.as
>>> > > index 0cb0101..a9ddbbe 100644
>>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/Slider.as
>>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/Slider.as
>>> > > @@ -184,7 +184,7 @@ package org.apache.royale.jewel
>>> > >
>>> > > var input:HTMLInputElement =
>>>addElementToWrapper(this,'
>>> > input')
>>> > > as HTMLInputElement;
>>> > > input.setAttribute('type', 'range');
>>> > > - input.className = "slider";
>>> > > + //input.className = "slider";
>>> > >
>>> > > //attach input handler to dispatch royale
>>> change
>>> > > event when user write in textinput
>>> > > //goog.events.listen(element, 'change',
>>> killChangeHandler);
>>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > royale/jewel/TextField.as
>>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/TextField.as
>>> > > index 1c12711..a5d5c1c 100644
>>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/TextField.as
>>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>>> > > royale/jewel/TextField.as
>>> > > @@ -82,7 +82,7 @@ package org.apache.royale.jewel
>>> > >
>>> > > input = addElementToWrapper(this,'input') as
>>> > > HTMLInputElement;
>>> > > input.setAttribute('type', 'text');
>>> > > - input.className = "input";
>>> > > + //input.className = "input";
>>> > >
>>> > > //attach input handler to dispatch royale change event
>>> when
>>> > > user write in textinput
>>> > > //goog.events.listen(element, 'change',
>>> killChangeHandler);
>>> > > diff --git a/frameworks/themes/JewelTheme/src/main/resources/
>>> > defaults.css
>>> > > b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
>>> > > index 8f90431..e23ebd2 100644
>>> > > --- a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
>>> > > +++ b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
>>> > > @@ -196,7 +196,7 @@ div {
>>> > > width: 100%;
>>> > > height: 22px;
>>> > > }
>>> > > -.jewel.checkbox .input {
>>> > > +.jewel.checkbox input {
>>> > > -webkit-appearance: none;
>>> > > -moz-appearance: none;
>>> > > -o-appearance: none;
>>> > > @@ -212,26 +212,26 @@ div {
>>> > > border: 1px solid #b3b3b3;
>>> > > border-radius: 3px;
>>> > > }
>>> > > -.jewel.checkbox .input:checked, .jewel.checkbox
>>> .input:checked:active {
>>> > > +.jewel.checkbox input:checked, .jewel.checkbox
>>>input:checked:active {
>>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16
>>>13'
>>> > > version='1.1'
>>>xmlns='https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fw
>>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74
>>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365773
>>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%3D&reser
>>>ved=0'><g
>>> > > transform='translate(-763, -290)'><g transform='translate(760,
>>> > > 285)'><g><polygon fill='#3CADF1' points='3 13 9 18 19 7 16 5 9 13 6
>>> > > 10'></polygon></g></g></g></svg>");
>>> > > background-repeat: no-repeat;
>>> > > background-size: 90%;
>>> > > background-position: center;
>>> > > background-attachment: fixed;
>>> > > }
>>> > > -.jewel.checkbox .input:focus {
>>> > > +.jewel.checkbox input:focus {
>>> > > outline: none;
>>> > > border: 1px solid #0f88d1;
>>> > > }
>>> > > -.jewel.checkbox .input[disabled] {
>>> > > +.jewel.checkbox input[disabled] {
>>> > > cursor: unset;
>>> > > border: 1px solid #c6c6c6;
>>> > > background: #F9F9F9;
>>> > > }
>>> > > -.jewel.checkbox .input[disabled] + .span {
>>> > > +.jewel.checkbox input[disabled] + .span {
>>> > > color: #c6c6c6;
>>> > > }
>>> > > -.jewel.checkbox .input[disabled]:checked {
>>> > > +.jewel.checkbox input[disabled]:checked {
>>> > > border: 1px solid #c6c6c6;
>>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16
>>>13'
>>> > > version='1.1'
>>>xmlns='https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fw
>>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74
>>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365773
>>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%3D&reser
>>>ved=0'><g
>>> > > transform='translate(-763, -290)'><g transform='translate(760,
>>> > > 285)'><g><polygon fill='lightgray' points='3 13 9 18 19 7 16 5 9
>>>13 6
>>> > > 10'></polygon></g></g></g></svg>");
>>> > > background-size: 90%;
>>> > > @@ -239,7 +239,7 @@ div {
>>> > > background-repeat: no-repeat;
>>> > > background-attachment: fixed;
>>> > > }
>>> > > -.jewel.checkbox .span {
>>> > > +.jewel.checkbox span {
>>> > > cursor: pointer;
>>> > > position: absolute;
>>> > > margin: 0;
>>> > > @@ -262,7 +262,7 @@ div {
>>> > > width: 100%;
>>> > > height: 22px;
>>> > > }
>>> > > -.jewel.radiobutton .input {
>>> > > +.jewel.radiobutton input {
>>> > > -webkit-appearance: none;
>>> > > -moz-appearance: none;
>>> > > -o-appearance: none;
>>> > > @@ -278,26 +278,26 @@ div {
>>> > > border: 1px solid #b3b3b3;
>>> > > border-radius: 50%;
>>> > > }
>>> > > -.jewel.radiobutton .input:checked, .jewel.radiobutton
>>> > > .input:checked:active {
>>> > > +.jewel.radiobutton input:checked, .jewel.radiobutton
>>> > input:checked:active
>>> > > {
>>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12
>>>12'
>>> > > version='1.1'
>>>xmlns='https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fw
>>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74
>>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365773
>>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%3D&reser
>>>ved=0'><g
>>> > > transform='translate(-616, -350)'><g transform='translate(611,
>>> > > 345)'><g><circle fill='#3CADF1' cx='11' cy='11'
>>> > > r='6'></circle></g></g></g></svg>");
>>> > > background-repeat: no-repeat;
>>> > > background-size: 60%;
>>> > > background-position: center;
>>> > > background-attachment: fixed;
>>> > > }
>>> > > -.jewel.radiobutton .input:focus {
>>> > > +.jewel.radiobutton input:focus {
>>> > > outline: none;
>>> > > border: 1px solid #0f88d1;
>>> > > }
>>> > > -.jewel.radiobutton .input[disabled] {
>>> > > +.jewel.radiobutton input[disabled] {
>>> > > cursor: unset;
>>> > > border: 1px solid #c6c6c6;
>>> > > background: #F9F9F9;
>>> > > }
>>> > > -.jewel.radiobutton .input[disabled] + .span {
>>> > > +.jewel.radiobutton input[disabled] + .span {
>>> > > color: #c6c6c6;
>>> > > }
>>> > > -.jewel.radiobutton .input[disabled]:checked {
>>> > > +.jewel.radiobutton input[disabled]:checked {
>>> > > border: 1px solid #c6c6c6;
>>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12
>>>12'
>>> > > version='1.1'
>>>xmlns='https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fw
>>>ww.w3.org%2F2000%2Fsvg&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74
>>>ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365773
>>>59996677198&sdata=Cwlyf7irgdP7fj0%2BD9hBbIo5szaKNCBd4Ku3B0sjD8s%3D&reser
>>>ved=0'><g
>>> > > transform='translate(-616, -350)'><g transform='translate(611,
>>> > > 345)'><g><circle fill='lightgray' cx='11' cy='11'
>>> > > r='6'></circle></g></g></g></svg>");
>>> > > background-size: 60%;
>>> > > @@ -305,7 +305,7 @@ div {
>>> > > background-repeat: no-repeat;
>>> > > background-attachment: fixed;
>>> > > }
>>> > > -.jewel.radiobutton .span {
>>> > > +.jewel.radiobutton span {
>>> > > cursor: pointer;
>>> > > position: absolute;
>>> > > margin: 0;
>>> > > @@ -314,7 +314,7 @@ div {
>>> > > line-height: 22px;
>>> > > }
>>> > >
>>> > > -.jewel.slider .slider {
>>> > > +.jewel.slider input {
>>> > > -webkit-appearance: none;
>>> > > width: 100%;
>>> > > height: 15px;
>>> > > @@ -325,13 +325,13 @@ div {
>>> > > -webkit-transition: 0.2s;
>>> > > transition: opacity 0.2s;
>>> > > }
>>> > > -.jewel.slider .slider:hover {
>>> > > +.jewel.slider input:hover {
>>> > > opacity: 1;
>>> > > }
>>> > > -.jewel.slider .slider:focus {
>>> > > +.jewel.slider input:focus {
>>> > > outline: none;
>>> > > }
>>> > > -.jewel.slider .slider::-webkit-slider-thumb {
>>> > > +.jewel.slider input::-webkit-slider-thumb {
>>> > > -webkit-appearance: none;
>>> > > appearance: none;
>>> > > width: 15px;
>>> > > @@ -340,7 +340,7 @@ div {
>>> > > background: #3CADF1;
>>> > > cursor: pointer;
>>> > > }
>>> > > -.jewel.slider .slider::-moz-range-thumb {
>>> > > +.jewel.slider input::-moz-range-thumb {
>>> > > width: 15px;
>>> > > height: 15px;
>>> > > border-radius: 50%;
>>> > > @@ -523,7 +523,7 @@ div {
>>> > > position: relative;
>>> > > display: inline-flex;
>>> > > }
>>> > > -.jewel.textfield .input {
>>> > > +.jewel.textfield input {
>>> > > margin: 0;
>>> > > padding: 0.67em 1em;
>>> > > max-width: 100%;
>>> > > @@ -542,20 +542,20 @@ div {
>>> > > transition-duration: 0.3s;
>>> > > transition-timing-function: easein;
>>> > > }
>>> > > -.jewel.textfield .input:focus {
>>> > > +.jewel.textfield input:focus {
>>> > > border: 1px solid #0f88d1;
>>> > > }
>>> > > -.jewel.textfield .input::placeholder {
>>> > > +.jewel.textfield input::placeholder {
>>> > > color: #a6a6a6;
>>> > > }
>>> > > -.jewel.textfield .input[disabled] {
>>> > > +.jewel.textfield input[disabled] {
>>> > > cursor: unset;
>>> > > border: 1px solid #c6c6c6;
>>> > > background: #F9F9F9;
>>> > > box-shadow: none;
>>> > > color: #c6c6c6;
>>> > > }
>>> > > -.jewel.textfield .input[disabled]::placeholder {
>>> > > +.jewel.textfield input[disabled]::placeholder {
>>> > > color: #c6c6c6;
>>> > > }
>>> > >
>>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>>> > components/_checkbox.sass
>>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
>>> checkbox.sass
>>> > > index e79c952..92f4fd0 100644
>>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
>>> > components/_checkbox.sass
>>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
>>> > components/_checkbox.sass
>>> > > @@ -39,7 +39,7 @@ $checkbox-label-font-size: 16px
>>> > > height: $checkbox-button-size
>>> > >
>>> > > // -- INPUT
>>> > > - .input
>>> > > + input
>>> > > +appear(none)
>>> > > cursor: pointer
>>> > > display: inline-block
>>> > > @@ -102,7 +102,7 @@ $checkbox-label-font-size: 16px
>>> > > //background: $disabled-color
>>> > >
>>> > > // -- LABEL
>>> > > - .span
>>> > > + span
>>> > > cursor: pointer
>>> > > position: absolute
>>> > > margin: 0
>>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>>> > components/_radiobutton.sass
>>> > > b/frameworks/themes/JewelTheme/src/main/sass/
>>> > components/_radiobutton.sass
>>> > > index a224f28..d45a56a 100644
>>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
>>> > > components/_radiobutton.sass
>>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
>>> > > components/_radiobutton.sass
>>> > > @@ -39,7 +39,7 @@ $radiobutton-label-font-size: 16px
>>> > > height: $radiobutton-button-size
>>> > >
>>> > > // -- INPUT
>>> > > - .input
>>> > > + input
>>> > > +appear(none)
>>> > > cursor: pointer
>>> > > display: inline-block
>>> > > @@ -93,7 +93,7 @@ $radiobutton-label-font-size: 16px
>>> > > background-attachment: fixed
>>> > >
>>> > > // -- LABEL
>>> > > - .span
>>> > > + span
>>> > > cursor: pointer
>>> > > position: absolute
>>> > > margin: 0
>>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>>> > components/_slider.sass
>>> > >
>>>b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
>>> > > index f92fdd0..115df2c 100644
>>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/components/_
>>> slider.sass
>>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/components/_
>>> slider.sass
>>> > > @@ -19,7 +19,7 @@
>>> > >
>>> > > .jewel.slider
>>> > >
>>> > > - .slider
>>> > > + input
>>> > > -webkit-appearance: none
>>> > > width: 100%
>>> > > height: 15px
>>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>>> > components/_textfield.sass
>>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
>>> textfield.sass
>>> > > index 4165f6d..3e04d9a 100644
>>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
>>> > > components/_textfield.sass
>>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
>>> > > components/_textfield.sass
>>> > > @@ -32,7 +32,7 @@ $textfield-border-radius: 3px
>>> > > position: relative
>>> > > display: inline-flex
>>> > >
>>> > > - .input
>>> > > + input
>>> > > margin: $textfield-margin
>>> > > padding: $textfield-padding
>>> > >
>>> > >
>>> > > --
>>> > > To stop receiving notification emails like this one, please contact
>>> > > carlosrovira@apache.org.
>>> > >
>>> >
>>> >
>>> >
>>> > --
>>> >
>>> > Piotr Zarzycki
>>> >
>>> > Patreon:
>>>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pa
>>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226
>>>d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365
>>>77359996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%2B5E%3D&
>>>reserved=0
>>> >
>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pa
>>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226
>>>d74ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365
>>>77359996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%2B5E%3D&
>>>reserved=0>*
>>> >
>>>
>>>
>>>
>>> --
>>> Carlos Rovira
>>>
>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me
>>>%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74ff0dad6
>>>08d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63657735999667
>>>7198&sdata=BbM3FSzf3YGLSzq10huJ2EUfTkZ9%2BoqZeYmLKTV5aN0%3D&reserved=0
>>>
>>
>>
>>
>> --
>>
>> Piotr Zarzycki
>>
>> Patreon:
>>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat
>>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d7
>>4ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365773
>>59996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%2B5E%3D&rese
>>rved=0
>>
>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat
>>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d7
>>4ff0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365773
>>59996677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%2B5E%3D&rese
>>rved=0>*
>>
>
>
>
>--
>
>Piotr Zarzycki
>
>Patreon:
>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74f
>f0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365773599
>96677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%2B5E%3D&reserved
>=0
><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca45baaa226d74f
>f0dad608d593bc75c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365773599
>96677198&sdata=QzlPhboE7LRyP0P%2BufP8MwT9OC9G85UOm3uuvqdV%2B5E%3D&reserved
>=0>*
Re: [royale-asjs] branch feature/jewel-ui-set updated: removes
workaround for element styles thanks to bugs #30/#32 solved
Posted by Piotr Zarzycki <pi...@gmail.com>.
I just pushed changes -> Checkout how it looks like now ->
https://github.com/apache/royale-asjs/commit/df9808dc6ad261d33e58715c46448a1da5ee50ad
2018-03-27 10:22 GMT+02:00 Piotr Zarzycki <pi...@gmail.com>:
> I will change message in your last commit. Yes that is how are you linking
> to the other repository. If it will be in typedefs you will do:
> apache/royale-typedefs#number
>
> 2018-03-27 10:17 GMT+02:00 Carlos Rovira <ca...@apache.org>:
>
>> Hi Piotr,
>> thanks! I didn't realize that it's not the same repo, so for compiler I
>> must put "apache/royale-compiler#<number>" ? Thanks, I'll do the next
>> time!
>> :)
>>
>> 2018-03-27 10:13 GMT+02:00 Piotr Zarzycki <pi...@gmail.com>:
>>
>> > Hi Carlos,
>> >
>> > And again if you add in the description apache/royale-compiler#30 and
>> > apache/royale-compiler#32 it will point to the proper issue. Now you
>> are
>> > pointing to some closed issue in asjs which is totally unrelated.
>> >
>> > Thanks,
>> > Piotr
>> >
>> > 2018-03-27 10:02 GMT+02:00 <ca...@apache.org>:
>> >
>> > > This is an automated email from the ASF dual-hosted git repository.
>> > >
>> > > carlosrovira pushed a commit to branch feature/jewel-ui-set
>> > > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>> > >
>> > >
>> > > The following commit(s) were added to refs/heads/feature/jewel-ui-set
>> by
>> > > this push:
>> > > new 10d993c removes workaround for element styles thanks to bugs
>> > > #30/#32 solved
>> > > 10d993c is described below
>> > >
>> > > commit 10d993c21ef554019a249a8355e007adbab07ca8
>> > > Author: Carlos Rovira <ca...@apache.org>
>> > > AuthorDate: Tue Mar 27 10:02:00 2018 +0200
>> > >
>> > > removes workaround for element styles thanks to bugs #30/#32
>> solved
>> > > ---
>> > > .../src/main/resources/jewel-example-styles.css | 7 +++-
>> > > .../src/main/royale/RadioButtonPlayGround.mxml | 2 +-
>> > > .../royale/org/apache/royale/jewel/CheckBox.as | 4 +-
>> > > .../royale/org/apache/royale/jewel/RadioButton.as | 4 +-
>> > > .../main/royale/org/apache/royale/jewel/Slider.as | 2 +-
>> > > .../royale/org/apache/royale/jewel/TextField.as | 2 +-
>> > > .../JewelTheme/src/main/resources/defaults.css | 48
>> > > +++++++++++-----------
>> > > .../src/main/sass/components/_checkbox.sass | 4 +-
>> > > .../src/main/sass/components/_radiobutton.sass | 4 +-
>> > > .../src/main/sass/components/_slider.sass | 2 +-
>> > > .../src/main/sass/components/_textfield.sass | 2 +-
>> > > 11 files changed, 42 insertions(+), 39 deletions(-)
>> > >
>> > > diff --git a/examples/royale/JewelExample/src/main/
>> > > resources/jewel-example-styles.css b/examples/royale/
>> > > JewelExample/src/main/resources/jewel-example-styles.css
>> > > index 003d6c8..c2ea379 100644
>> > > --- a/examples/royale/JewelExample/src/main/resources/jewel-example-
>> > > styles.css
>> > > +++ b/examples/royale/JewelExample/src/main/resources/jewel-example-
>> > > styles.css
>> > > @@ -21,10 +21,13 @@
>> > >
>> > > @namespace "http://www.w3.org/1999/xhtml";
>> > >
>> > > -
>> > > +body{
>> > > + background: #fff;
>> > > +}
>> > >
>> > > .container {
>> > > background: #efefef;
>> > > border-radius: 10px;
>> > > padding: 20px;
>> > > -}
>> > > \ No newline at end of file
>> > > +}
>> > > +
>> > > \ No newline at end of file
>> > > diff --git a/examples/royale/JewelExample/src/main/royale/
>> > RadioButtonPlayGround.mxml
>> > > b/examples/royale/JewelExample/src/main/royale/
>> > RadioButtonPlayGround.mxml
>> > > index 3d34b18..9e6806d 100644
>> > > --- a/examples/royale/JewelExample/src/main/royale/
>> > > RadioButtonPlayGround.mxml
>> > > +++ b/examples/royale/JewelExample/src/main/royale/
>> > > RadioButtonPlayGround.mxml
>> > > @@ -30,7 +30,7 @@ limitations under the License.
>> > > <html:H3 text="Jewel RadioButton"/>
>> > >
>> > > <j:RadioButton text="RadioButton 1" groupName="radios"
>> > value="Test
>> > > 1"/>
>> > > - <j:RadioButton text="RadioButton 2" groupName="radios"
>> > value="Test
>> > > 2"/>
>> > > + <j:RadioButton text="RadioButton 2" groupName="radios"
>> > value="Test
>> > > 2" selected="true"/>
>> > > <j:RadioButton text="RadioButton 3" groupName="radios"
>> > value="Test
>> > > 3"/>
>> > >
>> > > <j:RadioButton text="Disabled">
>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > royale/jewel/CheckBox.as
>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/CheckBox.as
>> > > index d69fad6..5c78dbc 100644
>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/CheckBox.as
>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/CheckBox.as
>> > > @@ -99,11 +99,11 @@ package org.apache.royale.jewel
>> > >
>> > > input = addElementToWrapper(this,'input') as
>> > > HTMLInputElement;
>> > > input.type = 'checkbox';
>> > > - input.className = 'input';
>> > > + //input.className = 'input';
>> > > label.appendChild(input);
>> > >
>> > > checkbox = document.createElement('span') as
>> > HTMLSpanElement;
>> > > - checkbox.className = 'span';
>> > > + //checkbox.className = 'span';
>> > > label.appendChild(checkbox);
>> > >
>> > > positioner = label as WrappedHTMLElement;
>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > royale/jewel/RadioButton.as
>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/RadioButton.as
>> > > index 19d5981..b36b51a 100644
>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/RadioButton.as
>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/RadioButton.as
>> > > @@ -316,14 +316,14 @@ package org.apache.royale.jewel
>> > >
>> > > icon = addElementToWrapper(this,'input') as
>> > HTMLInputElement;
>> > > icon.type = "radio";
>> > > - icon.className = 'input';
>> > > + //icon.className = 'input';
>> > > icon.id = '_radio_' + + Math.random();
>> > > label.appendChild(icon);
>> > >
>> > > textNode = document.createTextNode('') as Text;
>> > >
>> > > radio = document.createElement('span') as
>> HTMLSpanElement;
>> > > - radio.className = 'span';
>> > > + //radio.className = 'span';
>> > > radio.appendChild(textNode);
>> > > label.appendChild(radio);
>> > > //radio.addEventListener('mouseover', mouseOverHandler,
>> > > false);
>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > royale/jewel/Slider.as
>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/Slider.as
>> > > index 0cb0101..a9ddbbe 100644
>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/Slider.as
>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/Slider.as
>> > > @@ -184,7 +184,7 @@ package org.apache.royale.jewel
>> > >
>> > > var input:HTMLInputElement = addElementToWrapper(this,'
>> > input')
>> > > as HTMLInputElement;
>> > > input.setAttribute('type', 'range');
>> > > - input.className = "slider";
>> > > + //input.className = "slider";
>> > >
>> > > //attach input handler to dispatch royale
>> change
>> > > event when user write in textinput
>> > > //goog.events.listen(element, 'change',
>> killChangeHandler);
>> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > royale/jewel/TextField.as
>> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/TextField.as
>> > > index 1c12711..a5d5c1c 100644
>> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/TextField.as
>> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
>> > > royale/jewel/TextField.as
>> > > @@ -82,7 +82,7 @@ package org.apache.royale.jewel
>> > >
>> > > input = addElementToWrapper(this,'input') as
>> > > HTMLInputElement;
>> > > input.setAttribute('type', 'text');
>> > > - input.className = "input";
>> > > + //input.className = "input";
>> > >
>> > > //attach input handler to dispatch royale change event
>> when
>> > > user write in textinput
>> > > //goog.events.listen(element, 'change',
>> killChangeHandler);
>> > > diff --git a/frameworks/themes/JewelTheme/src/main/resources/
>> > defaults.css
>> > > b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
>> > > index 8f90431..e23ebd2 100644
>> > > --- a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
>> > > +++ b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
>> > > @@ -196,7 +196,7 @@ div {
>> > > width: 100%;
>> > > height: 22px;
>> > > }
>> > > -.jewel.checkbox .input {
>> > > +.jewel.checkbox input {
>> > > -webkit-appearance: none;
>> > > -moz-appearance: none;
>> > > -o-appearance: none;
>> > > @@ -212,26 +212,26 @@ div {
>> > > border: 1px solid #b3b3b3;
>> > > border-radius: 3px;
>> > > }
>> > > -.jewel.checkbox .input:checked, .jewel.checkbox
>> .input:checked:active {
>> > > +.jewel.checkbox input:checked, .jewel.checkbox input:checked:active {
>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16 13'
>> > > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
>> > > transform='translate(-763, -290)'><g transform='translate(760,
>> > > 285)'><g><polygon fill='#3CADF1' points='3 13 9 18 19 7 16 5 9 13 6
>> > > 10'></polygon></g></g></g></svg>");
>> > > background-repeat: no-repeat;
>> > > background-size: 90%;
>> > > background-position: center;
>> > > background-attachment: fixed;
>> > > }
>> > > -.jewel.checkbox .input:focus {
>> > > +.jewel.checkbox input:focus {
>> > > outline: none;
>> > > border: 1px solid #0f88d1;
>> > > }
>> > > -.jewel.checkbox .input[disabled] {
>> > > +.jewel.checkbox input[disabled] {
>> > > cursor: unset;
>> > > border: 1px solid #c6c6c6;
>> > > background: #F9F9F9;
>> > > }
>> > > -.jewel.checkbox .input[disabled] + .span {
>> > > +.jewel.checkbox input[disabled] + .span {
>> > > color: #c6c6c6;
>> > > }
>> > > -.jewel.checkbox .input[disabled]:checked {
>> > > +.jewel.checkbox input[disabled]:checked {
>> > > border: 1px solid #c6c6c6;
>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16 13'
>> > > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
>> > > transform='translate(-763, -290)'><g transform='translate(760,
>> > > 285)'><g><polygon fill='lightgray' points='3 13 9 18 19 7 16 5 9 13 6
>> > > 10'></polygon></g></g></g></svg>");
>> > > background-size: 90%;
>> > > @@ -239,7 +239,7 @@ div {
>> > > background-repeat: no-repeat;
>> > > background-attachment: fixed;
>> > > }
>> > > -.jewel.checkbox .span {
>> > > +.jewel.checkbox span {
>> > > cursor: pointer;
>> > > position: absolute;
>> > > margin: 0;
>> > > @@ -262,7 +262,7 @@ div {
>> > > width: 100%;
>> > > height: 22px;
>> > > }
>> > > -.jewel.radiobutton .input {
>> > > +.jewel.radiobutton input {
>> > > -webkit-appearance: none;
>> > > -moz-appearance: none;
>> > > -o-appearance: none;
>> > > @@ -278,26 +278,26 @@ div {
>> > > border: 1px solid #b3b3b3;
>> > > border-radius: 50%;
>> > > }
>> > > -.jewel.radiobutton .input:checked, .jewel.radiobutton
>> > > .input:checked:active {
>> > > +.jewel.radiobutton input:checked, .jewel.radiobutton
>> > input:checked:active
>> > > {
>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12 12'
>> > > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
>> > > transform='translate(-616, -350)'><g transform='translate(611,
>> > > 345)'><g><circle fill='#3CADF1' cx='11' cy='11'
>> > > r='6'></circle></g></g></g></svg>");
>> > > background-repeat: no-repeat;
>> > > background-size: 60%;
>> > > background-position: center;
>> > > background-attachment: fixed;
>> > > }
>> > > -.jewel.radiobutton .input:focus {
>> > > +.jewel.radiobutton input:focus {
>> > > outline: none;
>> > > border: 1px solid #0f88d1;
>> > > }
>> > > -.jewel.radiobutton .input[disabled] {
>> > > +.jewel.radiobutton input[disabled] {
>> > > cursor: unset;
>> > > border: 1px solid #c6c6c6;
>> > > background: #F9F9F9;
>> > > }
>> > > -.jewel.radiobutton .input[disabled] + .span {
>> > > +.jewel.radiobutton input[disabled] + .span {
>> > > color: #c6c6c6;
>> > > }
>> > > -.jewel.radiobutton .input[disabled]:checked {
>> > > +.jewel.radiobutton input[disabled]:checked {
>> > > border: 1px solid #c6c6c6;
>> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12 12'
>> > > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
>> > > transform='translate(-616, -350)'><g transform='translate(611,
>> > > 345)'><g><circle fill='lightgray' cx='11' cy='11'
>> > > r='6'></circle></g></g></g></svg>");
>> > > background-size: 60%;
>> > > @@ -305,7 +305,7 @@ div {
>> > > background-repeat: no-repeat;
>> > > background-attachment: fixed;
>> > > }
>> > > -.jewel.radiobutton .span {
>> > > +.jewel.radiobutton span {
>> > > cursor: pointer;
>> > > position: absolute;
>> > > margin: 0;
>> > > @@ -314,7 +314,7 @@ div {
>> > > line-height: 22px;
>> > > }
>> > >
>> > > -.jewel.slider .slider {
>> > > +.jewel.slider input {
>> > > -webkit-appearance: none;
>> > > width: 100%;
>> > > height: 15px;
>> > > @@ -325,13 +325,13 @@ div {
>> > > -webkit-transition: 0.2s;
>> > > transition: opacity 0.2s;
>> > > }
>> > > -.jewel.slider .slider:hover {
>> > > +.jewel.slider input:hover {
>> > > opacity: 1;
>> > > }
>> > > -.jewel.slider .slider:focus {
>> > > +.jewel.slider input:focus {
>> > > outline: none;
>> > > }
>> > > -.jewel.slider .slider::-webkit-slider-thumb {
>> > > +.jewel.slider input::-webkit-slider-thumb {
>> > > -webkit-appearance: none;
>> > > appearance: none;
>> > > width: 15px;
>> > > @@ -340,7 +340,7 @@ div {
>> > > background: #3CADF1;
>> > > cursor: pointer;
>> > > }
>> > > -.jewel.slider .slider::-moz-range-thumb {
>> > > +.jewel.slider input::-moz-range-thumb {
>> > > width: 15px;
>> > > height: 15px;
>> > > border-radius: 50%;
>> > > @@ -523,7 +523,7 @@ div {
>> > > position: relative;
>> > > display: inline-flex;
>> > > }
>> > > -.jewel.textfield .input {
>> > > +.jewel.textfield input {
>> > > margin: 0;
>> > > padding: 0.67em 1em;
>> > > max-width: 100%;
>> > > @@ -542,20 +542,20 @@ div {
>> > > transition-duration: 0.3s;
>> > > transition-timing-function: easein;
>> > > }
>> > > -.jewel.textfield .input:focus {
>> > > +.jewel.textfield input:focus {
>> > > border: 1px solid #0f88d1;
>> > > }
>> > > -.jewel.textfield .input::placeholder {
>> > > +.jewel.textfield input::placeholder {
>> > > color: #a6a6a6;
>> > > }
>> > > -.jewel.textfield .input[disabled] {
>> > > +.jewel.textfield input[disabled] {
>> > > cursor: unset;
>> > > border: 1px solid #c6c6c6;
>> > > background: #F9F9F9;
>> > > box-shadow: none;
>> > > color: #c6c6c6;
>> > > }
>> > > -.jewel.textfield .input[disabled]::placeholder {
>> > > +.jewel.textfield input[disabled]::placeholder {
>> > > color: #c6c6c6;
>> > > }
>> > >
>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>> > components/_checkbox.sass
>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
>> checkbox.sass
>> > > index e79c952..92f4fd0 100644
>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
>> > components/_checkbox.sass
>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
>> > components/_checkbox.sass
>> > > @@ -39,7 +39,7 @@ $checkbox-label-font-size: 16px
>> > > height: $checkbox-button-size
>> > >
>> > > // -- INPUT
>> > > - .input
>> > > + input
>> > > +appear(none)
>> > > cursor: pointer
>> > > display: inline-block
>> > > @@ -102,7 +102,7 @@ $checkbox-label-font-size: 16px
>> > > //background: $disabled-color
>> > >
>> > > // -- LABEL
>> > > - .span
>> > > + span
>> > > cursor: pointer
>> > > position: absolute
>> > > margin: 0
>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>> > components/_radiobutton.sass
>> > > b/frameworks/themes/JewelTheme/src/main/sass/
>> > components/_radiobutton.sass
>> > > index a224f28..d45a56a 100644
>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
>> > > components/_radiobutton.sass
>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
>> > > components/_radiobutton.sass
>> > > @@ -39,7 +39,7 @@ $radiobutton-label-font-size: 16px
>> > > height: $radiobutton-button-size
>> > >
>> > > // -- INPUT
>> > > - .input
>> > > + input
>> > > +appear(none)
>> > > cursor: pointer
>> > > display: inline-block
>> > > @@ -93,7 +93,7 @@ $radiobutton-label-font-size: 16px
>> > > background-attachment: fixed
>> > >
>> > > // -- LABEL
>> > > - .span
>> > > + span
>> > > cursor: pointer
>> > > position: absolute
>> > > margin: 0
>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>> > components/_slider.sass
>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
>> > > index f92fdd0..115df2c 100644
>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/components/_
>> slider.sass
>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/components/_
>> slider.sass
>> > > @@ -19,7 +19,7 @@
>> > >
>> > > .jewel.slider
>> > >
>> > > - .slider
>> > > + input
>> > > -webkit-appearance: none
>> > > width: 100%
>> > > height: 15px
>> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
>> > components/_textfield.sass
>> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_
>> textfield.sass
>> > > index 4165f6d..3e04d9a 100644
>> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
>> > > components/_textfield.sass
>> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
>> > > components/_textfield.sass
>> > > @@ -32,7 +32,7 @@ $textfield-border-radius: 3px
>> > > position: relative
>> > > display: inline-flex
>> > >
>> > > - .input
>> > > + input
>> > > margin: $textfield-margin
>> > > padding: $textfield-padding
>> > >
>> > >
>> > > --
>> > > To stop receiving notification emails like this one, please contact
>> > > carlosrovira@apache.org.
>> > >
>> >
>> >
>> >
>> > --
>> >
>> > Piotr Zarzycki
>> >
>> > Patreon: *https://www.patreon.com/piotrzarzycki
>> > <https://www.patreon.com/piotrzarzycki>*
>> >
>>
>>
>>
>> --
>> Carlos Rovira
>> http://about.me/carlosrovira
>>
>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> <https://www.patreon.com/piotrzarzycki>*
>
--
Piotr Zarzycki
Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*
Re: [royale-asjs] branch feature/jewel-ui-set updated: removes
workaround for element styles thanks to bugs #30/#32 solved
Posted by Piotr Zarzycki <pi...@gmail.com>.
I will change message in your last commit. Yes that is how are you linking
to the other repository. If it will be in typedefs you will do:
apache/royale-typedefs#number
2018-03-27 10:17 GMT+02:00 Carlos Rovira <ca...@apache.org>:
> Hi Piotr,
> thanks! I didn't realize that it's not the same repo, so for compiler I
> must put "apache/royale-compiler#<number>" ? Thanks, I'll do the next
> time!
> :)
>
> 2018-03-27 10:13 GMT+02:00 Piotr Zarzycki <pi...@gmail.com>:
>
> > Hi Carlos,
> >
> > And again if you add in the description apache/royale-compiler#30 and
> > apache/royale-compiler#32 it will point to the proper issue. Now you are
> > pointing to some closed issue in asjs which is totally unrelated.
> >
> > Thanks,
> > Piotr
> >
> > 2018-03-27 10:02 GMT+02:00 <ca...@apache.org>:
> >
> > > This is an automated email from the ASF dual-hosted git repository.
> > >
> > > carlosrovira pushed a commit to branch feature/jewel-ui-set
> > > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> > >
> > >
> > > The following commit(s) were added to refs/heads/feature/jewel-ui-set
> by
> > > this push:
> > > new 10d993c removes workaround for element styles thanks to bugs
> > > #30/#32 solved
> > > 10d993c is described below
> > >
> > > commit 10d993c21ef554019a249a8355e007adbab07ca8
> > > Author: Carlos Rovira <ca...@apache.org>
> > > AuthorDate: Tue Mar 27 10:02:00 2018 +0200
> > >
> > > removes workaround for element styles thanks to bugs #30/#32 solved
> > > ---
> > > .../src/main/resources/jewel-example-styles.css | 7 +++-
> > > .../src/main/royale/RadioButtonPlayGround.mxml | 2 +-
> > > .../royale/org/apache/royale/jewel/CheckBox.as | 4 +-
> > > .../royale/org/apache/royale/jewel/RadioButton.as | 4 +-
> > > .../main/royale/org/apache/royale/jewel/Slider.as | 2 +-
> > > .../royale/org/apache/royale/jewel/TextField.as | 2 +-
> > > .../JewelTheme/src/main/resources/defaults.css | 48
> > > +++++++++++-----------
> > > .../src/main/sass/components/_checkbox.sass | 4 +-
> > > .../src/main/sass/components/_radiobutton.sass | 4 +-
> > > .../src/main/sass/components/_slider.sass | 2 +-
> > > .../src/main/sass/components/_textfield.sass | 2 +-
> > > 11 files changed, 42 insertions(+), 39 deletions(-)
> > >
> > > diff --git a/examples/royale/JewelExample/src/main/
> > > resources/jewel-example-styles.css b/examples/royale/
> > > JewelExample/src/main/resources/jewel-example-styles.css
> > > index 003d6c8..c2ea379 100644
> > > --- a/examples/royale/JewelExample/src/main/resources/jewel-example-
> > > styles.css
> > > +++ b/examples/royale/JewelExample/src/main/resources/jewel-example-
> > > styles.css
> > > @@ -21,10 +21,13 @@
> > >
> > > @namespace "http://www.w3.org/1999/xhtml";
> > >
> > > -
> > > +body{
> > > + background: #fff;
> > > +}
> > >
> > > .container {
> > > background: #efefef;
> > > border-radius: 10px;
> > > padding: 20px;
> > > -}
> > > \ No newline at end of file
> > > +}
> > > +
> > > \ No newline at end of file
> > > diff --git a/examples/royale/JewelExample/src/main/royale/
> > RadioButtonPlayGround.mxml
> > > b/examples/royale/JewelExample/src/main/royale/
> > RadioButtonPlayGround.mxml
> > > index 3d34b18..9e6806d 100644
> > > --- a/examples/royale/JewelExample/src/main/royale/
> > > RadioButtonPlayGround.mxml
> > > +++ b/examples/royale/JewelExample/src/main/royale/
> > > RadioButtonPlayGround.mxml
> > > @@ -30,7 +30,7 @@ limitations under the License.
> > > <html:H3 text="Jewel RadioButton"/>
> > >
> > > <j:RadioButton text="RadioButton 1" groupName="radios"
> > value="Test
> > > 1"/>
> > > - <j:RadioButton text="RadioButton 2" groupName="radios"
> > value="Test
> > > 2"/>
> > > + <j:RadioButton text="RadioButton 2" groupName="radios"
> > value="Test
> > > 2" selected="true"/>
> > > <j:RadioButton text="RadioButton 3" groupName="radios"
> > value="Test
> > > 3"/>
> > >
> > > <j:RadioButton text="Disabled">
> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/CheckBox.as
> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/CheckBox.as
> > > index d69fad6..5c78dbc 100644
> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/CheckBox.as
> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/CheckBox.as
> > > @@ -99,11 +99,11 @@ package org.apache.royale.jewel
> > >
> > > input = addElementToWrapper(this,'input') as
> > > HTMLInputElement;
> > > input.type = 'checkbox';
> > > - input.className = 'input';
> > > + //input.className = 'input';
> > > label.appendChild(input);
> > >
> > > checkbox = document.createElement('span') as
> > HTMLSpanElement;
> > > - checkbox.className = 'span';
> > > + //checkbox.className = 'span';
> > > label.appendChild(checkbox);
> > >
> > > positioner = label as WrappedHTMLElement;
> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/RadioButton.as
> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/RadioButton.as
> > > index 19d5981..b36b51a 100644
> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/RadioButton.as
> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/RadioButton.as
> > > @@ -316,14 +316,14 @@ package org.apache.royale.jewel
> > >
> > > icon = addElementToWrapper(this,'input') as
> > HTMLInputElement;
> > > icon.type = "radio";
> > > - icon.className = 'input';
> > > + //icon.className = 'input';
> > > icon.id = '_radio_' + + Math.random();
> > > label.appendChild(icon);
> > >
> > > textNode = document.createTextNode('') as Text;
> > >
> > > radio = document.createElement('span') as HTMLSpanElement;
> > > - radio.className = 'span';
> > > + //radio.className = 'span';
> > > radio.appendChild(textNode);
> > > label.appendChild(radio);
> > > //radio.addEventListener('mouseover', mouseOverHandler,
> > > false);
> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/Slider.as
> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/Slider.as
> > > index 0cb0101..a9ddbbe 100644
> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/Slider.as
> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/Slider.as
> > > @@ -184,7 +184,7 @@ package org.apache.royale.jewel
> > >
> > > var input:HTMLInputElement = addElementToWrapper(this,'
> > input')
> > > as HTMLInputElement;
> > > input.setAttribute('type', 'range');
> > > - input.className = "slider";
> > > + //input.className = "slider";
> > >
> > > //attach input handler to dispatch royale
> change
> > > event when user write in textinput
> > > //goog.events.listen(element, 'change',
> killChangeHandler);
> > > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/TextField.as
> > > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/TextField.as
> > > index 1c12711..a5d5c1c 100644
> > > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/TextField.as
> > > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > > royale/jewel/TextField.as
> > > @@ -82,7 +82,7 @@ package org.apache.royale.jewel
> > >
> > > input = addElementToWrapper(this,'input') as
> > > HTMLInputElement;
> > > input.setAttribute('type', 'text');
> > > - input.className = "input";
> > > + //input.className = "input";
> > >
> > > //attach input handler to dispatch royale change event
> when
> > > user write in textinput
> > > //goog.events.listen(element, 'change',
> killChangeHandler);
> > > diff --git a/frameworks/themes/JewelTheme/src/main/resources/
> > defaults.css
> > > b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> > > index 8f90431..e23ebd2 100644
> > > --- a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> > > +++ b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> > > @@ -196,7 +196,7 @@ div {
> > > width: 100%;
> > > height: 22px;
> > > }
> > > -.jewel.checkbox .input {
> > > +.jewel.checkbox input {
> > > -webkit-appearance: none;
> > > -moz-appearance: none;
> > > -o-appearance: none;
> > > @@ -212,26 +212,26 @@ div {
> > > border: 1px solid #b3b3b3;
> > > border-radius: 3px;
> > > }
> > > -.jewel.checkbox .input:checked, .jewel.checkbox .input:checked:active
> {
> > > +.jewel.checkbox input:checked, .jewel.checkbox input:checked:active {
> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16 13'
> > > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> > > transform='translate(-763, -290)'><g transform='translate(760,
> > > 285)'><g><polygon fill='#3CADF1' points='3 13 9 18 19 7 16 5 9 13 6
> > > 10'></polygon></g></g></g></svg>");
> > > background-repeat: no-repeat;
> > > background-size: 90%;
> > > background-position: center;
> > > background-attachment: fixed;
> > > }
> > > -.jewel.checkbox .input:focus {
> > > +.jewel.checkbox input:focus {
> > > outline: none;
> > > border: 1px solid #0f88d1;
> > > }
> > > -.jewel.checkbox .input[disabled] {
> > > +.jewel.checkbox input[disabled] {
> > > cursor: unset;
> > > border: 1px solid #c6c6c6;
> > > background: #F9F9F9;
> > > }
> > > -.jewel.checkbox .input[disabled] + .span {
> > > +.jewel.checkbox input[disabled] + .span {
> > > color: #c6c6c6;
> > > }
> > > -.jewel.checkbox .input[disabled]:checked {
> > > +.jewel.checkbox input[disabled]:checked {
> > > border: 1px solid #c6c6c6;
> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16 13'
> > > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> > > transform='translate(-763, -290)'><g transform='translate(760,
> > > 285)'><g><polygon fill='lightgray' points='3 13 9 18 19 7 16 5 9 13 6
> > > 10'></polygon></g></g></g></svg>");
> > > background-size: 90%;
> > > @@ -239,7 +239,7 @@ div {
> > > background-repeat: no-repeat;
> > > background-attachment: fixed;
> > > }
> > > -.jewel.checkbox .span {
> > > +.jewel.checkbox span {
> > > cursor: pointer;
> > > position: absolute;
> > > margin: 0;
> > > @@ -262,7 +262,7 @@ div {
> > > width: 100%;
> > > height: 22px;
> > > }
> > > -.jewel.radiobutton .input {
> > > +.jewel.radiobutton input {
> > > -webkit-appearance: none;
> > > -moz-appearance: none;
> > > -o-appearance: none;
> > > @@ -278,26 +278,26 @@ div {
> > > border: 1px solid #b3b3b3;
> > > border-radius: 50%;
> > > }
> > > -.jewel.radiobutton .input:checked, .jewel.radiobutton
> > > .input:checked:active {
> > > +.jewel.radiobutton input:checked, .jewel.radiobutton
> > input:checked:active
> > > {
> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12 12'
> > > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> > > transform='translate(-616, -350)'><g transform='translate(611,
> > > 345)'><g><circle fill='#3CADF1' cx='11' cy='11'
> > > r='6'></circle></g></g></g></svg>");
> > > background-repeat: no-repeat;
> > > background-size: 60%;
> > > background-position: center;
> > > background-attachment: fixed;
> > > }
> > > -.jewel.radiobutton .input:focus {
> > > +.jewel.radiobutton input:focus {
> > > outline: none;
> > > border: 1px solid #0f88d1;
> > > }
> > > -.jewel.radiobutton .input[disabled] {
> > > +.jewel.radiobutton input[disabled] {
> > > cursor: unset;
> > > border: 1px solid #c6c6c6;
> > > background: #F9F9F9;
> > > }
> > > -.jewel.radiobutton .input[disabled] + .span {
> > > +.jewel.radiobutton input[disabled] + .span {
> > > color: #c6c6c6;
> > > }
> > > -.jewel.radiobutton .input[disabled]:checked {
> > > +.jewel.radiobutton input[disabled]:checked {
> > > border: 1px solid #c6c6c6;
> > > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12 12'
> > > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> > > transform='translate(-616, -350)'><g transform='translate(611,
> > > 345)'><g><circle fill='lightgray' cx='11' cy='11'
> > > r='6'></circle></g></g></g></svg>");
> > > background-size: 60%;
> > > @@ -305,7 +305,7 @@ div {
> > > background-repeat: no-repeat;
> > > background-attachment: fixed;
> > > }
> > > -.jewel.radiobutton .span {
> > > +.jewel.radiobutton span {
> > > cursor: pointer;
> > > position: absolute;
> > > margin: 0;
> > > @@ -314,7 +314,7 @@ div {
> > > line-height: 22px;
> > > }
> > >
> > > -.jewel.slider .slider {
> > > +.jewel.slider input {
> > > -webkit-appearance: none;
> > > width: 100%;
> > > height: 15px;
> > > @@ -325,13 +325,13 @@ div {
> > > -webkit-transition: 0.2s;
> > > transition: opacity 0.2s;
> > > }
> > > -.jewel.slider .slider:hover {
> > > +.jewel.slider input:hover {
> > > opacity: 1;
> > > }
> > > -.jewel.slider .slider:focus {
> > > +.jewel.slider input:focus {
> > > outline: none;
> > > }
> > > -.jewel.slider .slider::-webkit-slider-thumb {
> > > +.jewel.slider input::-webkit-slider-thumb {
> > > -webkit-appearance: none;
> > > appearance: none;
> > > width: 15px;
> > > @@ -340,7 +340,7 @@ div {
> > > background: #3CADF1;
> > > cursor: pointer;
> > > }
> > > -.jewel.slider .slider::-moz-range-thumb {
> > > +.jewel.slider input::-moz-range-thumb {
> > > width: 15px;
> > > height: 15px;
> > > border-radius: 50%;
> > > @@ -523,7 +523,7 @@ div {
> > > position: relative;
> > > display: inline-flex;
> > > }
> > > -.jewel.textfield .input {
> > > +.jewel.textfield input {
> > > margin: 0;
> > > padding: 0.67em 1em;
> > > max-width: 100%;
> > > @@ -542,20 +542,20 @@ div {
> > > transition-duration: 0.3s;
> > > transition-timing-function: easein;
> > > }
> > > -.jewel.textfield .input:focus {
> > > +.jewel.textfield input:focus {
> > > border: 1px solid #0f88d1;
> > > }
> > > -.jewel.textfield .input::placeholder {
> > > +.jewel.textfield input::placeholder {
> > > color: #a6a6a6;
> > > }
> > > -.jewel.textfield .input[disabled] {
> > > +.jewel.textfield input[disabled] {
> > > cursor: unset;
> > > border: 1px solid #c6c6c6;
> > > background: #F9F9F9;
> > > box-shadow: none;
> > > color: #c6c6c6;
> > > }
> > > -.jewel.textfield .input[disabled]::placeholder {
> > > +.jewel.textfield input[disabled]::placeholder {
> > > color: #c6c6c6;
> > > }
> > >
> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> > components/_checkbox.sass
> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_checkbox.sass
> > > index e79c952..92f4fd0 100644
> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> > components/_checkbox.sass
> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> > components/_checkbox.sass
> > > @@ -39,7 +39,7 @@ $checkbox-label-font-size: 16px
> > > height: $checkbox-button-size
> > >
> > > // -- INPUT
> > > - .input
> > > + input
> > > +appear(none)
> > > cursor: pointer
> > > display: inline-block
> > > @@ -102,7 +102,7 @@ $checkbox-label-font-size: 16px
> > > //background: $disabled-color
> > >
> > > // -- LABEL
> > > - .span
> > > + span
> > > cursor: pointer
> > > position: absolute
> > > margin: 0
> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> > components/_radiobutton.sass
> > > b/frameworks/themes/JewelTheme/src/main/sass/
> > components/_radiobutton.sass
> > > index a224f28..d45a56a 100644
> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> > > components/_radiobutton.sass
> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> > > components/_radiobutton.sass
> > > @@ -39,7 +39,7 @@ $radiobutton-label-font-size: 16px
> > > height: $radiobutton-button-size
> > >
> > > // -- INPUT
> > > - .input
> > > + input
> > > +appear(none)
> > > cursor: pointer
> > > display: inline-block
> > > @@ -93,7 +93,7 @@ $radiobutton-label-font-size: 16px
> > > background-attachment: fixed
> > >
> > > // -- LABEL
> > > - .span
> > > + span
> > > cursor: pointer
> > > position: absolute
> > > margin: 0
> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> > components/_slider.sass
> > > b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> > > index f92fdd0..115df2c 100644
> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> components/_slider.sass
> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> components/_slider.sass
> > > @@ -19,7 +19,7 @@
> > >
> > > .jewel.slider
> > >
> > > - .slider
> > > + input
> > > -webkit-appearance: none
> > > width: 100%
> > > height: 15px
> > > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> > components/_textfield.sass
> > > b/frameworks/themes/JewelTheme/src/main/sass/
> components/_textfield.sass
> > > index 4165f6d..3e04d9a 100644
> > > --- a/frameworks/themes/JewelTheme/src/main/sass/
> > > components/_textfield.sass
> > > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> > > components/_textfield.sass
> > > @@ -32,7 +32,7 @@ $textfield-border-radius: 3px
> > > position: relative
> > > display: inline-flex
> > >
> > > - .input
> > > + input
> > > margin: $textfield-margin
> > > padding: $textfield-padding
> > >
> > >
> > > --
> > > To stop receiving notification emails like this one, please contact
> > > carlosrovira@apache.org.
> > >
> >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
> > Patreon: *https://www.patreon.com/piotrzarzycki
> > <https://www.patreon.com/piotrzarzycki>*
> >
>
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
--
Piotr Zarzycki
Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*
Re: [royale-asjs] branch feature/jewel-ui-set updated: removes
workaround for element styles thanks to bugs #30/#32 solved
Posted by Carlos Rovira <ca...@apache.org>.
Hi Piotr,
thanks! I didn't realize that it's not the same repo, so for compiler I
must put "apache/royale-compiler#<number>" ? Thanks, I'll do the next time!
:)
2018-03-27 10:13 GMT+02:00 Piotr Zarzycki <pi...@gmail.com>:
> Hi Carlos,
>
> And again if you add in the description apache/royale-compiler#30 and
> apache/royale-compiler#32 it will point to the proper issue. Now you are
> pointing to some closed issue in asjs which is totally unrelated.
>
> Thanks,
> Piotr
>
> 2018-03-27 10:02 GMT+02:00 <ca...@apache.org>:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > carlosrovira pushed a commit to branch feature/jewel-ui-set
> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >
> >
> > The following commit(s) were added to refs/heads/feature/jewel-ui-set by
> > this push:
> > new 10d993c removes workaround for element styles thanks to bugs
> > #30/#32 solved
> > 10d993c is described below
> >
> > commit 10d993c21ef554019a249a8355e007adbab07ca8
> > Author: Carlos Rovira <ca...@apache.org>
> > AuthorDate: Tue Mar 27 10:02:00 2018 +0200
> >
> > removes workaround for element styles thanks to bugs #30/#32 solved
> > ---
> > .../src/main/resources/jewel-example-styles.css | 7 +++-
> > .../src/main/royale/RadioButtonPlayGround.mxml | 2 +-
> > .../royale/org/apache/royale/jewel/CheckBox.as | 4 +-
> > .../royale/org/apache/royale/jewel/RadioButton.as | 4 +-
> > .../main/royale/org/apache/royale/jewel/Slider.as | 2 +-
> > .../royale/org/apache/royale/jewel/TextField.as | 2 +-
> > .../JewelTheme/src/main/resources/defaults.css | 48
> > +++++++++++-----------
> > .../src/main/sass/components/_checkbox.sass | 4 +-
> > .../src/main/sass/components/_radiobutton.sass | 4 +-
> > .../src/main/sass/components/_slider.sass | 2 +-
> > .../src/main/sass/components/_textfield.sass | 2 +-
> > 11 files changed, 42 insertions(+), 39 deletions(-)
> >
> > diff --git a/examples/royale/JewelExample/src/main/
> > resources/jewel-example-styles.css b/examples/royale/
> > JewelExample/src/main/resources/jewel-example-styles.css
> > index 003d6c8..c2ea379 100644
> > --- a/examples/royale/JewelExample/src/main/resources/jewel-example-
> > styles.css
> > +++ b/examples/royale/JewelExample/src/main/resources/jewel-example-
> > styles.css
> > @@ -21,10 +21,13 @@
> >
> > @namespace "http://www.w3.org/1999/xhtml";
> >
> > -
> > +body{
> > + background: #fff;
> > +}
> >
> > .container {
> > background: #efefef;
> > border-radius: 10px;
> > padding: 20px;
> > -}
> > \ No newline at end of file
> > +}
> > +
> > \ No newline at end of file
> > diff --git a/examples/royale/JewelExample/src/main/royale/
> RadioButtonPlayGround.mxml
> > b/examples/royale/JewelExample/src/main/royale/
> RadioButtonPlayGround.mxml
> > index 3d34b18..9e6806d 100644
> > --- a/examples/royale/JewelExample/src/main/royale/
> > RadioButtonPlayGround.mxml
> > +++ b/examples/royale/JewelExample/src/main/royale/
> > RadioButtonPlayGround.mxml
> > @@ -30,7 +30,7 @@ limitations under the License.
> > <html:H3 text="Jewel RadioButton"/>
> >
> > <j:RadioButton text="RadioButton 1" groupName="radios"
> value="Test
> > 1"/>
> > - <j:RadioButton text="RadioButton 2" groupName="radios"
> value="Test
> > 2"/>
> > + <j:RadioButton text="RadioButton 2" groupName="radios"
> value="Test
> > 2" selected="true"/>
> > <j:RadioButton text="RadioButton 3" groupName="radios"
> value="Test
> > 3"/>
> >
> > <j:RadioButton text="Disabled">
> > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/CheckBox.as
> > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/CheckBox.as
> > index d69fad6..5c78dbc 100644
> > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/CheckBox.as
> > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/CheckBox.as
> > @@ -99,11 +99,11 @@ package org.apache.royale.jewel
> >
> > input = addElementToWrapper(this,'input') as
> > HTMLInputElement;
> > input.type = 'checkbox';
> > - input.className = 'input';
> > + //input.className = 'input';
> > label.appendChild(input);
> >
> > checkbox = document.createElement('span') as
> HTMLSpanElement;
> > - checkbox.className = 'span';
> > + //checkbox.className = 'span';
> > label.appendChild(checkbox);
> >
> > positioner = label as WrappedHTMLElement;
> > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/RadioButton.as
> > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/RadioButton.as
> > index 19d5981..b36b51a 100644
> > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/RadioButton.as
> > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/RadioButton.as
> > @@ -316,14 +316,14 @@ package org.apache.royale.jewel
> >
> > icon = addElementToWrapper(this,'input') as
> HTMLInputElement;
> > icon.type = "radio";
> > - icon.className = 'input';
> > + //icon.className = 'input';
> > icon.id = '_radio_' + + Math.random();
> > label.appendChild(icon);
> >
> > textNode = document.createTextNode('') as Text;
> >
> > radio = document.createElement('span') as HTMLSpanElement;
> > - radio.className = 'span';
> > + //radio.className = 'span';
> > radio.appendChild(textNode);
> > label.appendChild(radio);
> > //radio.addEventListener('mouseover', mouseOverHandler,
> > false);
> > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/Slider.as
> > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/Slider.as
> > index 0cb0101..a9ddbbe 100644
> > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/Slider.as
> > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/Slider.as
> > @@ -184,7 +184,7 @@ package org.apache.royale.jewel
> >
> > var input:HTMLInputElement = addElementToWrapper(this,'
> input')
> > as HTMLInputElement;
> > input.setAttribute('type', 'range');
> > - input.className = "slider";
> > + //input.className = "slider";
> >
> > //attach input handler to dispatch royale change
> > event when user write in textinput
> > //goog.events.listen(element, 'change', killChangeHandler);
> > diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/
> royale/jewel/TextField.as
> > b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/TextField.as
> > index 1c12711..a5d5c1c 100644
> > --- a/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/TextField.as
> > +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/
> > royale/jewel/TextField.as
> > @@ -82,7 +82,7 @@ package org.apache.royale.jewel
> >
> > input = addElementToWrapper(this,'input') as
> > HTMLInputElement;
> > input.setAttribute('type', 'text');
> > - input.className = "input";
> > + //input.className = "input";
> >
> > //attach input handler to dispatch royale change event when
> > user write in textinput
> > //goog.events.listen(element, 'change', killChangeHandler);
> > diff --git a/frameworks/themes/JewelTheme/src/main/resources/
> defaults.css
> > b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> > index 8f90431..e23ebd2 100644
> > --- a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> > +++ b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
> > @@ -196,7 +196,7 @@ div {
> > width: 100%;
> > height: 22px;
> > }
> > -.jewel.checkbox .input {
> > +.jewel.checkbox input {
> > -webkit-appearance: none;
> > -moz-appearance: none;
> > -o-appearance: none;
> > @@ -212,26 +212,26 @@ div {
> > border: 1px solid #b3b3b3;
> > border-radius: 3px;
> > }
> > -.jewel.checkbox .input:checked, .jewel.checkbox .input:checked:active {
> > +.jewel.checkbox input:checked, .jewel.checkbox input:checked:active {
> > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16 13'
> > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> > transform='translate(-763, -290)'><g transform='translate(760,
> > 285)'><g><polygon fill='#3CADF1' points='3 13 9 18 19 7 16 5 9 13 6
> > 10'></polygon></g></g></g></svg>");
> > background-repeat: no-repeat;
> > background-size: 90%;
> > background-position: center;
> > background-attachment: fixed;
> > }
> > -.jewel.checkbox .input:focus {
> > +.jewel.checkbox input:focus {
> > outline: none;
> > border: 1px solid #0f88d1;
> > }
> > -.jewel.checkbox .input[disabled] {
> > +.jewel.checkbox input[disabled] {
> > cursor: unset;
> > border: 1px solid #c6c6c6;
> > background: #F9F9F9;
> > }
> > -.jewel.checkbox .input[disabled] + .span {
> > +.jewel.checkbox input[disabled] + .span {
> > color: #c6c6c6;
> > }
> > -.jewel.checkbox .input[disabled]:checked {
> > +.jewel.checkbox input[disabled]:checked {
> > border: 1px solid #c6c6c6;
> > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 16 13'
> > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> > transform='translate(-763, -290)'><g transform='translate(760,
> > 285)'><g><polygon fill='lightgray' points='3 13 9 18 19 7 16 5 9 13 6
> > 10'></polygon></g></g></g></svg>");
> > background-size: 90%;
> > @@ -239,7 +239,7 @@ div {
> > background-repeat: no-repeat;
> > background-attachment: fixed;
> > }
> > -.jewel.checkbox .span {
> > +.jewel.checkbox span {
> > cursor: pointer;
> > position: absolute;
> > margin: 0;
> > @@ -262,7 +262,7 @@ div {
> > width: 100%;
> > height: 22px;
> > }
> > -.jewel.radiobutton .input {
> > +.jewel.radiobutton input {
> > -webkit-appearance: none;
> > -moz-appearance: none;
> > -o-appearance: none;
> > @@ -278,26 +278,26 @@ div {
> > border: 1px solid #b3b3b3;
> > border-radius: 50%;
> > }
> > -.jewel.radiobutton .input:checked, .jewel.radiobutton
> > .input:checked:active {
> > +.jewel.radiobutton input:checked, .jewel.radiobutton
> input:checked:active
> > {
> > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12 12'
> > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> > transform='translate(-616, -350)'><g transform='translate(611,
> > 345)'><g><circle fill='#3CADF1' cx='11' cy='11'
> > r='6'></circle></g></g></g></svg>");
> > background-repeat: no-repeat;
> > background-size: 60%;
> > background-position: center;
> > background-attachment: fixed;
> > }
> > -.jewel.radiobutton .input:focus {
> > +.jewel.radiobutton input:focus {
> > outline: none;
> > border: 1px solid #0f88d1;
> > }
> > -.jewel.radiobutton .input[disabled] {
> > +.jewel.radiobutton input[disabled] {
> > cursor: unset;
> > border: 1px solid #c6c6c6;
> > background: #F9F9F9;
> > }
> > -.jewel.radiobutton .input[disabled] + .span {
> > +.jewel.radiobutton input[disabled] + .span {
> > color: #c6c6c6;
> > }
> > -.jewel.radiobutton .input[disabled]:checked {
> > +.jewel.radiobutton input[disabled]:checked {
> > border: 1px solid #c6c6c6;
> > background: url("data:image/svg+xml;utf8,<svg viewBox='0 0 12 12'
> > version='1.1' xmlns='http://www.w3.org/2000/svg'><g
> > transform='translate(-616, -350)'><g transform='translate(611,
> > 345)'><g><circle fill='lightgray' cx='11' cy='11'
> > r='6'></circle></g></g></g></svg>");
> > background-size: 60%;
> > @@ -305,7 +305,7 @@ div {
> > background-repeat: no-repeat;
> > background-attachment: fixed;
> > }
> > -.jewel.radiobutton .span {
> > +.jewel.radiobutton span {
> > cursor: pointer;
> > position: absolute;
> > margin: 0;
> > @@ -314,7 +314,7 @@ div {
> > line-height: 22px;
> > }
> >
> > -.jewel.slider .slider {
> > +.jewel.slider input {
> > -webkit-appearance: none;
> > width: 100%;
> > height: 15px;
> > @@ -325,13 +325,13 @@ div {
> > -webkit-transition: 0.2s;
> > transition: opacity 0.2s;
> > }
> > -.jewel.slider .slider:hover {
> > +.jewel.slider input:hover {
> > opacity: 1;
> > }
> > -.jewel.slider .slider:focus {
> > +.jewel.slider input:focus {
> > outline: none;
> > }
> > -.jewel.slider .slider::-webkit-slider-thumb {
> > +.jewel.slider input::-webkit-slider-thumb {
> > -webkit-appearance: none;
> > appearance: none;
> > width: 15px;
> > @@ -340,7 +340,7 @@ div {
> > background: #3CADF1;
> > cursor: pointer;
> > }
> > -.jewel.slider .slider::-moz-range-thumb {
> > +.jewel.slider input::-moz-range-thumb {
> > width: 15px;
> > height: 15px;
> > border-radius: 50%;
> > @@ -523,7 +523,7 @@ div {
> > position: relative;
> > display: inline-flex;
> > }
> > -.jewel.textfield .input {
> > +.jewel.textfield input {
> > margin: 0;
> > padding: 0.67em 1em;
> > max-width: 100%;
> > @@ -542,20 +542,20 @@ div {
> > transition-duration: 0.3s;
> > transition-timing-function: easein;
> > }
> > -.jewel.textfield .input:focus {
> > +.jewel.textfield input:focus {
> > border: 1px solid #0f88d1;
> > }
> > -.jewel.textfield .input::placeholder {
> > +.jewel.textfield input::placeholder {
> > color: #a6a6a6;
> > }
> > -.jewel.textfield .input[disabled] {
> > +.jewel.textfield input[disabled] {
> > cursor: unset;
> > border: 1px solid #c6c6c6;
> > background: #F9F9F9;
> > box-shadow: none;
> > color: #c6c6c6;
> > }
> > -.jewel.textfield .input[disabled]::placeholder {
> > +.jewel.textfield input[disabled]::placeholder {
> > color: #c6c6c6;
> > }
> >
> > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> components/_checkbox.sass
> > b/frameworks/themes/JewelTheme/src/main/sass/components/_checkbox.sass
> > index e79c952..92f4fd0 100644
> > --- a/frameworks/themes/JewelTheme/src/main/sass/
> components/_checkbox.sass
> > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> components/_checkbox.sass
> > @@ -39,7 +39,7 @@ $checkbox-label-font-size: 16px
> > height: $checkbox-button-size
> >
> > // -- INPUT
> > - .input
> > + input
> > +appear(none)
> > cursor: pointer
> > display: inline-block
> > @@ -102,7 +102,7 @@ $checkbox-label-font-size: 16px
> > //background: $disabled-color
> >
> > // -- LABEL
> > - .span
> > + span
> > cursor: pointer
> > position: absolute
> > margin: 0
> > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> components/_radiobutton.sass
> > b/frameworks/themes/JewelTheme/src/main/sass/
> components/_radiobutton.sass
> > index a224f28..d45a56a 100644
> > --- a/frameworks/themes/JewelTheme/src/main/sass/
> > components/_radiobutton.sass
> > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> > components/_radiobutton.sass
> > @@ -39,7 +39,7 @@ $radiobutton-label-font-size: 16px
> > height: $radiobutton-button-size
> >
> > // -- INPUT
> > - .input
> > + input
> > +appear(none)
> > cursor: pointer
> > display: inline-block
> > @@ -93,7 +93,7 @@ $radiobutton-label-font-size: 16px
> > background-attachment: fixed
> >
> > // -- LABEL
> > - .span
> > + span
> > cursor: pointer
> > position: absolute
> > margin: 0
> > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> components/_slider.sass
> > b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> > index f92fdd0..115df2c 100644
> > --- a/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> > +++ b/frameworks/themes/JewelTheme/src/main/sass/components/_slider.sass
> > @@ -19,7 +19,7 @@
> >
> > .jewel.slider
> >
> > - .slider
> > + input
> > -webkit-appearance: none
> > width: 100%
> > height: 15px
> > diff --git a/frameworks/themes/JewelTheme/src/main/sass/
> components/_textfield.sass
> > b/frameworks/themes/JewelTheme/src/main/sass/components/_textfield.sass
> > index 4165f6d..3e04d9a 100644
> > --- a/frameworks/themes/JewelTheme/src/main/sass/
> > components/_textfield.sass
> > +++ b/frameworks/themes/JewelTheme/src/main/sass/
> > components/_textfield.sass
> > @@ -32,7 +32,7 @@ $textfield-border-radius: 3px
> > position: relative
> > display: inline-flex
> >
> > - .input
> > + input
> > margin: $textfield-margin
> > padding: $textfield-padding
> >
> >
> > --
> > To stop receiving notification emails like this one, please contact
> > carlosrovira@apache.org.
> >
>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> <https://www.patreon.com/piotrzarzycki>*
>
--
Carlos Rovira
http://about.me/carlosrovira