Re: [PR] [FLINK-35360] support Flink cdc pipeline Yarn application mode [flink-cdc]

["MOBIN-F (via GitHub)" <gi...@apache.org>]

MOBIN-F commented on code in PR #3643:
URL: https://github.com/apache/flink-cdc/pull/3643#discussion_r1998347978


##########
flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/deployment/YarnApplicationDeploymentExecutor.java:
##########
@@ -121,6 +122,10 @@ public PipelineExecution.ExecutionInfo deploy(
 
     private String getFlinkCDCDistJarFromEnv() throws IOException {
         String flinkCDCHomeFromEnvVar = System.getenv(FLINK_CDC_HOME_ENV_VAR);
+        Preconditions.checkNotNull(
+                flinkCDCHomeFromEnvVar,
+                "FLINK_CDC_HOME is not correctly set in environment variable, current FLINK_CDC_HOME is: "
+                        + FLINK_CDC_HOME_ENV_VAR);
         Path flinkCDCLibPath = new Path(flinkCDCHomeFromEnvVar, "lib");

Review Comment:
   Current FLINK_CDC_HOME is derived from flink-cdc.sh. When users integrate flink-cdc, they do not only submit jobs through flink-sh.sh.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org