[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #16014: [fix][broker] Fix create client with TLS config

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #16014:
URL: https://github.com/apache/pulsar/pull/16014#discussion_r896163915


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1418,12 +1418,13 @@ public synchronized PulsarClient getClient() throws PulsarServerException {
                 ClientConfigurationData conf =
                         ConfigurationDataUtils.loadData(overrides, initialConf, ClientConfigurationData.class);
 
-                conf.setServiceUrl(this.getConfiguration().isTlsEnabled()
-                                ? this.brokerServiceUrlTls : this.brokerServiceUrl);
-                conf.setTlsAllowInsecureConnection(this.getConfiguration().isTlsAllowInsecureConnection());
-                conf.setTlsTrustCertsFilePath(this.getConfiguration().getTlsCertificateFilePath());
+                boolean tlsEnabled = this.getConfiguration().isBrokerClientTlsEnabled();

Review Comment:
   Is it worth making it like this:
   
   ```suggestion
                   boolean tlsEnabled = this.getConfiguration().isBrokerClientTlsEnabled() || this.getConfiguration().isTlsEnabled();
   ```
   
   That would ensure backwards compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org