You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2025/10/21 04:46:31 UTC
[PR] Restore timtable active_runs_limit check [airflow]
uranusjr opened a new pull request, #56922:
URL: https://github.com/apache/airflow/pull/56922
This was added in c1aa4b95 but somehow got lost, likely during the SDK migration work. I assume it is unintentional since the timetable attribute is still there, but no longer referenced anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore timtable active_runs_limit check [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #56922:
URL: https://github.com/apache/airflow/pull/56922#discussion_r2446868733
##########
task-sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -533,6 +533,13 @@ def __attrs_post_init__(self):
RemovedInAirflow4Warning,
stacklevel=2,
)
+ if (
+ active_runs_limit := self.timetable.active_runs_limit
Review Comment:
See the original commit (referenced in the first message). This is used by [ContinuousTimetable](https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/timetables/simple/index.html#airflow.timetables.simple.ContinuousTimetable); not very prominently documented but a working feature. (People already using the timetable probably haven’t noticed anything broke since this check only _makes sure_ you set `max_active_runs=1`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore timtable active_runs_limit check [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56922:
URL: https://github.com/apache/airflow/pull/56922#issuecomment-3425418360
### Backport successfully created: v3-1-test
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/pull/56932"><img src="https://img.shields.io/badge/PR-56932-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore timtable active_runs_limit check [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #56922:
URL: https://github.com/apache/airflow/pull/56922#discussion_r2446816405
##########
task-sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -533,6 +533,13 @@ def __attrs_post_init__(self):
RemovedInAirflow4Warning,
stacklevel=2,
)
+ if (
Review Comment:
Would be great to add a test for it. The fact that it was lost is a clear sign that it is prone to regressions (and that test for it is missing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore timtable active_runs_limit check [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #56922:
URL: https://github.com/apache/airflow/pull/56922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore timtable active_runs_limit check [airflow]
Posted by "KoviAnusha (via GitHub)" <gi...@apache.org>.
KoviAnusha commented on code in PR #56922:
URL: https://github.com/apache/airflow/pull/56922#discussion_r2446760702
##########
task-sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -533,6 +533,13 @@ def __attrs_post_init__(self):
RemovedInAirflow4Warning,
stacklevel=2,
)
+ if (
+ active_runs_limit := self.timetable.active_runs_limit
Review Comment:
@uranusjr, could you please explain the use of this? Also, is the explanation of this logic documented somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore timtable active_runs_limit check [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #56922:
URL: https://github.com/apache/airflow/pull/56922#discussion_r2446816405
##########
task-sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -533,6 +533,13 @@ def __attrs_post_init__(self):
RemovedInAirflow4Warning,
stacklevel=2,
)
+ if (
Review Comment:
Would be great to add a test for it. The fact that it was lost is a clear sign that it is prone to regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org