You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/06 12:20:57 UTC
[GitHub] [incubator-nuttx] eaglelaw opened a new pull request, #6797: fix bus_dev.h
eaglelaw opened a new pull request, #6797:
URL: https://github.com/apache/incubator-nuttx/pull/6797
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6797: remove unused lib
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6797:
URL: https://github.com/apache/incubator-nuttx/pull/6797#discussion_r939533074
##########
arch/arm/src/phy62xx/Make.defs:
##########
@@ -20,12 +20,11 @@
include armv6-m/Make.defs
-CMN_ASRCS := $(filter-out arm_exception.S,$(CMN_ASRCS))
+#CMN_ASRCS := $(filter-out arm_exception.S,$(CMN_ASRCS))
Review Comment:
remove the unused code
##########
arch/arm/src/phy62xx/Make.defs:
##########
@@ -60,6 +59,7 @@ INCLUDES += $(shell $(INCDIR) "$(CC)" $(ARCH_SRCDIR)$(DELIM)chip$(DELIM)ble)
#INCLUDES += $(shell $(INCDIR) "$(CC)" $(ARCH_SRCDIR)$(DELIM)chip$(DELIM)ble$(DELIM)include)
#INCLUDES += $(shell $(INCDIR) "$(CC)" $(ARCH_SRCDIR)$(DELIM)chip$(DELIM)osal$(DELIM)include)
+CFLAGS += -ffunction-sections
Review Comment:
remove done in armv6-m/Make.defs
##########
arch/arm/src/phy62xx/Make.defs:
##########
@@ -78,37 +78,31 @@ CFLAGS += -Wno-unused-but-set-variable
CFLAGS += -DEXTERN_BLE_FUNC=0
LDFLAGS += "$(ARCH_SRCDIR)$(DELIM)chip$(DELIM)bb_rom_sym_m0.gdbsym"
-.buildlib:
- $(Q) if [ -d ../../../../phy62xxble ]; then \
- echo "##############build lib internally##############"; \
- make -C ../../../../phy62xxble; \
- else \
- if [ ! -f libphy62xxble.a ]; then \
- echo "############download lib form server############"; \
- curl -L -o libphy62xxble.a http://www.phyplusinc.com/phyplus/libphy62xxble.a; \
- mkdir -p ../../../staging; \
- cp -a libphy62xxble.a ../../../staging; \
- else \
- echo "############file exist############"; \
- fi \
- fi
-
-context:: .buildlib
+LDFLAGS += -Map="../../../phyplus_build.map"
Review Comment:
remove done by armv6-m/Make.defs
##########
arch/arm/src/phy62xx/phy62xx_exception.S:
##########
@@ -1,22 +1,3 @@
-/***************************************************************************
Review Comment:
keep the copyright
##########
arch/arm/src/phy62xx/Make.defs:
##########
@@ -78,37 +78,31 @@ CFLAGS += -Wno-unused-but-set-variable
CFLAGS += -DEXTERN_BLE_FUNC=0
LDFLAGS += "$(ARCH_SRCDIR)$(DELIM)chip$(DELIM)bb_rom_sym_m0.gdbsym"
-.buildlib:
- $(Q) if [ -d ../../../../phy62xxble ]; then \
- echo "##############build lib internally##############"; \
- make -C ../../../../phy62xxble; \
- else \
- if [ ! -f libphy62xxble.a ]; then \
- echo "############download lib form server############"; \
- curl -L -o libphy62xxble.a http://www.phyplusinc.com/phyplus/libphy62xxble.a; \
- mkdir -p ../../../staging; \
- cp -a libphy62xxble.a ../../../staging; \
- else \
- echo "############file exist############"; \
- fi \
- fi
-
-context:: .buildlib
+LDFLAGS += -Map="../../../phyplus_build.map"
ifndef CONFIG_PHY6222_SDK
EXTRA_LIBPATHS += -L$(TOPDIR)/arch/arm/src/chip
-EXTRA_LIBS += -lphy62xxble
CHIP_CSRCS += flash.c
-CHIP_CSRCS += clock.c
+CHIP_CSRCS += clock.c
+CHIP_CSRCS += gpio.c
+CHIP_CSRCS += pwrmgr.c
+CHIP_CSRCS += uart.c
+CHIP_CSRCS += my_printf.c
+CHIP_CSRCS += phy6222_patch.c
+else
+#EXTRA_LIBPATHS += -L$(TOPDIR)/../apps/phy6222/bbb_sdk/lib
Review Comment:
remove the comment
##########
arch/arm/src/phy62xx/Make.defs:
##########
@@ -119,7 +113,9 @@ EXTRA_LIBS += -lethermind_utils
endif
ifdef CONFIG_MIJIA_APIS
-EXTRA_LIBPATHS += -L$(TOPDIR)/../apps/phy6222/bbb_sdk/components/xiaomi/libs/mesh_auth/debug/
-EXTRA_LIBS += -lmesh-auth-cortex-m0plus-debug
+#EXTRA_LIBPATHS += -L$(TOPDIR)/../apps/phy6222/bbb_sdk/components/xiaomi/libs/mesh_auth/debug/
+EXTRA_LIBPATHS += -L$(TOPDIR)/../apps/vendor/phyplus/phy6222_sdk/components/xiaomi/libs/mesh_auth/debug/
+#EXTRA_LIBS += -lmesh-auth-cortex-m0plus-debug
Review Comment:
remove
##########
arch/arm/src/phy62xx/Make.defs:
##########
@@ -119,7 +113,9 @@ EXTRA_LIBS += -lethermind_utils
endif
ifdef CONFIG_MIJIA_APIS
-EXTRA_LIBPATHS += -L$(TOPDIR)/../apps/phy6222/bbb_sdk/components/xiaomi/libs/mesh_auth/debug/
-EXTRA_LIBS += -lmesh-auth-cortex-m0plus-debug
+#EXTRA_LIBPATHS += -L$(TOPDIR)/../apps/phy6222/bbb_sdk/components/xiaomi/libs/mesh_auth/debug/
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] eaglelaw commented on pull request #6797: fix bus_dev.h
Posted by GitBox <gi...@apache.org>.
eaglelaw commented on PR #6797:
URL: https://github.com/apache/incubator-nuttx/pull/6797#issuecomment-1207205550
@xiaoxiang781216 , previous PR seems doesn't working，please review this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6797: fix bus_dev.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6797:
URL: https://github.com/apache/incubator-nuttx/pull/6797#issuecomment-1207214479
@eaglelaw could you merge all change into one patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6797: remove unused lib
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6797:
URL: https://github.com/apache/incubator-nuttx/pull/6797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6797: fix bus_dev.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6797:
URL: https://github.com/apache/incubator-nuttx/pull/6797#issuecomment-1207206168
@eaglelaw please remove the middle merge patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6797: remove unused lib
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6797:
URL: https://github.com/apache/incubator-nuttx/pull/6797#issuecomment-1207222122
Don't change the file permission from 100644 to 100755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org